r/aws_vpc: Add wait_for_ipam_deallocation parameter

[p-hash]

Description

The wait for IPAM pool deallocation was introduced in #30795.
This allows force-recreation of VPC whose CIDR is IPAM-managed to succeed by waiting for IPAM to reach eventual consistency.
Better explanation of the reasoning behind this change can be found here: #31211 (comment)

The problem is that IPAM deallocation takes significant amount of time. For certain use-cases waiting for IPAM can be skipped, like final destroy of the VPC.

This PR introduces a parameter wait_for_ipam_deallocation which defaults to true (current behavior). Thus, if user thinks the wait just adds up execution time unreasonably, wait_for_ipam_deallocation = false could be passed to vpc resource.

Relations

Closes #31211
Relates #27571

References

#30795

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[p-hash]

@justinretzolk @evanphx Is there anything I can do to push this through?

[laminarcode]

Kindly merge. Destroying aws_vpc with IPAM allocation times out currently. A fix is needed.