Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_datasync_task: add task_report_config argument #33861

Merged
merged 18 commits into from
Nov 3, 2023

Conversation

rizkybiz
Copy link
Contributor

Description

This PR introduces the ability to configure AWS DataSync Task Reports.

Relations

Closes #33551

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccXXX'  -timeout 180m
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   3.848s [no tests to run]

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/datasync Issues and PRs that pertain to the datasync service. labels Oct 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 10, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@rizkybiz
Copy link
Contributor Author

rizkybiz commented Oct 10, 2023

This has a dependency of aws-sdk-go v1.45.x so this will have to wait until that dependency is upgraded. Also, if I could get some guidance on tests (if any are needed) that would be greatly appreciated.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@jar-b jar-b self-assigned this Nov 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 2, 2023
@jar-b jar-b changed the title [WIP] Datasync Task Report r/aws_datasync_task: add task_report_config argument Nov 2, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 2, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=datasync TESTS=TestAccDataSyncTask_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncTask_'  -timeout 360m

--- PASS: TestAccDataSyncTask_basic (2461.91s)
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
--- PASS: TestAccDataSyncTask_taskReportConfig (2770.51s)
=== CONT  TestAccDataSyncTask_disappears
--- PASS: TestAccDataSyncTask_schedule (3991.42s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDevices (4023.82s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_uid (4031.54s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (4039.69s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_transferMode (4067.68s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_atimeMtime (4079.51s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles (4094.35s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_gid (4112.52s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond (4116.90s)
--- PASS: TestAccDataSyncTask_excludes (4123.19s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_taskQueueing (4127.10s)
--- PASS: TestAccDataSyncTask_includes (4141.39s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_overwriteMode (4141.99s)
--- PASS: TestAccDataSyncTask_cloudWatchLogGroupARN (4156.98s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_logLevel (4160.76s)
--- PASS: TestAccDataSyncTask_disappears (1607.82s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_verifyMode (4486.71s)
--- PASS: TestAccDataSyncTask_tags (4568.43s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_posixPermissions (2143.15s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags (5128.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   5131.751s

@jar-b jar-b merged commit d4b1dc3 into hashicorp:main Nov 3, 2023
52 checks passed
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 3, 2023
@jar-b
Copy link
Member

jar-b commented Nov 3, 2023

Thanks for your contribution, @rizkybiz and @bruceharrison1984! 👏

Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/datasync Issues and PRs that pertain to the datasync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_datasync_task - Support configuration of task reports
4 participants