Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

Merged
merged 26 commits into from
Sep 6, 2023
Merged

r/aws_s3_object_copy: Migrate to AWS SDK for Go v2 #33330

merged 26 commits into from
Sep 6, 2023

Commits on Sep 5, 2023

  1. s3: 'FindObjectByThreePartKey' -> 'FindObjectByThreePartKeyV1'.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bcff8bc View commit details
    Browse the repository at this point in the history

  2. s3: 'ObjectListTags' -> 'ObjectListTagsV1'.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    54c699c View commit details
    Browse the repository at this point in the history

  3. s3: Generate AWS SDK for Go v2 tagging code.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    74cc696 View commit details
    Browse the repository at this point in the history

  4. r/aws_s3_object_copy: Migrate (except Delete) to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3bad4a9 View commit details
    Browse the repository at this point in the history

  5. s3: Add '-SkipAWSServiceImp' when generating AWS SDK for Go v2 taggin… 

    …g code.
    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    798ce6b View commit details
    Browse the repository at this point in the history

  6. r/aws_s3_object_copy: Migrate acceptance tests to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d170f3a View commit details
    Browse the repository at this point in the history

  7. Run 'go get github.com/hashicorp/aws-sdk-go-base/v2@2572ed001c9c61c7f… 

    …02411dfb0f646000bdb6ab8 && go mod tidy'.
    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    917bd94 View commit details
    Browse the repository at this point in the history

  8. Use 'tfawserr.ErrHTTPStatusCodeEquals'.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    eb905e6 View commit details
    Browse the repository at this point in the history

  9. Call 'resourceObjectCopyRead', not 'resourceObjectRead', from 'resour… 

    …ceObjectCopyDoCopy'.
    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0a532c2 View commit details
    Browse the repository at this point in the history

  10. Tidy up 'TestAccS3ObjectCopy_basic'.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5108f87 View commit details
    Browse the repository at this point in the history

  11. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_basic' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_basic -timeout 180m
=== RUN   TestAccS3ObjectCopy_basic
=== PAUSE TestAccS3ObjectCopy_basic
=== CONT  TestAccS3ObjectCopy_basic
--- PASS: TestAccS3ObjectCopy_basic (42.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	48.447s
    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6a7f556 View commit details
    Browse the repository at this point in the history

  12. Add 'TestAccS3ObjectCopy_disappears'.

    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ae5b011 View commit details
    Browse the repository at this point in the history

  13. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_disappears' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_disappears -timeout 180m
=== RUN   TestAccS3ObjectCopy_disappears
=== PAUSE TestAccS3ObjectCopy_disappears
=== CONT  TestAccS3ObjectCopy_disappears
--- PASS: TestAccS3ObjectCopy_disappears (43.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	48.855s
    @ewbankkit
    ewbankkit committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    271f43e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Add 'TestAccS3ObjectCopy_tags'.

    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    3fbece4 View commit details
    Browse the repository at this point in the history

  2. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_tags' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_tags -timeout 180m
=== RUN   TestAccS3ObjectCopy_tags
=== PAUSE TestAccS3ObjectCopy_tags
=== CONT  TestAccS3ObjectCopy_tags
--- PASS: TestAccS3ObjectCopy_tags (68.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	73.887s
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d8f56b2 View commit details
    Browse the repository at this point in the history

  3. Add 'TestAccS3ObjectCopy_metadata'.

    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    22b34ed View commit details
    Browse the repository at this point in the history

  4. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_metadata' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_metadata -timeout 180m
=== RUN   TestAccS3ObjectCopy_metadata
=== PAUSE TestAccS3ObjectCopy_metadata
=== CONT  TestAccS3ObjectCopy_metadata
--- PASS: TestAccS3ObjectCopy_metadata (74.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	95.276s
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e35c8d6 View commit details
    Browse the repository at this point in the history

  5. Add 'TestAccS3ObjectCopy_grant'.

    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c08c837 View commit details
    Browse the repository at this point in the history

  6. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_grant' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_grant -timeout 180m
=== RUN   TestAccS3ObjectCopy_grant
=== PAUSE TestAccS3ObjectCopy_grant
=== CONT  TestAccS3ObjectCopy_grant
--- PASS: TestAccS3ObjectCopy_grant (26.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	31.858s
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    7595d4e View commit details
    Browse the repository at this point in the history

  7. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_BucketKeyEnabled_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_BucketKeyEnabled_ -timeout 180m
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== RUN   TestAccS3ObjectCopy_BucketKeyEnabled_object
=== PAUSE TestAccS3ObjectCopy_BucketKeyEnabled_object
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_bucket
=== CONT  TestAccS3ObjectCopy_BucketKeyEnabled_object
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_object (27.50s)
--- PASS: TestAccS3ObjectCopy_BucketKeyEnabled_bucket (27.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	33.161s
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    cd16437 View commit details
    Browse the repository at this point in the history

  8. Add 'TestAccS3ObjectCopy_sourceAndTargetWithSlashes'.

    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e66f033 View commit details
    Browse the repository at this point in the history

  9. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_sourceAndTargetWithSlashes' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3ObjectCopy_sourceAndTargetWithSlashes -timeout 180m
=== RUN   TestAccS3ObjectCopy_sourceAndTargetWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceAndTargetWithSlashes
=== CONT  TestAccS3ObjectCopy_sourceAndTargetWithSlashes
--- PASS: TestAccS3ObjectCopy_sourceAndTargetWithSlashes (25.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	31.058s
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    820f6c5 View commit details
    Browse the repository at this point in the history

  10. External source object in 'TestAccS3ObjectCopy_sourceWithSlashes'.

    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ee57bb5 View commit details
    Browse the repository at this point in the history

  11. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccS3ObjectCopy_sourceWithSlashes' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3ObjectCopy_sourceWithSlashes -timeout 180m
=== RUN   TestAccS3ObjectCopy_sourceWithSlashes
=== PAUSE TestAccS3ObjectCopy_sourceWithSlashes
=== CONT  TestAccS3ObjectCopy_sourceWithSlashes
--- PASS: TestAccS3ObjectCopy_sourceWithSlashes (44.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	50.263s
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a0feb96 View commit details
    Browse the repository at this point in the history

  12. r/aws_s3_object_copy: Amazon S3 Object Tags are strongly consistent -… 

    …- remove retry.
    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b16ed8f View commit details
    Browse the repository at this point in the history

  13. s3: 'propagationTimeout' -> 's3BucketPropagationTimeout'.

    @ewbankkit
    ewbankkit committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    99defa8 View commit details
    Browse the repository at this point in the history