Add 'aws_dx_hosted_public_virtual_interface'/'aws_dx_hosted_public_virtual_interface_accepter' resources #3254

ewbankkit · 2018-02-04T23:18:18Z

aws/dx_vif.go and changes to aws/utils*.go shared with:

aws/tagsDX*.go copied from:

Add support for tagging aws_dx_lag and aws_dx_connection resources #2990

ewbankkit · 2018-02-04T23:30:56Z

Acceptance tests require an active Direct Connect connection which should be specified via the DX_CONNECTION_ID environment variable and an AWS account ID for the owner (accepter) of the virtual interface which should be specified via the DX_HOSTED_VIF_OWNER_ACCOUNT environment variable.

export DX_CONNECTION_ID=dxcon-xxxxxxxx
export DX_HOSTED_VIF_OWNER_ACCOUNT=xxxxxxxx
make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxHostedPublicVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_basic
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (39.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.976s

ewbankkit · 2018-02-04T23:31:59Z

This PR and #3253 replace #876.

Add 'aws_dx_hosted_public_virtual_interface_accepter' resource.

ewbankkit · 2018-06-21T22:54:48Z

Rebased to remove conflicts.

…branch.

n3ph · 2018-06-22T17:25:51Z

Confirming acceptance tests in eu-central-1

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxHostedPublicVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_basic
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (35.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.814s

ewbankkit · 2018-06-22T20:36:06Z

Changes after code review on #3253.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxHostedPublicVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_basic
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (44.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.978s

ewbankkit · 2018-06-22T23:59:48Z

Changes after additional code review on #3255.
Ran the example code in the documentation:

$ terraform apply
aws_dx_hosted_public_virtual_interface.creator: Creating...
  address_family:                   "" => "ipv4"
  amazon_address:                   "" => "175.45.176.2/30"
  arn:                              "" => "<computed>"
  bgp_asn:                          "" => "65352"
  bgp_auth_key:                     "" => "<computed>"
  connection_id:                    "" => "dxcon-ffffffff"
  customer_address:                 "" => "175.45.176.1/30"
  name:                             "" => "vif-foo"
  owner_account_id:                 "" => "000000000000"
  route_filter_prefixes.#:          "" => "2"
  route_filter_prefixes.1752038751: "" => "210.52.109.0/24"
  route_filter_prefixes.4290081960: "" => "175.45.176.0/22"
  vlan:                             "" => "4094"
aws_dx_hosted_public_virtual_interface.creator: Still creating... (10s elapsed)
aws_dx_hosted_public_virtual_interface.creator: Creation complete after 13s (ID: dxvif-ffffffff)
aws_dx_hosted_public_virtual_interface_accepter.accepter: Creating...
  arn:                  "" => "<computed>"
  tags.%:               "" => "1"
  tags.Side:            "" => "Accepter"
  virtual_interface_id: "" => "dxvif-ffffffff"
aws_dx_hosted_public_virtual_interface_accepter.accepter: Still creating... (10s elapsed)
aws_dx_hosted_public_virtual_interface_accepter.accepter: Creation complete after 12s (ID: dxvif-ffffffff)

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

$ terraform plan
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

data.aws_caller_identity.accepter: Refreshing state...
aws_dx_hosted_public_virtual_interface.creator: Refreshing state... (ID: dxvif-ffffffff)
aws_dx_hosted_public_virtual_interface_accepter.accepter: Refreshing state... (ID: dxvif-ffffffff)

------------------------------------------------------------------------

No changes. Infrastructure is up-to-date.

$ terraform destroy
data.aws_caller_identity.accepter: Refreshing state...
aws_dx_hosted_public_virtual_interface.creator: Refreshing state... (ID: dxvif-ffffffff)
aws_dx_hosted_public_virtual_interface_accepter.accepter: Refreshing state... (ID: dxvif-ffffffff)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  - aws_dx_hosted_public_virtual_interface.creator

  - aws_dx_hosted_public_virtual_interface_accepter.accepter


Plan: 0 to add, 0 to change, 2 to destroy.

Do you really want to destroy?
  Terraform will destroy all your managed infrastructure, as shown above.
  There is no undo. Only 'yes' will be accepted to confirm.

  Enter a value: yes

aws_dx_hosted_public_virtual_interface_accepter.accepter: Destroying... (ID: dxvif-ffffffff)
aws_dx_hosted_public_virtual_interface_accepter.accepter: Destruction complete after 0s
aws_dx_hosted_public_virtual_interface.creator: Destroying... (ID: dxvif-ffffffff)
aws_dx_hosted_public_virtual_interface.creator: Still destroying... (ID: dxvif-ffffffff, 10s elapsed)
aws_dx_hosted_public_virtual_interface.creator: Destruction complete after 11s

Destroy complete! Resources: 2 destroyed.

n3ph · 2018-06-23T14:57:13Z

Acceptance tests in ´eu-central-1`

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAwsDxHostedPublicVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_basic
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (48.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.620s

n3ph · 2018-06-23T15:05:19Z

Here is a small test case

provider "aws" {
  max_retries = 3
  region      = "eu-central-1"
  profile     = "connect"
}

provider "aws" {
  max_retries = 3
  region      = "eu-central-1"
  profile     = "devops"
  alias       = "accepter"
}

variable "connection_id" {
  default = "dxcon-zzzzzzzz"
}

data "aws_caller_identity" "accepter" {
  provider = "aws.accepter"
}

resource "aws_dx_hosted_public_virtual_interface" "test" {
  connection_id    = "${var.connection_id}"
  owner_account_id = "${data.aws_caller_identity.accepter.account_id}"

  name           = "vif-test"
  vlan           = 1
  address_family = "ipv4"
  bgp_asn        = 65001

  customer_address = "175.45.176.1/30"
  amazon_address   = "175.45.176.2/30"

  route_filter_prefixes = [
    "210.52.109.0/24",
    "175.45.176.0/22",
  ]
}

resource "aws_dx_hosted_public_virtual_interface_accepter" "test" {
  virtual_interface_id = "${aws_dx_hosted_public_virtual_interface.test.id}"

  provider = "aws.accepter"
}

$ terraform apply
data.aws_caller_identity.accepter: Refreshing state...

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  + aws_dx_hosted_public_virtual_interface.test
      id:                               <computed>
      address_family:                   "ipv4"
      amazon_address:                   "175.45.176.2/30"
      arn:                              <computed>
      bgp_asn:                          "65001"
      bgp_auth_key:                     <computed>
      connection_id:                    "dxcon-zzzzzzzz"
      customer_address:                 "175.45.176.1/30"
      name:                             "vif-test"
      owner_account_id:                 "012345678901"
      route_filter_prefixes.#:          "2"
      route_filter_prefixes.1752038751: "210.52.109.0/24"
      route_filter_prefixes.4290081960: "175.45.176.0/22"
      vlan:                             "1"

  + aws_dx_hosted_public_virtual_interface_accepter.test
      id:                               <computed>
      arn:                              <computed>
      virtual_interface_id:             "${aws_dx_hosted_public_virtual_interface.test.id}"


Plan: 2 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_dx_hosted_public_virtual_interface.test: Creating...
  address_family:                   "" => "ipv4"
  amazon_address:                   "" => "175.45.176.2/30"
  arn:                              "" => "<computed>"
  bgp_asn:                          "" => "65001"
  bgp_auth_key:                     "" => "<computed>"
  connection_id:                    "" => "dxcon-zzzzzzzz"
  customer_address:                 "" => "175.45.176.1/30"
  name:                             "" => "vif-test"
  owner_account_id:                 "" => "012345678901"
  route_filter_prefixes.#:          "" => "2"
  route_filter_prefixes.1752038751: "" => "210.52.109.0/24"
  route_filter_prefixes.4290081960: "" => "175.45.176.0/22"
  vlan:                             "" => "1"
aws_dx_hosted_public_virtual_interface.test: Still creating... (10s elapsed)
aws_dx_hosted_public_virtual_interface.test: Creation complete after 11s (ID: dxvif-fgpr4aja)
aws_dx_hosted_public_virtual_interface_accepter.test: Creating...
  arn:                  "" => "<computed>"
  virtual_interface_id: "" => "dxvif-fgpr4aja"
aws_dx_hosted_public_virtual_interface_accepter.test: Still creating... (10s elapsed)
aws_dx_hosted_public_virtual_interface_accepter.test: Creation complete after 11s (ID: dxvif-fgpr4aja)

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

$ terraform apply
data.aws_caller_identity.accepter: Refreshing state...
aws_dx_hosted_public_virtual_interface.test: Refreshing state... (ID: dxvif-fgpr4aja)
aws_dx_hosted_public_virtual_interface_accepter.test: Refreshing state... (ID: dxvif-fgpr4aja)

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

$ terraform destroy
data.aws_caller_identity.accepter: Refreshing state...
aws_dx_hosted_public_virtual_interface.test: Refreshing state... (ID: dxvif-fgpr4aja)
aws_dx_hosted_public_virtual_interface_accepter.test: Refreshing state... (ID: dxvif-fgpr4aja)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  - aws_dx_hosted_public_virtual_interface.test

  - aws_dx_hosted_public_virtual_interface_accepter.test


Plan: 0 to add, 0 to change, 2 to destroy.

Do you really want to destroy?
  Terraform will destroy all your managed infrastructure, as shown above.
  There is no undo. Only 'yes' will be accepted to confirm.

  Enter a value: yes 

aws_dx_hosted_public_virtual_interface_accepter.test: Destroying... (ID: dxvif-fgpr4aja)
aws_dx_hosted_public_virtual_interface_accepter.test: Destruction complete after 0s
aws_dx_hosted_public_virtual_interface.test: Destroying... (ID: dxvif-fgpr4aja)
aws_dx_hosted_public_virtual_interface.test: Still destroying... (ID: dxvif-fgpr4aja, 10s elapsed)
aws_dx_hosted_public_virtual_interface.test: Destruction complete after 11s

Destroy complete! Resources: 2 destroyed.

bflad

Looks great @ewbankkit thanks for all your work here! 🚀

bflad · 2018-06-27T14:03:48Z

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-05T17:13:11Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added the size/XXL Managed by automation to categorize the size of a PR. label Feb 4, 2018

This was referenced Feb 4, 2018

Add 'aws_dx_hosted_private_virtual_interface'/'aws_dx_hosted_private_virtual_interface_accepter' resources #3255

Merged

New Resource: aws_dx_private_virtual_interface #3253

Merged

New Resource: aws_dx_public_virtual_interface #3252

Merged

bflad added new-resource Introduces a new resource. service/directconnect Issues and PRs that pertain to the directconnect service. labels Feb 5, 2018

ghost added the size/XXL Managed by automation to categorize the size of a PR. label Feb 13, 2018

ewbankkit and others added 3 commits June 21, 2018 18:53

Add 'aws_dx_hosted_public_virtual_interface' resource.

a0d27c0

Add 'aws_dx_hosted_public_virtual_interface_accepter' resource.

Fix indentation for configuration generation.

120e6ee

Change interface to 'dxVirtualInterfaceRead'.

4f77ce9

ewbankkit force-pushed the issue-3250 branch from 8e9a86a to 4f77ce9 Compare June 21, 2018 22:54

ghost added the size/XXL Managed by automation to categorize the size of a PR. label Jun 21, 2018

Copy changes to 'dx_vif.go' and 'structure.go' from the 'issue-3248' …

bf47ac3

…branch.

Kit Ewbank added 2 commits June 22, 2018 14:11

Remove 'mergeSchemas'.

889d4c5

Changes after code review on hashicorp#3253.

a119b6d

Changes after additional code review on hashicorp#3255.

5af4581

bflad added this to the v1.25.0 milestone Jun 25, 2018

bflad approved these changes Jun 25, 2018

View reviewed changes

bflad merged commit 5af4581 into hashicorp:master Jun 25, 2018

bflad added a commit that referenced this pull request Jun 25, 2018

Update CHANGELOG for #3254

efb8359

ewbankkit deleted the issue-3250 branch June 25, 2018 14:01

bflad mentioned this pull request Jun 25, 2018

Add initial Direct Connect resources #876

Closed

ghost locked and limited conversation to collaborators Apr 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'aws_dx_hosted_public_virtual_interface'/'aws_dx_hosted_public_virtual_interface_accepter' resources #3254

Add 'aws_dx_hosted_public_virtual_interface'/'aws_dx_hosted_public_virtual_interface_accepter' resources #3254

ewbankkit commented Feb 4, 2018 •

edited

Loading

ewbankkit commented Feb 4, 2018

ewbankkit commented Feb 4, 2018

ewbankkit commented Jun 21, 2018

n3ph commented Jun 22, 2018 •

edited

Loading

ewbankkit commented Jun 22, 2018

ewbankkit commented Jun 22, 2018

n3ph commented Jun 23, 2018 •

edited

Loading

n3ph commented Jun 23, 2018

bflad left a comment

bflad commented Jun 27, 2018

ghost commented Apr 5, 2020

Add 'aws_dx_hosted_public_virtual_interface'/'aws_dx_hosted_public_virtual_interface_accepter' resources #3254

Add 'aws_dx_hosted_public_virtual_interface'/'aws_dx_hosted_public_virtual_interface_accepter' resources #3254

Conversation

ewbankkit commented Feb 4, 2018 • edited Loading

ewbankkit commented Feb 4, 2018

ewbankkit commented Feb 4, 2018

ewbankkit commented Jun 21, 2018

n3ph commented Jun 22, 2018 • edited Loading

ewbankkit commented Jun 22, 2018

ewbankkit commented Jun 22, 2018

n3ph commented Jun 23, 2018 • edited Loading

n3ph commented Jun 23, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad commented Jun 27, 2018

ghost commented Apr 5, 2020

ewbankkit commented Feb 4, 2018 •

edited

Loading

n3ph commented Jun 22, 2018 •

edited

Loading

n3ph commented Jun 23, 2018 •

edited

Loading