Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdkft: use reusable workflow and translate more #32434

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jul 10, 2023

Description

This refactors the action into the reusable github action workflow as a better abstraction and it bumps the cdktf version we use which should handle partial snippets better
I also enabled the translation of lambda, eks, and vpc prefixed docs.
Lastly I removed the org scoped token, it might be possible to create the automatic PR with just the GITHUB_TOKEN (since we don't act on the push or PR trigger where this is problematic)

Relations

Closes #0000

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code service/ipam Issues and PRs that pertain to the ipam service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/wavelength Issues and PRs that pertain to the wavelength service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/vpc Issues and PRs that pertain to the vpc service. service/vpclattice Issues and PRs that pertain to the vpclattice service. labels Jul 10, 2023
@DanielMSchmidt
Copy link
Contributor Author

Oh no, the docs seem to be off, I'll be right back with a new PR

@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jul 10, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. service/ipam Issues and PRs that pertain to the ipam service. service/lambda Issues and PRs that pertain to the lambda service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/wavelength Issues and PRs that pertain to the wavelength service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant