Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_endpoint - add rolling update #32418

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 7, 2023

Description

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSageMakerEndpoint_deploymentConfig_  PKG=sagemaker > a.txt

--- PASS: TestAccSageMakerEndpoint_deploymentConfig_blueGreen (245.65s)
--- PASS: TestAccSageMakerEndpoint_deploymentConfig_rolling (241.55s)

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review July 7, 2023 18:40
@breathingdust breathingdust added the external-maintainer Contribution from a trusted external contributor. label Jul 25, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerEndpoint_' PKG=sagemaker ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 2  -run=TestAccSageMakerEndpoint_ -timeout 180m
=== RUN   TestAccSageMakerEndpoint_basic
=== PAUSE TestAccSageMakerEndpoint_basic
=== RUN   TestAccSageMakerEndpoint_endpointName
=== PAUSE TestAccSageMakerEndpoint_endpointName
=== RUN   TestAccSageMakerEndpoint_tags
=== PAUSE TestAccSageMakerEndpoint_tags
=== RUN   TestAccSageMakerEndpoint_deploymentConfig
=== PAUSE TestAccSageMakerEndpoint_deploymentConfig
=== RUN   TestAccSageMakerEndpoint_deploymentConfig_blueGreen
=== PAUSE TestAccSageMakerEndpoint_deploymentConfig_blueGreen
=== RUN   TestAccSageMakerEndpoint_deploymentConfig_rolling
=== PAUSE TestAccSageMakerEndpoint_deploymentConfig_rolling
=== RUN   TestAccSageMakerEndpoint_disappears
=== PAUSE TestAccSageMakerEndpoint_disappears
=== CONT  TestAccSageMakerEndpoint_basic
=== CONT  TestAccSageMakerEndpoint_deploymentConfig_blueGreen
--- PASS: TestAccSageMakerEndpoint_deploymentConfig_blueGreen (223.97s)
=== CONT  TestAccSageMakerEndpoint_disappears
--- PASS: TestAccSageMakerEndpoint_basic (226.47s)
=== CONT  TestAccSageMakerEndpoint_tags
--- PASS: TestAccSageMakerEndpoint_disappears (250.67s)
=== CONT  TestAccSageMakerEndpoint_deploymentConfig
--- PASS: TestAccSageMakerEndpoint_tags (276.54s)
=== CONT  TestAccSageMakerEndpoint_deploymentConfig_rolling
--- PASS: TestAccSageMakerEndpoint_deploymentConfig (221.04s)
=== CONT  TestAccSageMakerEndpoint_endpointName
--- PASS: TestAccSageMakerEndpoint_deploymentConfig_rolling (223.13s)
--- PASS: TestAccSageMakerEndpoint_endpointName (485.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	1186.518s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 54bbc29 into hashicorp:main Aug 3, 2023
41 checks passed
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants