Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/r/wafv2: add CONSTANT to aggregate_key_type #32396

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

paxal
Copy link
Contributor

@paxal paxal commented Jul 6, 2023

Description

RateBasedStatement supports IP, FORWARDED_IP but also CONSTANT and CUSTOM_KEYS.

CONSTANT is already supported because validation is made against aws SDK where it is declared as valid value.

Relations

Relates to #31625

[RateBasedStatement](https://docs.aws.amazon.com/waf/latest/APIReference/API_RateBasedStatement.html) supports `IP`, `FORWARDED_IP` but also `CONSTANT` and
`CUSTOM_KEYS`.

`CONSTANT` is already supported because validation is made against aws
SDK where it is declared as valid value.

Relates to hashicorp#31625
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Hey @paxal 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @paxal 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@paxal
Copy link
Contributor Author

paxal commented Jul 6, 2023

Shall I create the PR from personal account ? I don't see the setting to allow edit from maintainer.

Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @paxal 👋 Thank you for taking the time to raise this! This looks great to me, so don't worry about the maintainer edit note in this case. I'll get this merged once the checks finish up 🚀

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 6, 2023
@justinretzolk justinretzolk merged commit a4a993f into hashicorp:main Jul 6, 2023
44 checks passed
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 6, 2023
@paxal paxal deleted the doc/constant branch July 6, 2023 16:36
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants