-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/r/wafv2: add CONSTANT to aggregate_key_type #32396
Conversation
[RateBasedStatement](https://docs.aws.amazon.com/waf/latest/APIReference/API_RateBasedStatement.html) supports `IP`, `FORWARDED_IP` but also `CONSTANT` and `CUSTOM_KEYS`. `CONSTANT` is already supported because validation is made against aws SDK where it is declared as valid value. Relates to hashicorp#31625
Community NoteVoting for Prioritization
For Submitters
|
Hey @paxal 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @paxal 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Shall I create the PR from personal account ? I don't see the setting to allow edit from maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @paxal 👋 Thank you for taking the time to raise this! This looks great to me, so don't worry about the maintainer edit note in this case. I'll get this merged once the checks finish up 🚀
This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
RateBasedStatement supports
IP
,FORWARDED_IP
but alsoCONSTANT
andCUSTOM_KEYS
.CONSTANT
is already supported because validation is made against aws SDK where it is declared as valid value.Relations
Relates to #31625