Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source enum validations from AWS Go SDK #31516

Merged
merged 14 commits into from
May 30, 2023
Merged

Conversation

PatMyron
Copy link
Contributor

Relations

#14601, #24286

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/configservice Issues and PRs that pertain to the configservice service. service/guardduty Issues and PRs that pertain to the guardduty service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 21, 2023
@github-actions github-actions bot added the service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. label May 21, 2023
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. service/opensearch Issues and PRs that pertain to the opensearch service. labels May 21, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 22, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2AvailabilityZonesDataSource_filter' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2AvailabilityZonesDataSource_filter -timeout 180m
=== RUN   TestAccEC2AvailabilityZonesDataSource_filter
=== PAUSE TestAccEC2AvailabilityZonesDataSource_filter
=== CONT  TestAccEC2AvailabilityZonesDataSource_filter
--- PASS: TestAccEC2AvailabilityZonesDataSource_filter (14.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	19.592s
% make testacc TESTARGS='-run=TestAccRoute53HealthCheck_withHealthCheckRegions' PKG=route53
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccRoute53HealthCheck_withHealthCheckRegions -timeout 180m
=== RUN   TestAccRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccRoute53HealthCheck_withHealthCheckRegions
=== CONT  TestAccRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (15.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	21.199s

@ewbankkit
Copy link
Contributor

@PatMyron Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7ac2dd9 into hashicorp:main May 30, 2023
@github-actions github-actions bot added this to the v5.1.0 milestone May 30, 2023
@PatMyron PatMyron deleted the patch-1 branch May 30, 2023 17:19
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/configservice Issues and PRs that pertain to the configservice service. service/ec2 Issues and PRs that pertain to the ec2 service. service/guardduty Issues and PRs that pertain to the guardduty service. service/opensearch Issues and PRs that pertain to the opensearch service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants