-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_secretsmanager_secret: Remove rotation_*
#31487
Merged
Merged
Commits on May 16, 2023
-
r/aws_secretsmanager_secret: Remove 'rotation_' attributes.
Acceptance test output: % make testacc TESTARGS='-run=TestAccSecretsManagerSecret_' PKG=secretsmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 3 -run=TestAccSecretsManagerSecret_ -timeout 180m === RUN TestAccSecretsManagerSecret_basic === PAUSE TestAccSecretsManagerSecret_basic === RUN TestAccSecretsManagerSecret_withNamePrefix === PAUSE TestAccSecretsManagerSecret_withNamePrefix === RUN TestAccSecretsManagerSecret_description === PAUSE TestAccSecretsManagerSecret_description === RUN TestAccSecretsManagerSecret_basicReplica === PAUSE TestAccSecretsManagerSecret_basicReplica === RUN TestAccSecretsManagerSecret_overwriteReplica === PAUSE TestAccSecretsManagerSecret_overwriteReplica === RUN TestAccSecretsManagerSecret_kmsKeyID === PAUSE TestAccSecretsManagerSecret_kmsKeyID === RUN TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate === PAUSE TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate === RUN TestAccSecretsManagerSecret_tags === PAUSE TestAccSecretsManagerSecret_tags === RUN TestAccSecretsManagerSecret_policy === PAUSE TestAccSecretsManagerSecret_policy === CONT TestAccSecretsManagerSecret_basic === CONT TestAccSecretsManagerSecret_kmsKeyID === CONT TestAccSecretsManagerSecret_tags --- PASS: TestAccSecretsManagerSecret_basic (16.72s) === CONT TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate --- PASS: TestAccSecretsManagerSecret_kmsKeyID (30.00s) === CONT TestAccSecretsManagerSecret_policy --- PASS: TestAccSecretsManagerSecret_tags (38.13s) === CONT TestAccSecretsManagerSecret_basicReplica --- PASS: TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate (27.78s) === CONT TestAccSecretsManagerSecret_overwriteReplica --- PASS: TestAccSecretsManagerSecret_basicReplica (22.57s) === CONT TestAccSecretsManagerSecret_description --- PASS: TestAccSecretsManagerSecret_policy (55.88s) === CONT TestAccSecretsManagerSecret_withNamePrefix --- PASS: TestAccSecretsManagerSecret_description (27.90s) --- PASS: TestAccSecretsManagerSecret_withNamePrefix (15.35s) --- PASS: TestAccSecretsManagerSecret_overwriteReplica (78.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 127.760s
Configuration menu - View commit details
-
Copy full SHA for fc9f514 - Browse repository at this point
Copy the full SHA fc9f514View commit details -
d/aws_secretsmanager_secret: Remove 'rotation_' attributes.
Acceptance test output: % make testacc TESTARGS='-run=TestAccSecretsManagerSecretDataSource_' PKG=secretsmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 3 -run=TestAccSecretsManagerSecretDataSource_ -timeout 180m === RUN TestAccSecretsManagerSecretDataSource_basic === PAUSE TestAccSecretsManagerSecretDataSource_basic === RUN TestAccSecretsManagerSecretDataSource_arn === PAUSE TestAccSecretsManagerSecretDataSource_arn === RUN TestAccSecretsManagerSecretDataSource_name === PAUSE TestAccSecretsManagerSecretDataSource_name === RUN TestAccSecretsManagerSecretDataSource_policy === PAUSE TestAccSecretsManagerSecretDataSource_policy === CONT TestAccSecretsManagerSecretDataSource_basic === CONT TestAccSecretsManagerSecretDataSource_name === CONT TestAccSecretsManagerSecretDataSource_policy --- PASS: TestAccSecretsManagerSecretDataSource_basic (5.65s) === CONT TestAccSecretsManagerSecretDataSource_arn --- PASS: TestAccSecretsManagerSecretDataSource_name (13.76s) --- PASS: TestAccSecretsManagerSecretDataSource_policy (15.47s) --- PASS: TestAccSecretsManagerSecretDataSource_arn (13.15s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 24.012s
Configuration menu - View commit details
-
Copy full SHA for 1a5204a - Browse repository at this point
Copy the full SHA 1a5204aView commit details
Commits on May 17, 2023
-
r/aws_secretsmanager_secret_rotation: Tidy up.
Acceptance test output: % make testacc TESTARGS='-run=TestAccSecretsManagerSecretRotation_' PKG=secretsmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 3 -run=TestAccSecretsManagerSecretRotation_ -timeout 180m === RUN TestAccSecretsManagerSecretRotation_basic === PAUSE TestAccSecretsManagerSecretRotation_basic === RUN TestAccSecretsManagerSecretRotation_scheduleExpression === PAUSE TestAccSecretsManagerSecretRotation_scheduleExpression === RUN TestAccSecretsManagerSecretRotation_duration === PAUSE TestAccSecretsManagerSecretRotation_duration === CONT TestAccSecretsManagerSecretRotation_basic === CONT TestAccSecretsManagerSecretRotation_scheduleExpression === CONT TestAccSecretsManagerSecretRotation_duration --- PASS: TestAccSecretsManagerSecretRotation_duration (38.07s) --- PASS: TestAccSecretsManagerSecretRotation_basic (60.02s) --- PASS: TestAccSecretsManagerSecretRotation_scheduleExpression (60.04s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 65.978s
Configuration menu - View commit details
-
Copy full SHA for f2667de - Browse repository at this point
Copy the full SHA f2667deView commit details -
d/aws_secretsmanager_secret_rotation: Tidy up.
Acceptance test output: % make testacc TESTARGS='-run=TestAccSecretsManagerSecretRotationDataSource_' PKG=secretsmanager ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 3 -run=TestAccSecretsManagerSecretRotationDataSource_ -timeout 180m === RUN TestAccSecretsManagerSecretRotationDataSource_basic === PAUSE TestAccSecretsManagerSecretRotationDataSource_basic === CONT TestAccSecretsManagerSecretRotationDataSource_basic --- PASS: TestAccSecretsManagerSecretRotationDataSource_basic (30.29s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 35.879s
Configuration menu - View commit details
-
Copy full SHA for 7aed124 - Browse repository at this point
Copy the full SHA 7aed124View commit details
Commits on May 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b53d8f6 - Browse repository at this point
Copy the full SHA b53d8f6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.