Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_codedeploy_deployment_group: Add validation for listener_arns attribute #31402

Closed
wants to merge 3 commits into from
Closed

r/aws_codedeploy_deployment_group: Add validation for listener_arns attribute #31402

wants to merge 3 commits into from

Conversation

Stavrospanakakis
Copy link

Description

  • Added validation for the listener_arns attribute of the aws_codedeploy_deployment_group resource
  • Added documentation regarding this change

Relations

Closes #29628

Output from Acceptance Testing

I was not able to run the Acceptance Tests locally.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/deploy Issues and PRs that pertain to the deploy service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. service/deploy Issues and PRs that pertain to the deploy service. labels May 14, 2023
github-actions[bot]
github-actions bot reviewed May 14, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Stavrospanakakis 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/deploy Issues and PRs that pertain to the deploy service. labels May 14, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 15, 2023
@Stavrospanakakis Stavrospanakakis force-pushed the f-aws_codedeploy_deployment_group-listener_arns-validation branch from e487ab4 to ef1f7d2 Compare June 3, 2023 16:48
@Stavrospanakakis
Copy link
Author

I just rebased the pull request with the main branch 😄

bdoherty-tovala
bdoherty-tovala reviewed Nov 7, 2023
View reviewed changes
website/docs/r/codedeploy_deployment_group.html.markdown
@@ -327,7 +327,7 @@ The `target_group` configuration block supports the following:

The `test_traffic_route` configuration block supports the following:

* `listener_arns` - (Required) List of Amazon Resource Names (ARNs) of the load balancer listeners.
* `listener_arns` - (Required) List of Amazon Resource Names (ARNs) of the load balancer listeners. The list has a maximum size of one.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "There must be exactly one item in this list" would be more clear, as this suggests an empty list is acceptable.

@ewbankkit ewbankkit mentioned this pull request Oct 23, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdoherty-tovala bdoherty-tovala bdoherty-tovala left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/deploy Issues and PRs that pertain to the deploy service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc]: aws_codedeploy_deployment_group - listener_arns
3 participants
@Stavrospanakakis @bdoherty-tovala @justinretzolk