Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F register target resource #31074

Merged
merged 22 commits into from
May 2, 2023

Conversation

markoskandylis
Copy link
Contributor

Description

Adds support for the VPC Lattice Target Register resource.

Relations

Relates #30380
Closes #31039

References

SDK: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/vpclattice@v1.0.2
API: https://docs.aws.amazon.com/sdk-for-go/api/service/vpclattice/
Documentation: https://docs.aws.amazon.com/vpc-lattice/latest/ug/register-targets.html

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccVPCLatticeRegisterTargets_' PKG=vpclattice ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 5  -run=TestAccVPCLatticeRegisterTargets_ -timeout 180m
=== RUN   TestAccVPCLatticeRegisterTargets_instance
=== PAUSE TestAccVPCLatticeRegisterTargets_instance
=== RUN   TestAccVPCLatticeRegisterTargets_ip
=== PAUSE TestAccVPCLatticeRegisterTargets_ip
=== RUN   TestAccVPCLatticeRegisterTargets_lambda
=== PAUSE TestAccVPCLatticeRegisterTargets_lambda
=== RUN   TestAccVPCLatticeRegisterTargets_alb
=== PAUSE TestAccVPCLatticeRegisterTargets_alb
=== CONT  TestAccVPCLatticeRegisterTargets_instance
=== CONT  TestAccVPCLatticeRegisterTargets_lambda
=== CONT  TestAccVPCLatticeRegisterTargets_ip
=== CONT  TestAccVPCLatticeRegisterTargets_alb
--- PASS: TestAccVPCLatticeRegisterTargets_lambda (39.36s)
--- PASS: TestAccVPCLatticeRegisterTargets_ip (123.84s)
--- PASS: TestAccVPCLatticeRegisterTargets_instance (127.98s)
--- PASS: TestAccVPCLatticeRegisterTargets_alb (151.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 154.827s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2023
@ewbankkit ewbankkit added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2023
@ewbankkit ewbankkit self-assigned this May 1, 2023
markoskandylis and others added 5 commits May 2, 2023 10:58
…argetGroupAttachment_instance'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroupAttachment_instance' PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20  -run=TestAccVPCLatticeTargetGroupAttachment_instance -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroupAttachment_instance
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_instance
=== CONT  TestAccVPCLatticeTargetGroupAttachment_instance
--- PASS: TestAccVPCLatticeTargetGroupAttachment_instance (137.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	143.011s
…argetGroupAttachment_ip'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroupAttachment_ip' PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20  -run=TestAccVPCLatticeTargetGroupAttachment_ip -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroupAttachment_ip
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_ip
=== CONT  TestAccVPCLatticeTargetGroupAttachment_ip
--- PASS: TestAccVPCLatticeTargetGroupAttachment_ip (106.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	111.940s
…argetGroupAttachment_lambda'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroupAttachment_lambda' PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20  -run=TestAccVPCLatticeTargetGroupAttachment_lambda -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroupAttachment_lambda
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_lambda
=== CONT  TestAccVPCLatticeTargetGroupAttachment_lambda
--- PASS: TestAccVPCLatticeTargetGroupAttachment_lambda (38.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	43.988s
…argetGroupAttachment_alb'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroupAttachment_alb' PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20  -run=TestAccVPCLatticeTargetGroupAttachment_alb -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroupAttachment_alb
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_alb
=== CONT  TestAccVPCLatticeTargetGroupAttachment_alb
--- PASS: TestAccVPCLatticeTargetGroupAttachment_alb (171.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	176.815s
…tGroupAttachment_disappears'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroupAttachment_disappears' PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20  -run=TestAccVPCLatticeTargetGroupAttachment_disappears -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroupAttachment_disappears
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_disappears
=== CONT  TestAccVPCLatticeTargetGroupAttachment_disappears
--- PASS: TestAccVPCLatticeTargetGroupAttachment_disappears (117.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	122.966s
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label May 2, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeTargetGroupAttachment_' PKG=vpclattice ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeTargetGroupAttachment_ -timeout 180m
=== RUN   TestAccVPCLatticeTargetGroupAttachment_instance
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_instance
=== RUN   TestAccVPCLatticeTargetGroupAttachment_ip
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_ip
=== RUN   TestAccVPCLatticeTargetGroupAttachment_lambda
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_lambda
=== RUN   TestAccVPCLatticeTargetGroupAttachment_alb
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_alb
=== RUN   TestAccVPCLatticeTargetGroupAttachment_disappears
=== PAUSE TestAccVPCLatticeTargetGroupAttachment_disappears
=== CONT  TestAccVPCLatticeTargetGroupAttachment_instance
=== CONT  TestAccVPCLatticeTargetGroupAttachment_alb
=== CONT  TestAccVPCLatticeTargetGroupAttachment_lambda
--- PASS: TestAccVPCLatticeTargetGroupAttachment_lambda (40.85s)
=== CONT  TestAccVPCLatticeTargetGroupAttachment_ip
--- PASS: TestAccVPCLatticeTargetGroupAttachment_instance (136.84s)
=== CONT  TestAccVPCLatticeTargetGroupAttachment_disappears
--- PASS: TestAccVPCLatticeTargetGroupAttachment_ip (118.13s)
--- PASS: TestAccVPCLatticeTargetGroupAttachment_alb (160.29s)
--- PASS: TestAccVPCLatticeTargetGroupAttachment_disappears (153.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	296.444s

@ewbankkit
Copy link
Contributor

@markoskandylis Thanks for the contribution 🎉 👏.
I went ahead and renamed the resource to aws_vpclattice_target_group_attachment to match the name decided upon in the coordinating GitHub Issue: #30380.

@ewbankkit ewbankkit merged commit aae3265 into hashicorp:main May 2, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone May 2, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
@markoskandylis markoskandylis deleted the f-register-target-resource branch June 7, 2023 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Targets To "aws_vpclattice_target_group" Resource Block
2 participants