Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new delete-precheck status for RDS #31047

Merged

Conversation

AdamTylerLynch
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch commented Apr 28, 2023

Description

New delete-precheck status for RDS Custom.

module.vpc.aws_route_table_association.private["private/us-west-2a"]: Destroying... [id=rtbassoc-0656aa92a09e88bdb]
module.vpc.aws_route_table_association.private["private/us-west-2b"]: Destroying... [id=rtbassoc-0ca867f749dc899ce]
module.vpc.aws_route_table_association.private["private/us-west-2c"]: Destroying... [id=rtbassoc-05c492e63cffdbdc6]
aws_db_instance.test-replica[0]: Destroying... [id=ee-replica]
module.vpc.aws_route_table_association.private["private/us-west-2c"]: Destruction complete after 2s
module.vpc.aws_route_table_association.private["private/us-west-2b"]: Destruction complete after 2s
module.vpc.aws_route_table_association.private["private/us-west-2a"]: Destruction complete after 2s
aws_db_instance.test-replica[0]: Still destroying... [id=ee-replica, 10s elapsed]
aws_db_instance.test-replica[0]: Still destroying... [id=ee-replica, 20s elapsed]
aws_db_instance.test-replica[0]: Still destroying... [id=ee-replica, 30s elapsed]
aws_db_instance.test-replica[0]: Still destroying... [id=ee-replica, 40s elapsed]
aws_db_instance.test-replica[0]: Still destroying... [id=ee-replica, 50s elapsed]
aws_db_instance.test-replica[0]: Still destroying... [id=ee-replica, 1m0s elapsed]
2023-04-27T14:47:40.577-0400 [ERROR] provider.terraform-provider-aws_v4.62.0_x5: Response contains error diagnostic: diagnostic_summary="waiting for RDS DB Instance (ee-replica) delete: unexpected state 'delete-precheck', wanted target ''. last error: %!s(<nil>)" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_proto_version=5.3 tf_req_id=711d48d6-0bdd-76f6-6a0d-7b80d44032d4 @caller=github.com/hashicorp/terraform-plugin-go@v0.14.3/tfprotov5/internal/diag/diagnostics.go:55 @module=sdk.proto diagnostic_detail= diagnostic_severity=ERROR tf_resource_type=aws_db_instance tf_rpc=ApplyResourceChange timestamp=2023-04-27T14:47:40.576-0400
2023-04-27T14:47:40.600-0400 [ERROR] vertex "aws_db_instance.test-replica[0] (destroy)" error: waiting for RDS DB Instance (ee-replica) delete: unexpected state 'delete-precheck', wanted target ''. last error: %!s(<nil>)
╷
│ Error: waiting for RDS DB Instance (ee-replica) delete: unexpected state 'delete-precheck', wanted target ''. last error: %!s(<nil>)
│ 
│ 

Relations

Closes #0000

References

Output from Acceptance Testing

ake testacc PKG=rds TESTS=TestAccRDSInstance_basic                                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_basic'  -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_basic
--- PASS: TestAccRDSInstance_basic (500.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	505.897s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Apr 28, 2023
@AdamTylerLynch AdamTylerLynch added partner Contribution from a partner. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 28, 2023
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 28, 2023
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Apr 28, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Apr 28, 2023
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewbankkit ewbankkit self-assigned this Apr 28, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@AdamTylerLynch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Apr 28, 2023
@ewbankkit ewbankkit merged commit 486e9a1 into hashicorp:main Apr 28, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone Apr 28, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants