-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle nil value for AutoVerifiedAttributes in CognitoUserPool #3029
Conversation
…it's set to `nil`
auto_verified_attributes
in CognitoUserPool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luoy thanks for raising this PR! This looks like a good fix, however this change will break this test: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_cognito_user_pool_test.go#L277
With this PR, that line should be:
resource.TestCheckResourceAttr("aws_cognito_user_pool.pool", "auto_verified_attributes.#", "0")
Are you able to run the acceptance tests? If so, all these d.Set()
with flattenStringList
can be adjusted the same way in the code and acceptance testing. If not, no big deal, just let us know and we'll patch/verify it for you.
@bflad This PR seems to be orphaned. Would you mind if I hijacked it and took it till the end? |
@Puneeth-n I've not yet managed to find time to finish it so please do! |
Will give it a spin later and create a separate PR. Thanks :) |
The updated PR has been merged into master and will release with v1.12.0 of the AWS provider, likely in about a week. 😄 |
The updated PR has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #3009