Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil value for AutoVerifiedAttributes in CognitoUserPool #3029

Closed
wants to merge 1 commit into from

Conversation

louy
Copy link

@louy louy commented Jan 17, 2018

Fixes #3009

@louy louy changed the title Don't ignore auto_verified_attributes in CognitoUserPool Handle nil value for AutoVerifiedAttributes in CognitoUserPool Jan 17, 2018
@radeksimko radeksimko added bug Addresses a defect in current functionality. service/cognito labels Jan 17, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luoy thanks for raising this PR! This looks like a good fix, however this change will break this test: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_cognito_user_pool_test.go#L277

With this PR, that line should be:
resource.TestCheckResourceAttr("aws_cognito_user_pool.pool", "auto_verified_attributes.#", "0")

Are you able to run the acceptance tests? If so, all these d.Set() with flattenStringList can be adjusted the same way in the code and acceptance testing. If not, no big deal, just let us know and we'll patch/verify it for you.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 25, 2018
@Puneeth-n
Copy link
Contributor

@bflad This PR seems to be orphaned. Would you mind if I hijacked it and took it till the end?

@louy
Copy link
Author

louy commented Mar 14, 2018

@Puneeth-n I've not yet managed to find time to finish it so please do!

@Puneeth-n
Copy link
Contributor

Will give it a spin later and create a separate PR. Thanks :)

@bflad
Copy link
Contributor

bflad commented Mar 16, 2018

The updated PR has been merged into master and will release with v1.12.0 of the AWS provider, likely in about a week. 😄

@louy louy deleted the patch-1 branch March 16, 2018 13:57
@bflad
Copy link
Contributor

bflad commented Mar 23, 2018

The updated PR has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoVerifiedAttributes for CognitoUserPool being removed by terraform
5 participants