Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: aws_cognito_managed_user_pool_client #30140

Merged
merged 26 commits into from
Mar 24, 2023
Merged

Conversation

gdavison
Copy link
Contributor

Description

Adds new resource aws_cognito_managed_user_pool_client to allow managing Cognito User Pool Clients created and deleted by other services, such as OpenSearch.

Relations

Closes #5557

References

Output from Acceptance Testing

$ make testacc PKG=cognitoidp TESTS='TestAccCognitoIDPUserPoolClient_|TestAccCognitoIDPManagedUserPoolClient_'

--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (69.72s)
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (74.15s)
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (87.41s)
--- PASS: TestAccCognitoIDPUserPoolClient_basic (90.18s)
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (148.39s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (158.57s)
--- PASS: TestAccCognitoIDPUserPoolClient_authSessionValidity (160.96s)
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (162.05s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits_AccessToken (162.54s)
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (163.73s)
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (164.59s)
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (167.16s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (168.23s)
--- PASS: TestAccCognitoIDPUserPoolClient_name (168.28s)
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (169.36s)
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsApplicationID (206.55s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_allFields (1628.83s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits_AccessToken (1644.88s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_analyticsApplicationID (1732.35s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_accessTokenValidity (1645.56s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnitsWTokenValidity (1822.14s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_enableRevocation (1668.74s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_authSessionValidity (1831.03s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_namePattern (1686.57s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_idTokenValidity (1803.11s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_basic (1949.78s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_Disappears_OpenSearchDomain (2122.54s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_allFieldsUpdatingOneField (2183.95s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits (2392.66s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_refreshTokenValidity (2506.18s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/iam Issues and PRs that pertain to the iam service. service/opensearch Issues and PRs that pertain to the opensearch service. service/pinpoint Issues and PRs that pertain to the pinpoint service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 20, 2023
@gdavison gdavison marked this pull request as draft March 20, 2023 22:40
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. service/pinpoint Issues and PRs that pertain to the pinpoint service. labels Mar 21, 2023
@gdavison gdavison marked this pull request as ready for review March 21, 2023 05:17
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolClient_\|TestAccCognitoIDPManagedUserPoolClient_' PKG=cognitoidp ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 3  -run=TestAccCognitoIDPUserPoolClient_\|TestAccCognitoIDPManagedUserPoolClient_ -timeout 360m
=== RUN   TestAccCognitoIDPManagedUserPoolClient_basic
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_basic
=== RUN   TestAccCognitoIDPManagedUserPoolClient_namePattern
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_namePattern
=== RUN   TestAccCognitoIDPManagedUserPoolClient_enableRevocation
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_enableRevocation
=== RUN   TestAccCognitoIDPManagedUserPoolClient_accessTokenValidity
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_accessTokenValidity
=== RUN   TestAccCognitoIDPManagedUserPoolClient_idTokenValidity
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_idTokenValidity
=== RUN   TestAccCognitoIDPManagedUserPoolClient_refreshTokenValidity
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_refreshTokenValidity
=== RUN   TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits
=== RUN   TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits_AccessToken
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits_AccessToken
=== RUN   TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnitsWTokenValidity
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnitsWTokenValidity
=== RUN   TestAccCognitoIDPManagedUserPoolClient_allFields
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_allFields
=== RUN   TestAccCognitoIDPManagedUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_allFieldsUpdatingOneField
=== RUN   TestAccCognitoIDPManagedUserPoolClient_analyticsApplicationID
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_analyticsApplicationID
=== RUN   TestAccCognitoIDPManagedUserPoolClient_analyticsWithARN
    managed_user_pool_client_test.go:675: this test hangs on deletion
--- SKIP: TestAccCognitoIDPManagedUserPoolClient_analyticsWithARN (0.00s)
=== RUN   TestAccCognitoIDPManagedUserPoolClient_authSessionValidity
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_authSessionValidity
=== RUN   TestAccCognitoIDPManagedUserPoolClient_Disappears_OpenSearchDomain
=== PAUSE TestAccCognitoIDPManagedUserPoolClient_Disappears_OpenSearchDomain
=== RUN   TestAccCognitoIDPUserPoolClient_basic
=== PAUSE TestAccCognitoIDPUserPoolClient_basic
=== RUN   TestAccCognitoIDPUserPoolClient_enableRevocation
=== PAUSE TestAccCognitoIDPUserPoolClient_enableRevocation
=== RUN   TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_idTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_idTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnits_AccessToken
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnits_AccessToken
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_name
=== PAUSE TestAccCognitoIDPUserPoolClient_name
=== RUN   TestAccCognitoIDPUserPoolClient_allFields
=== PAUSE TestAccCognitoIDPUserPoolClient_allFields
=== RUN   TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== RUN   TestAccCognitoIDPUserPoolClient_analyticsApplicationID
=== PAUSE TestAccCognitoIDPUserPoolClient_analyticsApplicationID
=== RUN   TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== PAUSE TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== RUN   TestAccCognitoIDPUserPoolClient_authSessionValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_authSessionValidity
=== RUN   TestAccCognitoIDPUserPoolClient_disappears
=== PAUSE TestAccCognitoIDPUserPoolClient_disappears
=== RUN   TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== PAUSE TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== CONT  TestAccCognitoIDPManagedUserPoolClient_basic
=== CONT  TestAccCognitoIDPUserPoolClient_enableRevocation
=== CONT  TestAccCognitoIDPUserPoolClient_allFields
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (23.13s)
=== CONT  TestAccCognitoIDPUserPoolClient_authSessionValidity
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (37.41s)
=== CONT  TestAccCognitoIDPUserPoolClient_Disappears_userPool
--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (13.09s)
=== CONT  TestAccCognitoIDPUserPoolClient_disappears
--- PASS: TestAccCognitoIDPUserPoolClient_authSessionValidity (34.74s)
=== CONT  TestAccCognitoIDPUserPoolClient_analyticsApplicationID
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (15.44s)
=== CONT  TestAccCognitoIDPUserPoolClient_analyticsWithARN
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (32.91s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnitsWTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsApplicationID (45.78s)
=== CONT  TestAccCognitoIDPUserPoolClient_basic
--- PASS: TestAccCognitoIDPUserPoolClient_basic (16.51s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_Disappears_OpenSearchDomain
--- PASS: TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnitsWTokenValidity (1553.98s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_authSessionValidity
--- PASS: TestAccCognitoIDPManagedUserPoolClient_Disappears_OpenSearchDomain (1541.67s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_analyticsApplicationID
--- PASS: TestAccCognitoIDPManagedUserPoolClient_basic (1748.00s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_allFieldsUpdatingOneField
--- PASS: TestAccCognitoIDPManagedUserPoolClient_authSessionValidity (1521.93s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_allFields
--- PASS: TestAccCognitoIDPManagedUserPoolClient_analyticsApplicationID (1582.15s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (29.92s)
=== CONT  TestAccCognitoIDPUserPoolClient_name
--- PASS: TestAccCognitoIDPManagedUserPoolClient_allFieldsUpdatingOneField (1548.45s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnits_AccessToken
--- PASS: TestAccCognitoIDPUserPoolClient_name (29.66s)
=== CONT  TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits_AccessToken (30.64s)
=== CONT  TestAccCognitoIDPUserPoolClient_idTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (27.46s)
=== CONT  TestAccCognitoIDPUserPoolClient_refreshTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (32.39s)
=== CONT  TestAccCognitoIDPUserPoolClient_accessTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (30.03s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_idTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (29.56s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits_AccessToken
--- PASS: TestAccCognitoIDPManagedUserPoolClient_allFields (1568.15s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits
--- PASS: TestAccCognitoIDPManagedUserPoolClient_idTokenValidity (1459.57s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_refreshTokenValidity
--- PASS: TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits_AccessToken (1813.45s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_enableRevocation
--- PASS: TestAccCognitoIDPManagedUserPoolClient_tokenValidityUnits (1584.99s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_accessTokenValidity
--- PASS: TestAccCognitoIDPManagedUserPoolClient_refreshTokenValidity (1736.98s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnits
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (32.82s)
=== CONT  TestAccCognitoIDPManagedUserPoolClient_namePattern
--- PASS: TestAccCognitoIDPManagedUserPoolClient_enableRevocation (1542.20s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_accessTokenValidity (1620.15s)
--- PASS: TestAccCognitoIDPManagedUserPoolClient_namePattern (1713.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	8308.950s

@jar-b jar-b merged commit 95a5fd8 into main Mar 24, 2023
@jar-b jar-b deleted the f-adopt-cognito-app branch March 24, 2023 00:00
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 24, 2023
gdavison added a commit that referenced this pull request Mar 24, 2023
jar-b added a commit that referenced this pull request Mar 24, 2023
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/iam Issues and PRs that pertain to the iam service. service/opensearch Issues and PRs that pertain to the opensearch service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_elasticsearch_domain cognito_options cause Cycle Error
3 participants