Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix and Cleanup: Implement new Lightsail expandOperations across all Lightsail resources. Additionally fix 3 reported Lightsail Bugs. #30056

Merged
merged 43 commits into from
Mar 16, 2023
Merged

BugFix and Cleanup: Implement new Lightsail expandOperations across all Lightsail resources. Additionally fix 3 reported Lightsail Bugs. #30056

merged 43 commits into from
Mar 16, 2023

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Mar 16, 2023 •
edited
Loading

Description

This PR implements a central function for handling Lightsail Operations and its associated errors. This provides a uniform way of checking the operation and providing standard set of errors. Since I was already touching every Lightsail resource, I additionally implemented a fix for a few open bugs reported for Lightsail resources.

Relations

Closes #29884

Moved the error handling of an improperly formatted ID to be before attempting to access the id_parts. This will cause a proper empty resource message instead of a panic when ID is not properly formed.

Closes #28869

Added a check to ensure that the availability_zone value is within the current region of the provider and added tests to validate the proper error is returned to the user when this occurs.

Closes #27927

Added logic to the id splitting functions that allow for the domain entry to begin with a _. Added tests to validate when a domain entry begins with a _. This is a non breaking change

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccLightsail' PKG=lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsail -timeout 180m
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketAccessKey_disappears
=== PAUSE TestAccLightsailBucketAccessKey_disappears
=== RUN   TestAccLightsailBucketResourceAccess_basic
=== PAUSE TestAccLightsailBucketResourceAccess_basic
=== RUN   TestAccLightsailBucketResourceAccess_disappears
=== PAUSE TestAccLightsailBucketResourceAccess_disappears
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailBucket_BundleId
=== PAUSE TestAccLightsailBucket_BundleId
=== RUN   TestAccLightsailBucket_disappears
=== PAUSE TestAccLightsailBucket_disappears
=== RUN   TestAccLightsailBucket_tags
=== PAUSE TestAccLightsailBucket_tags
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_subjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_subjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_tags
=== PAUSE TestAccLightsailCertificate_tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Basic
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Basic
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Environment
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Environment
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Ports
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Ports
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailContainerService_disappears
=== PAUSE TestAccLightsailContainerService_disappears
=== RUN   TestAccLightsailContainerService_Name
=== PAUSE TestAccLightsailContainerService_Name
=== RUN   TestAccLightsailContainerService_IsDisabled
=== PAUSE TestAccLightsailContainerService_IsDisabled
=== RUN   TestAccLightsailContainerService_Power
=== PAUSE TestAccLightsailContainerService_Power
=== RUN   TestAccLightsailContainerService_PublicDomainNames
=== PAUSE TestAccLightsailContainerService_PublicDomainNames
=== RUN   TestAccLightsailContainerService_PrivateRegistryAccess
=== PAUSE TestAccLightsailContainerService_PrivateRegistryAccess
=== RUN   TestAccLightsailContainerService_Scale
=== PAUSE TestAccLightsailContainerService_Scale
=== RUN   TestAccLightsailContainerService_tags
=== PAUSE TestAccLightsailContainerService_tags
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDatabase_relationalDatabaseName
=== PAUSE TestAccLightsailDatabase_relationalDatabaseName
=== RUN   TestAccLightsailDatabase_masterDatabaseName
=== PAUSE TestAccLightsailDatabase_masterDatabaseName
=== RUN   TestAccLightsailDatabase_masterUsername
=== PAUSE TestAccLightsailDatabase_masterUsername
=== RUN   TestAccLightsailDatabase_masterPassword
=== PAUSE TestAccLightsailDatabase_masterPassword
=== RUN   TestAccLightsailDatabase_preferredBackupWindow
=== PAUSE TestAccLightsailDatabase_preferredBackupWindow
=== RUN   TestAccLightsailDatabase_preferredMaintenanceWindow
=== PAUSE TestAccLightsailDatabase_preferredMaintenanceWindow
=== RUN   TestAccLightsailDatabase_publiclyAccessible
=== PAUSE TestAccLightsailDatabase_publiclyAccessible
=== RUN   TestAccLightsailDatabase_backupRetentionEnabled
=== PAUSE TestAccLightsailDatabase_backupRetentionEnabled
=== RUN   TestAccLightsailDatabase_finalSnapshotName
=== PAUSE TestAccLightsailDatabase_finalSnapshotName
=== RUN   TestAccLightsailDatabase_tags
=== PAUSE TestAccLightsailDatabase_tags
=== RUN   TestAccLightsailDatabase_ha
=== PAUSE TestAccLightsailDatabase_ha
=== RUN   TestAccLightsailDatabase_disappears
=== PAUSE TestAccLightsailDatabase_disappears
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN   TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_underscore
=== PAUSE TestAccLightsailDomainEntry_underscore
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== RUN   TestAccLightsailDomain_basic
=== PAUSE TestAccLightsailDomain_basic
=== RUN   TestAccLightsailDomain_disappears
=== PAUSE TestAccLightsailDomain_disappears
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstancePublicPorts_multiple
=== PAUSE TestAccLightsailInstancePublicPorts_multiple
=== RUN   TestAccLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccLightsailInstancePublicPorts_cidrs
=== RUN   TestAccLightsailInstancePublicPorts_cidrListAliases
=== PAUSE TestAccLightsailInstancePublicPorts_cidrListAliases
=== RUN   TestAccLightsailInstancePublicPorts_disappears
=== PAUSE TestAccLightsailInstancePublicPorts_disappears
=== RUN   TestAccLightsailInstancePublicPorts_disappears_Instance
=== PAUSE TestAccLightsailInstancePublicPorts_disappears_Instance
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_availabilityZone
=== PAUSE TestAccLightsailInstance_availabilityZone
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== RUN   TestAccLightsailKeyPair_basic
=== PAUSE TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailKeyPair_publicKey
=== PAUSE TestAccLightsailKeyPair_publicKey
=== RUN   TestAccLightsailKeyPair_encrypted
=== PAUSE TestAccLightsailKeyPair_encrypted
=== RUN   TestAccLightsailKeyPair_namePrefix
=== PAUSE TestAccLightsailKeyPair_namePrefix
=== RUN   TestAccLightsailLoadBalancer_serial
=== PAUSE TestAccLightsailLoadBalancer_serial
=== RUN   TestAccLightsailStaticIPAttachment_basic
=== PAUSE TestAccLightsailStaticIPAttachment_basic
=== RUN   TestAccLightsailStaticIPAttachment_disappears
=== PAUSE TestAccLightsailStaticIPAttachment_disappears
=== RUN   TestAccLightsailStaticIP_basic
=== PAUSE TestAccLightsailStaticIP_basic
=== RUN   TestAccLightsailStaticIP_disappears
=== PAUSE TestAccLightsailStaticIP_disappears
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailDatabase_finalSnapshotName
=== CONT  TestAccLightsailInstancePublicPorts_disappears
=== CONT  TestAccLightsailInstancePublicPorts_cidrListAliases
=== CONT  TestAccLightsailInstancePublicPorts_cidrs
=== CONT  TestAccLightsailInstancePublicPorts_multiple
=== CONT  TestAccLightsailInstancePublicPorts_basic
=== CONT  TestAccLightsailDomain_disappears
=== CONT  TestAccLightsailDomain_basic
=== CONT  TestAccLightsailStaticIP_disappears
=== CONT  TestAccLightsailDisk_Tags
=== CONT  TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDomainEntry_underscore
=== CONT  TestAccLightsailDatabase_ha
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDisk_basic
=== CONT  TestAccLightsailDiskAttachment_disappears
--- PASS: TestAccLightsailDomain_disappears (25.32s)
=== CONT  TestAccLightsailDatabase_tags
--- PASS: TestAccLightsailStaticIP_disappears (25.76s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
--- PASS: TestAccLightsailDomain_basic (27.30s)
=== CONT  TestAccLightsailDatabase_backupRetentionEnabled
--- PASS: TestAccLightsailDomainEntry_disappears (41.33s)
=== CONT  TestAccLightsailDatabase_publiclyAccessible
--- PASS: TestAccLightsailDomainEntry_underscore (43.72s)
=== CONT  TestAccLightsailDatabase_preferredMaintenanceWindow
--- PASS: TestAccLightsailDomainEntry_basic (44.12s)
=== CONT  TestAccLightsailDatabase_preferredBackupWindow
--- PASS: TestAccLightsailBucketAccessKey_basic (54.25s)
=== CONT  TestAccLightsailDatabase_masterPassword
--- PASS: TestAccLightsailDatabase_masterPassword (6.49s)
=== CONT  TestAccLightsailDatabase_masterUsername
--- PASS: TestAccLightsailDisk_disappears (60.92s)
=== CONT  TestAccLightsailDatabase_masterDatabaseName
--- PASS: TestAccLightsailDisk_basic (66.12s)
=== CONT  TestAccLightsailDatabase_relationalDatabaseName
--- PASS: TestAccLightsailInstancePublicPorts_cidrListAliases (67.56s)
=== CONT  TestAccLightsailDatabase_basic
--- PASS: TestAccLightsailInstancePublicPorts_disappears (68.05s)
=== CONT  TestAccLightsailContainerService_tags
--- PASS: TestAccLightsailInstancePublicPorts_basic (69.54s)
=== CONT  TestAccLightsailContainerService_Scale
--- PASS: TestAccLightsailInstancePublicPorts_cidrs (70.27s)
=== CONT  TestAccLightsailContainerService_PrivateRegistryAccess
=== CONT  TestAccLightsailContainerService_PublicDomainNames
--- PASS: TestAccLightsailInstancePublicPorts_multiple (70.87s)
--- PASS: TestAccLightsailContainerService_PublicDomainNames (9.07s)
=== CONT  TestAccLightsailContainerService_Power
--- PASS: TestAccLightsailDisk_Tags (96.82s)
=== CONT  TestAccLightsailContainerService_IsDisabled
--- PASS: TestAccLightsailContainerService_PrivateRegistryAccess (87.23s)
=== CONT  TestAccLightsailContainerService_Name
--- PASS: TestAccLightsailContainerService_tags (101.54s)
=== CONT  TestAccLightsailContainerService_disappears
--- PASS: TestAccLightsailContainerService_Power (97.51s)
=== CONT  TestAccLightsailContainerService_basic
--- PASS: TestAccLightsailContainerService_Scale (108.02s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService
--- PASS: TestAccLightsailDiskAttachment_basic (201.45s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple (208.62s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Ports
--- PASS: TestAccLightsailContainerService_IsDisabled (188.35s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Environment
--- PASS: TestAccLightsailContainerService_disappears (118.30s)
=== CONT  TestAccLightsailBucketResourceAccess_disappears
--- PASS: TestAccLightsailDiskAttachment_disappears (309.29s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Basic
--- PASS: TestAccLightsailContainerService_basic (141.17s)
=== CONT  TestAccLightsailCertificate_disappears
--- PASS: TestAccLightsailBucketResourceAccess_disappears (66.88s)
=== CONT  TestAccLightsailCertificate_tags
--- PASS: TestAccLightsailCertificate_disappears (54.48s)
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
--- PASS: TestAccLightsailContainerService_Name (266.70s)
=== CONT  TestAccLightsailCertificate_subjectAlternativeNames
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (54.91s)
=== CONT  TestAccLightsailCertificate_basic
--- PASS: TestAccLightsailCertificate_tags (98.21s)
=== CONT  TestAccLightsailBucket_tags
--- PASS: TestAccLightsailCertificate_subjectAlternativeNames (55.63s)
=== CONT  TestAccLightsailBucket_disappears
--- PASS: TestAccLightsailCertificate_basic (54.96s)
=== CONT  TestAccLightsailBucket_BundleId
--- PASS: TestAccLightsailBucket_disappears (24.69s)
=== CONT  TestAccLightsailBucket_basic
--- PASS: TestAccLightsailBucket_tags (55.60s)
=== CONT  TestAccLightsailBucketResourceAccess_basic
--- PASS: TestAccLightsailBucket_BundleId (48.47s)
=== CONT  TestAccLightsailBucketAccessKey_disappears
--- PASS: TestAccLightsailBucket_basic (30.25s)
=== CONT  TestAccLightsailStaticIP_basic
--- PASS: TestAccLightsailStaticIP_basic (16.43s)
=== CONT  TestAccLightsailStaticIPAttachment_disappears
--- PASS: TestAccLightsailBucketAccessKey_disappears (40.90s)
=== CONT  TestAccLightsailStaticIPAttachment_basic
--- PASS: TestAccLightsailBucketResourceAccess_basic (69.25s)
=== CONT  TestAccLightsailLoadBalancer_serial
=== RUN   TestAccLightsailLoadBalancer_serial/lb
=== RUN   TestAccLightsailLoadBalancer_serial/lb/basic
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Basic (287.58s)
=== CONT  TestAccLightsailKeyPair_namePrefix
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService (440.10s)
=== CONT  TestAccLightsailKeyPair_encrypted
--- PASS: TestAccLightsailKeyPair_namePrefix (28.21s)
=== CONT  TestAccLightsailKeyPair_publicKey
--- PASS: TestAccLightsailStaticIPAttachment_disappears (80.16s)
=== CONT  TestAccLightsailKeyPair_basic
--- PASS: TestAccLightsailKeyPair_encrypted (26.71s)
=== CONT  TestAccLightsailInstance_disappears
--- PASS: TestAccLightsailKeyPair_publicKey (27.29s)
=== CONT  TestAccLightsailInstance_availabilityZone
=== CONT  TestAccLightsailInstance_addOn
--- PASS: TestAccLightsailInstance_availabilityZone (2.33s)
--- PASS: TestAccLightsailKeyPair_basic (26.09s)
=== CONT  TestAccLightsailInstance_IPAddressType
--- PASS: TestAccLightsailStaticIPAttachment_basic (92.93s)
=== CONT  TestAccLightsailInstance_tags
--- PASS: TestAccLightsailDatabase_disappears (692.47s)
=== CONT  TestAccLightsailInstance_name
--- PASS: TestAccLightsailInstance_disappears (51.00s)
=== CONT  TestAccLightsailInstance_basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb/disappears
=== CONT  TestAccLightsailInstancePublicPorts_disappears_Instance
--- PASS: TestAccLightsailInstance_tags (68.80s)
--- PASS: TestAccLightsailInstance_IPAddressType (77.83s)
=== CONT  TestAccLightsailDatabase_preferredMaintenanceWindow
--- PASS: TestAccLightsailInstance_basic (51.83s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (53.02s)
=== RUN   TestAccLightsailLoadBalancer_serial/lb/name
--- PASS: TestAccLightsailInstance_name (150.12s)
--- PASS: TestAccLightsailDatabase_preferredMaintenanceWindow (853.97s)
--- PASS: TestAccLightsailDatabase_basic (830.66s)
--- PASS: TestAccLightsailInstance_addOn (258.04s)
--- PASS: TestAccLightsailDatabase_preferredBackupWindow (916.03s)
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Ports (827.65s)
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Environment (777.56s)
--- PASS: TestAccLightsailDatabase_relationalDatabaseName (998.61s)
=== RUN   TestAccLightsailLoadBalancer_serial/lb/health_check_path
--- PASS: TestAccLightsailDatabase_publiclyAccessible (1074.24s)
--- PASS: TestAccLightsailDatabase_tags (1181.74s)
--- PASS: TestAccLightsailDatabase_backupRetentionEnabled (1200.29s)
=== RUN   TestAccLightsailLoadBalancer_serial/lb/tags
--- PASS: TestAccLightsailDatabase_finalSnapshotName (1243.08s)
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/basic
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint (1214.79s)
--- PASS: TestAccLightsailDatabase_ha (1611.66s)
--- PASS: TestAccLightsailDatabase_masterUsername (1598.64s)
--- PASS: TestAccLightsailDatabase_masterDatabaseName (1703.91s)
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears
--- PASS: TestAccLightsailLoadBalancer_serial (3598.50s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb (819.77s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/basic (124.29s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/disappears (120.30s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/name (254.26s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/health_check_path (154.70s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/tags (166.22s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment (1054.18s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/basic (520.94s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/disappears (533.24s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate (769.37s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/disappears (180.73s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records (191.56s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names (207.61s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/basic (189.47s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment (184.87s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic (184.87s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy (117.75s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic (117.75s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy (652.56s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic (141.74s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration (163.51s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled (177.05s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears (170.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  4179.416s
...

$ make testacc TESTARGS='-run=TestAccLightsailInstance_avail' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailInstance_avail -timeout 180m
=== RUN   TestAccLightsailInstance_availabilityZone
=== PAUSE TestAccLightsailInstance_availabilityZone
=== CONT  TestAccLightsailInstance_availabilityZone
--- PASS: TestAccLightsailInstance_availabilityZone (3.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  6.674s
...

$  make testacc TESTARGS='-run=TestAccLightsailDomainEntry_under' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDomainEntry_under -timeout 180m
=== RUN   TestAccLightsailDomainEntry_underscore
=== PAUSE TestAccLightsailDomainEntry_underscore
=== CONT  TestAccLightsailDomainEntry_underscore
--- PASS: TestAccLightsailDomainEntry_underscore (32.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  35.794s

@brittandeyoung
lightsail: Add flex, Add expandOperations to standardize operation ha…
aa8af20 
…ndling
@brittandeyoung
lightsail: Amend bucket, expandOperations
8e2bd12
@brittandeyoung
lightsail: Amend bucket_access_key, expandOperations
24cd89b
@brittandeyoung
lightsail: Amend bucket_resource_access, expandOperations
febf37c
@brittandeyoung
lightsail: Amend certificate, expandOperations
d702874
@brittandeyoung
lightsail: Amend database, expandOperations
41e847b
@brittandeyoung
lightsail: Amend disk, expandOperations
ab38674
@brittandeyoung
lightsail: Amend disk_attachment, expandOperations
c4b15b4
@brittandeyoung
lightsail: Amend domain_entry, expandOperations
4d60747
@brittandeyoung
lightsail: Amend instance, expandOperations
7acc770
@brittandeyoung
lightsail: Amend instance_public_ports_test, update blueprint id to v…
c9e618d 
…alid one
@brittandeyoung
lightsail: Amend key_pair, expandOperations
5f24583
@brittandeyoung
lightsail: Amend lb, expandOperations
1db20da
@brittandeyoung
lightsail: Amend lb_attachment, expandOperations
b7bb7ce
@brittandeyoung
lightsail: Amend lb_attachment_test, update blueprint id to valid
95546b2
@brittandeyoung
lightsail: Amend lb_certificate, expandOperations
65bfa0f
@brittandeyoung
lightsail: Amend lb_certificate_attachment, expandOperations
bb9075b
@brittandeyoung
lightsail: Amend lb_https_redirection_policy, expandOperations
9469dc6
@brittandeyoung
lightsail: Amend lb_stickiness_policy, expandOperations
59fe30e
@brittandeyoung
lightsail: Amend static_ip_attachment_test, update to valid blueprint id
36854ba
@brittandeyoung
lightsail: Amend disk_attachment, correct resource name
158bd25
@brittandeyoung
lightsail: Amend lb_attachment, correct action
d9954a5
@brittandeyoung
website: Amend lightsail_disk_attachment, correct blueprint_id
78a0c78
@brittandeyoung
website: Amend lightsail_instance, correct blueprint_id
652faaa
@brittandeyoung
website: Amend lightsail_instance_public_ports, correct blueprint_id
d116a94
@brittandeyoung
website: Amend lightsail_lb_attachment, correct blueprint_id
4d4a581
@brittandeyoung
lightsail: Amend flex, proper casing of errors
ae12750
@brittandeyoung
lightsail: Amend domain, resolve failure to delete errors
ae4f0d6
@brittandeyoung
lightsail: Amend find, allow domain entry to start with _
af51d48
@brittandeyoung
lightsail: Amend domain_entry, allow domain_entry to start with _
0ac6971
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Mar 16, 2023
@brittandeyoung brittandeyoung added bug Addresses a defect in current functionality. flex Pertains to FLatteners and EXpanders. labels Mar 16, 2023
@github-actions github-actions bot removed the flex Pertains to FLatteners and EXpanders. label Mar 16, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2023
ewbankkit
ewbankkit approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccLightsail' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsail -timeout 360m
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketAccessKey_disappears
=== PAUSE TestAccLightsailBucketAccessKey_disappears
=== RUN   TestAccLightsailBucketResourceAccess_basic
=== PAUSE TestAccLightsailBucketResourceAccess_basic
=== RUN   TestAccLightsailBucketResourceAccess_disappears
=== PAUSE TestAccLightsailBucketResourceAccess_disappears
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailBucket_BundleId
=== PAUSE TestAccLightsailBucket_BundleId
=== RUN   TestAccLightsailBucket_disappears
=== PAUSE TestAccLightsailBucket_disappears
=== RUN   TestAccLightsailBucket_tags
=== PAUSE TestAccLightsailBucket_tags
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_subjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_subjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_tags
=== PAUSE TestAccLightsailCertificate_tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Basic
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Basic
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Environment
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Environment
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_Ports
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_Ports
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailContainerService_disappears
=== PAUSE TestAccLightsailContainerService_disappears
=== RUN   TestAccLightsailContainerService_Name
=== PAUSE TestAccLightsailContainerService_Name
=== RUN   TestAccLightsailContainerService_IsDisabled
=== PAUSE TestAccLightsailContainerService_IsDisabled
=== RUN   TestAccLightsailContainerService_Power
=== PAUSE TestAccLightsailContainerService_Power
=== RUN   TestAccLightsailContainerService_PublicDomainNames
=== PAUSE TestAccLightsailContainerService_PublicDomainNames
=== RUN   TestAccLightsailContainerService_PrivateRegistryAccess
=== PAUSE TestAccLightsailContainerService_PrivateRegistryAccess
=== RUN   TestAccLightsailContainerService_Scale
=== PAUSE TestAccLightsailContainerService_Scale
=== RUN   TestAccLightsailContainerService_tags
=== PAUSE TestAccLightsailContainerService_tags
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDatabase_relationalDatabaseName
=== PAUSE TestAccLightsailDatabase_relationalDatabaseName
=== RUN   TestAccLightsailDatabase_masterDatabaseName
=== PAUSE TestAccLightsailDatabase_masterDatabaseName
=== RUN   TestAccLightsailDatabase_masterUsername
=== PAUSE TestAccLightsailDatabase_masterUsername
=== RUN   TestAccLightsailDatabase_masterPassword
=== PAUSE TestAccLightsailDatabase_masterPassword
=== RUN   TestAccLightsailDatabase_preferredBackupWindow
=== PAUSE TestAccLightsailDatabase_preferredBackupWindow
=== RUN   TestAccLightsailDatabase_preferredMaintenanceWindow
=== PAUSE TestAccLightsailDatabase_preferredMaintenanceWindow
=== RUN   TestAccLightsailDatabase_publiclyAccessible
=== PAUSE TestAccLightsailDatabase_publiclyAccessible
=== RUN   TestAccLightsailDatabase_backupRetentionEnabled
=== PAUSE TestAccLightsailDatabase_backupRetentionEnabled
=== RUN   TestAccLightsailDatabase_finalSnapshotName
=== PAUSE TestAccLightsailDatabase_finalSnapshotName
=== RUN   TestAccLightsailDatabase_tags
=== PAUSE TestAccLightsailDatabase_tags
=== RUN   TestAccLightsailDatabase_ha
=== PAUSE TestAccLightsailDatabase_ha
=== RUN   TestAccLightsailDatabase_disappears
=== PAUSE TestAccLightsailDatabase_disappears
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN   TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_underscore
=== PAUSE TestAccLightsailDomainEntry_underscore
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== RUN   TestAccLightsailDomain_basic
=== PAUSE TestAccLightsailDomain_basic
=== RUN   TestAccLightsailDomain_disappears
=== PAUSE TestAccLightsailDomain_disappears
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstancePublicPorts_multiple
=== PAUSE TestAccLightsailInstancePublicPorts_multiple
=== RUN   TestAccLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccLightsailInstancePublicPorts_cidrs
=== RUN   TestAccLightsailInstancePublicPorts_cidrListAliases
=== PAUSE TestAccLightsailInstancePublicPorts_cidrListAliases
=== RUN   TestAccLightsailInstancePublicPorts_disappears
=== PAUSE TestAccLightsailInstancePublicPorts_disappears
=== RUN   TestAccLightsailInstancePublicPorts_disappears_Instance
=== PAUSE TestAccLightsailInstancePublicPorts_disappears_Instance
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_availabilityZone
    instance_test.go:279: skipping test; environment variable TF_AWS_LIGHTSAIL_AVAILABILITY_ZONE must be set. Usage: The availability zone that is outside the providers current region.
--- SKIP: TestAccLightsailInstance_availabilityZone (0.00s)
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== RUN   TestAccLightsailKeyPair_basic
=== PAUSE TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailKeyPair_publicKey
=== PAUSE TestAccLightsailKeyPair_publicKey
=== RUN   TestAccLightsailKeyPair_encrypted
=== PAUSE TestAccLightsailKeyPair_encrypted
=== RUN   TestAccLightsailKeyPair_namePrefix
=== PAUSE TestAccLightsailKeyPair_namePrefix
=== RUN   TestAccLightsailLoadBalancer_serial
=== PAUSE TestAccLightsailLoadBalancer_serial
=== RUN   TestAccLightsailStaticIPAttachment_basic
=== PAUSE TestAccLightsailStaticIPAttachment_basic
=== RUN   TestAccLightsailStaticIPAttachment_disappears
=== PAUSE TestAccLightsailStaticIPAttachment_disappears
=== RUN   TestAccLightsailStaticIP_basic
=== PAUSE TestAccLightsailStaticIP_basic
=== RUN   TestAccLightsailStaticIP_disappears
=== PAUSE TestAccLightsailStaticIP_disappears
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailDatabase_finalSnapshotName
--- PASS: TestAccLightsailBucketAccessKey_basic (49.43s)
=== CONT  TestAccLightsailContainerService_basic
--- PASS: TestAccLightsailContainerService_basic (89.12s)
=== CONT  TestAccLightsailDatabase_backupRetentionEnabled
--- PASS: TestAccLightsailDatabase_finalSnapshotName (957.40s)
=== CONT  TestAccLightsailDatabase_publiclyAccessible
--- PASS: TestAccLightsailDatabase_backupRetentionEnabled (1089.33s)
=== CONT  TestAccLightsailDatabase_preferredMaintenanceWindow
--- PASS: TestAccLightsailDatabase_publiclyAccessible (950.22s)
=== CONT  TestAccLightsailDatabase_preferredBackupWindow
--- PASS: TestAccLightsailDatabase_preferredMaintenanceWindow (841.09s)
=== CONT  TestAccLightsailDatabase_masterPassword
--- PASS: TestAccLightsailDatabase_masterPassword (4.38s)
=== CONT  TestAccLightsailDatabase_masterUsername
--- PASS: TestAccLightsailDatabase_preferredBackupWindow (896.86s)
=== CONT  TestAccLightsailDatabase_masterDatabaseName
--- PASS: TestAccLightsailDatabase_masterUsername (1579.06s)
=== CONT  TestAccLightsailDatabase_relationalDatabaseName
--- PASS: TestAccLightsailDatabase_masterDatabaseName (1460.82s)
=== CONT  TestAccLightsailDatabase_basic
--- PASS: TestAccLightsailDatabase_relationalDatabaseName (764.19s)
=== CONT  TestAccLightsailContainerService_tags
--- PASS: TestAccLightsailContainerService_tags (104.82s)
=== CONT  TestAccLightsailContainerService_Scale
--- PASS: TestAccLightsailContainerService_Scale (93.64s)
=== CONT  TestAccLightsailContainerService_PrivateRegistryAccess
--- PASS: TestAccLightsailContainerService_PrivateRegistryAccess (67.75s)
=== CONT  TestAccLightsailContainerService_PublicDomainNames
--- PASS: TestAccLightsailContainerService_PublicDomainNames (7.65s)
=== CONT  TestAccLightsailContainerService_Power
--- PASS: TestAccLightsailContainerService_Power (95.54s)
=== CONT  TestAccLightsailContainerService_IsDisabled
--- PASS: TestAccLightsailContainerService_IsDisabled (104.76s)
=== CONT  TestAccLightsailContainerService_Name
--- PASS: TestAccLightsailContainerService_Name (142.04s)
=== CONT  TestAccLightsailContainerService_disappears
--- PASS: TestAccLightsailContainerService_disappears (64.93s)
=== CONT  TestAccLightsailDomainEntry_basic
    acctest.go:833: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomainEntry_basic (0.00s)
=== CONT  TestAccLightsailInstancePublicPorts_cidrListAliases
--- PASS: TestAccLightsailInstancePublicPorts_cidrListAliases (55.30s)
=== CONT  TestAccLightsailInstancePublicPorts_cidrs
--- PASS: TestAccLightsailDatabase_basic (946.59s)
=== CONT  TestAccLightsailInstancePublicPorts_disappears
--- PASS: TestAccLightsailInstancePublicPorts_cidrs (55.70s)
=== CONT  TestAccLightsailStaticIP_disappears
--- PASS: TestAccLightsailStaticIP_disappears (14.54s)
=== CONT  TestAccLightsailStaticIP_basic
--- PASS: TestAccLightsailStaticIP_basic (17.12s)
=== CONT  TestAccLightsailStaticIPAttachment_disappears
--- PASS: TestAccLightsailInstancePublicPorts_disappears (55.61s)
=== CONT  TestAccLightsailInstancePublicPorts_multiple
--- PASS: TestAccLightsailInstancePublicPorts_multiple (58.20s)
=== CONT  TestAccLightsailStaticIPAttachment_basic
--- PASS: TestAccLightsailStaticIPAttachment_disappears (79.15s)
=== CONT  TestAccLightsailInstancePublicPorts_basic
--- PASS: TestAccLightsailInstancePublicPorts_basic (55.28s)
=== CONT  TestAccLightsailDomain_disappears
    acctest.go:833: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomain_disappears (0.00s)
=== CONT  TestAccLightsailDomain_basic
    acctest.go:833: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomain_basic (0.00s)
=== CONT  TestAccLightsailDomainEntry_disappears
    acctest.go:833: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomainEntry_disappears (0.00s)
=== CONT  TestAccLightsailDomainEntry_underscore
    acctest.go:833: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomainEntry_underscore (0.00s)
=== CONT  TestAccLightsailInstance_addOn
--- PASS: TestAccLightsailStaticIPAttachment_basic (79.57s)
=== CONT  TestAccLightsailKeyPair_namePrefix
--- PASS: TestAccLightsailKeyPair_namePrefix (27.94s)
=== CONT  TestAccLightsailKeyPair_encrypted
--- PASS: TestAccLightsailKeyPair_encrypted (26.47s)
=== CONT  TestAccLightsailKeyPair_publicKey
--- PASS: TestAccLightsailKeyPair_publicKey (26.93s)
=== CONT  TestAccLightsailLoadBalancer_serial
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/basic
--- PASS: TestAccLightsailInstance_addOn (262.01s)
=== CONT  TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/disappears
--- PASS: TestAccLightsailKeyPair_basic (27.13s)
=== CONT  TestAccLightsailInstance_IPAddressType
--- PASS: TestAccLightsailInstance_IPAddressType (75.74s)
=== CONT  TestAccLightsailInstance_tags
--- PASS: TestAccLightsailInstance_tags (65.86s)
=== CONT  TestAccLightsailInstance_name
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records
--- PASS: TestAccLightsailInstance_name (149.54s)
=== CONT  TestAccLightsailInstance_basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names
--- PASS: TestAccLightsailInstance_basic (51.29s)
=== CONT  TestAccLightsailInstancePublicPorts_disappears_Instance
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (52.26s)
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (55.79s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple
    container_service_deployment_version_test.go:144: Step 1/2 error: Check failed: Check 5/8 error: aws_lightsail_container_service_deployment_version.test: Attribute 'container.0.container_name' expected "tf-acc-test-8263175743951155058", got "tf-acc-test-7044150771276880255"
--- FAIL: TestAccLightsailContainerServiceDeploymentVersion_Container_Multiple (242.54s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Basic (232.22s)
=== CONT  TestAccLightsailCertificate_disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled
--- PASS: TestAccLightsailCertificate_disappears (53.22s)
=== CONT  TestAccLightsailCertificate_tags
--- PASS: TestAccLightsailCertificate_tags (97.64s)
=== CONT  TestAccLightsailInstance_disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears
--- PASS: TestAccLightsailInstance_disappears (50.57s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb
=== RUN   TestAccLightsailLoadBalancer_serial/lb/tags
=== RUN   TestAccLightsailLoadBalancer_serial/lb/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb/name
=== RUN   TestAccLightsailLoadBalancer_serial/lb/health_check_path
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/basic
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_PublicEndpoint (1139.37s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_EnableService (257.22s)
=== CONT  TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/disappears
--- PASS: TestAccLightsailDiskAttachment_disappears (185.09s)
=== CONT  TestAccLightsailDisk_disappears
--- PASS: TestAccLightsailDisk_disappears (62.75s)
=== CONT  TestAccLightsailDisk_Tags
--- PASS: TestAccLightsailDisk_Tags (88.07s)
=== CONT  TestAccLightsailDisk_basic
--- PASS: TestAccLightsailDisk_basic (52.48s)
=== CONT  TestAccLightsailDatabase_disappears
--- PASS: TestAccLightsailLoadBalancer_serial (3359.35s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate (701.84s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/basic (179.95s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/disappears (165.38s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records (169.48s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names (187.04s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment (170.35s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic (170.35s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy (115.10s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic (115.10s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy (581.02s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration (152.28s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled (162.53s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears (137.63s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic (128.59s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb (764.07s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/tags (159.47s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/basic (123.60s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/disappears (120.51s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/name (221.52s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/health_check_path (138.96s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment (1026.96s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/basic (515.51s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/disappears (511.45s)
=== CONT  TestAccLightsailDiskAttachment_basic
--- PASS: TestAccLightsailDiskAttachment_basic (190.43s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Environment
--- PASS: TestAccLightsailDatabase_disappears (565.49s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_Container_Ports
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Ports (672.21s)
=== CONT  TestAccLightsailDatabase_ha
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_Container_Environment (801.99s)
=== CONT  TestAccLightsailBucket_BundleId
--- PASS: TestAccLightsailBucket_BundleId (52.83s)
=== CONT  TestAccLightsailBucket_tags
--- PASS: TestAccLightsailBucket_tags (62.93s)
=== CONT  TestAccLightsailCertificate_basic
--- PASS: TestAccLightsailCertificate_basic (56.02s)
=== CONT  TestAccLightsailCertificate_subjectAlternativeNames
--- PASS: TestAccLightsailCertificate_subjectAlternativeNames (55.99s)
=== CONT  TestAccLightsailDatabase_tags
--- PASS: TestAccLightsailDatabase_tags (818.19s)
=== CONT  TestAccLightsailBucketResourceAccess_disappears
--- PASS: TestAccLightsailBucketResourceAccess_disappears (69.49s)
=== CONT  TestAccLightsailBucketResourceAccess_basic
--- PASS: TestAccLightsailBucketResourceAccess_basic (72.24s)
=== CONT  TestAccLightsailBucket_disappears
--- PASS: TestAccLightsailBucket_disappears (28.67s)
=== CONT  TestAccLightsailBucket_basic
--- PASS: TestAccLightsailBucket_basic (40.15s)
=== CONT  TestAccLightsailBucketAccessKey_disappears
--- PASS: TestAccLightsailBucketAccessKey_disappears (46.22s)
--- PASS: TestAccLightsailDatabase_ha (1519.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	11359.961s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 11d3319 into hashicorp:main Mar 16, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 16, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.59.0
2 participants
@brittandeyoung @ewbankkit