-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamodb/table_replica: Fix creation error when KMS #29102
Conversation
Community NoteVoting for Prioritization
For Submitters
|
This functionality has been released in v4.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
if replica.KMSMasterKeyId == nil || aws.StringValue(replica.KMSMasterKeyId) == dk { | ||
d.Set("kms_key_arn", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I'm using a default KMS key on DynamoDB, and recently I updated my AWS provider to include this change. However, I'm now seeing that Terraform keeps planning to delete/recreate my replica because it thinks the kms_key_arn
is not set (and wants to set it to the default KMS key ARN). Could this change be related to that?
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
aws_dynamodb_table_replica
: Fix to allow creation of the replica without errors whenkms_key_arn
is setaws_dynamodb_table_replica
: Fix to allow updating ofkms_key_arn
aws_dynamodb_table_replica
: Updatingkms_key_arn
forces replacement of the replica now as required to re-encrypt the replicaaws_dynamodb_table
: Fix to allow updating ofreplica.*.kms_key_arn
aws_dynamodb_table
: Fix to allow updating ofreplica.*.point_in_time_recovery
when areplica
haskms_key_arn
setaws_dynamodb_table
: Updatingreplica.*.kms_key_arn
orreplica.*.point_in_time_recovery
, when thereplica
'skms_key_arn
is set, requires recreating the replica.The error message
ValidationException: One or more parameter values were invalid: KMSMasterKeyId must be specified for each replica.
actually means at least two pretty much unrelated things:Relations
Closes #26552
Closes #28814
Closes #28010
Closes #27850
Closes #25812
References
Output from Acceptance Testing