tests/aws_appautoscaling_*: Remove role_arn

[radeksimko]

Related to #2889

Before

(broken by introduced API changes)

=== RUN   TestAccAWSAppautoScalingPolicy_basic
--- FAIL: TestAccAWSAppautoScalingPolicy_basic (23.00s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.tgt
          max_capacity:       "4" => "4"
          min_capacity:       "1" => "1"
          resource_id:        "service/clusterjpehs2et3o/foobar" => "service/clusterjpehs2et3o/foobar"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/ecs.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_ECSService" => "arn:aws:iam::*******:role/clusterjpehs2et3o" (forces new resource)
          scalable_dimension: "ecs:service:DesiredCount" => "ecs:service:DesiredCount"
          service_namespace:  "ecs" => "ecs"

        ...

=== RUN   TestAccAWSAppautoScalingPolicy_dynamoDb
--- FAIL: TestAccAWSAppautoScalingPolicy_dynamoDb (18.46s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.dynamo_test
          max_capacity:       "10" => "10"
          min_capacity:       "1" => "1"
          resource_id:        "table/test-appautoscaling-policy-v3f3w" => "table/test-appautoscaling-policy-v3f3w"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/dynamodb.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_DynamoDBTable" => "arn:aws:iam::*******:role/terraform-20180109045056575800000001" (forces new resource)
          scalable_dimension: "dynamodb:table:WriteCapacityUnits" => "dynamodb:table:WriteCapacityUnits"
          service_namespace:  "dynamodb" => "dynamodb"

        ...

=== RUN   TestAccAWSAppautoScalingPolicy_multiplePolicies
--- FAIL: TestAccAWSAppautoScalingPolicy_multiplePolicies (16.12s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.read
          max_capacity:       "10" => "10"
          min_capacity:       "1" => "1"
          resource_id:        "table/tf-autoscaled-table-942zg" => "table/tf-autoscaled-table-942zg"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/dynamodb.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_DynamoDBTable" => "arn:aws:iam::*******:role/terraform-20180109045113595800000001" (forces new resource)
          scalable_dimension: "dynamodb:table:ReadCapacityUnits" => "dynamodb:table:ReadCapacityUnits"
          service_namespace:  "dynamodb" => "dynamodb"
        DESTROY/CREATE: aws_appautoscaling_target.write
          max_capacity:       "10" => "10"
          min_capacity:       "1" => "1"
          resource_id:        "table/tf-autoscaled-table-942zg" => "table/tf-autoscaled-table-942zg"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/dynamodb.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_DynamoDBTable" => "arn:aws:iam::*******:role/terraform-20180109045113595800000001" (forces new resource)
          scalable_dimension: "dynamodb:table:WriteCapacityUnits" => "dynamodb:table:WriteCapacityUnits"
          service_namespace:  "dynamodb" => "dynamodb"

        ...

=== RUN   TestAccAWSAppautoScalingPolicy_nestedSchema
--- FAIL: TestAccAWSAppautoScalingPolicy_nestedSchema (14.62s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.tgt
          max_capacity:       "4" => "4"
          min_capacity:       "1" => "1"
          resource_id:        "service/clusterj8acd3pmd0/foobar" => "service/clusterj8acd3pmd0/foobar"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/ecs.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_ECSService" => "arn:aws:iam::*******:role/clusterj8acd3pmd0" (forces new resource)
          scalable_dimension: "ecs:service:DesiredCount" => "ecs:service:DesiredCount"
          service_namespace:  "ecs" => "ecs"
        
        ...

=== RUN   TestAccAWSAppautoScalingPolicy_spotFleetRequest
--- FAIL: TestAccAWSAppautoScalingPolicy_spotFleetRequest (56.05s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.test
          max_capacity:       "3" => "3"
          min_capacity:       "1" => "1"
          resource_id:        "spot-fleet-request/sfr-533cca3a-8bf2-4566-9e96-4a016522442a" => "spot-fleet-request/sfr-533cca3a-8bf2-4566-9e96-4a016522442a"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/ec2.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_EC2SpotFleetRequest" => "arn:aws:iam::*******:role/terraform-20180109045052291400000001" (forces new resource)
          scalable_dimension: "ec2:spot-fleet-request:TargetCapacity" => "ec2:spot-fleet-request:TargetCapacity"
          service_namespace:  "ec2" => "ec2"
        
        ...

=== RUN   TestAccAwsAppautoscalingScheduledAction_ECS
--- FAIL: TestAccAwsAppautoscalingScheduledAction_ECS (32.46s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.hoge
          max_capacity:       "3" => "3"
          min_capacity:       "1" => "1"
          resource_id:        "service/tf-ecs-cluster-epwa7/tf-ecs-service-epwa7" => "service/tf-ecs-cluster-epwa7/tf-ecs-service-epwa7"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/ecs.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_ECSService" => "arn:aws:iam::*******:role/terraform-20180109045129718300000001" (forces new resource)
          scalable_dimension: "ecs:service:DesiredCount" => "ecs:service:DesiredCount"
          service_namespace:  "ecs" => "ecs"
        
        ...

=== RUN   TestAccAwsAppautoscalingScheduledAction_SpotFleet
--- FAIL: TestAccAwsAppautoscalingScheduledAction_SpotFleet (56.02s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.hoge
          max_capacity:       "3" => "3"
          min_capacity:       "1" => "1"
          resource_id:        "spot-fleet-request/sfr-c3184700-7fdc-4ba2-8cb9-a6becf2015eb" => "spot-fleet-request/sfr-c3184700-7fdc-4ba2-8cb9-a6becf2015eb"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/ec2.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_EC2SpotFleetRequest" => "arn:aws:iam::*******:role/terraform-20180109045143503700000002" (forces new resource)
          scalable_dimension: "ec2:spot-fleet-request:TargetCapacity" => "ec2:spot-fleet-request:TargetCapacity"
          service_namespace:  "ec2" => "ec2"
        
        ...

=== RUN   TestAccAwsAppautoscalingScheduledAction_dynamo
--- FAIL: TestAccAwsAppautoscalingScheduledAction_dynamo (17.22s)
    testing.go:503: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_appautoscaling_target.read
          max_capacity:       "10" => "10"
          min_capacity:       "1" => "1"
          resource_id:        "table/tf-ddb-fdchl" => "table/tf-ddb-fdchl"
          role_arn:           "arn:aws:iam::*******:role/aws-service-role/dynamodb.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_DynamoDBTable" => "arn:aws:iam::*******:role/terraform-20180109045115033300000001" (forces new resource)
          scalable_dimension: "dynamodb:table:ReadCapacityUnits" => "dynamodb:table:ReadCapacityUnits"
          service_namespace:  "dynamodb" => "dynamodb"
        
        ...

After

=== RUN   TestAccAWSAppautoScalingPolicy_basic
--- PASS: TestAccAWSAppautoScalingPolicy_basic (11.87s)
=== RUN   TestAccAWSAppautoScalingPolicy_nestedSchema
--- PASS: TestAccAWSAppautoScalingPolicy_nestedSchema (15.31s)
=== RUN   TestAccAWSAppautoScalingPolicy_multiplePolicies
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePolicies (19.18s)
=== RUN   TestAccAWSAppautoScalingPolicy_dynamoDb
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (19.27s)
=== RUN   TestAccAWSAppautoScalingPolicy_spotFleetRequest
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (50.07s)
=== RUN   TestAccAwsAppautoscalingScheduledAction_dynamo
--- PASS: TestAccAwsAppautoscalingScheduledAction_dynamo (19.13s)
=== RUN   TestAccAwsAppautoscalingScheduledAction_ECS
--- PASS: TestAccAwsAppautoscalingScheduledAction_ECS (33.14s)
=== RUN   TestAccAwsAppautoscalingScheduledAction_SpotFleet
--- PASS: TestAccAwsAppautoscalingScheduledAction_SpotFleet (50.03s)
=== RUN   TestAccAwsAppautoscalingScheduledAction_EMR
--- PASS: TestAccAwsAppautoscalingScheduledAction_EMR (404.23s)

[tombuildsstuff]

LGTM 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!