r/codebuild_project: Support type for environment_variable #2811

atsushi-ishibashi · 2017-12-31T14:18:35Z

Supported: #1747

acceptance test

nicwise · 2018-02-08T04:51:47Z

website/docs/r/codebuild_project.html.markdown

@@ -134,6 +134,7 @@ The following arguments are supported:
 `environment_variable` supports the following:


Any chance you can add an extra CR at the end of this? the docs don't parse properly otherwise.

This is done and merged BTW

nicwise · 2018-02-08T04:52:35Z

Please Do!

radeksimko

Just one nitpick about validation, but can you also add an acceptance test which involves this argument and (presumably) SSM parameter?

radeksimko · 2018-02-08T15:39:11Z

aws/resource_aws_codebuild_project.go

+											}
+											errors = append(errors, fmt.Errorf("expected %s to be one of %v, got %s", k, validType, value))
+											return
+										},


Nitpick: Do you mind replacing this with a standard helper we have in the upstream library and constants from the SDK? i.e.

ValidateFunc: validation.StringInSlice([]string{ codebuild.EnvironmentVariableTypeParameterStore, codebuild.EnvironmentVariableTypePlaintext, }, true),

nicwise · 2018-02-10T23:27:33Z

@radeksimko Any chance this can go into the next release? (and thank you @atsushi-ishibashi !)

@atsushi-ishibashi

Also includes @atsushi-ishibashi fix from hashicorp#2811

nicwise · 2018-02-10T23:40:37Z

(incase @atsushi-ishibashi doesn't have time to fix the doc thing, I did a PR with just that in, and his change: #3323 )

bflad · 2018-02-12T00:23:05Z

environmentVariablesToMap will likely also need an update so the new optional attribute properly gets read (the missing acceptance test would've caught this):

if env.Type != nil {
  item["type"] = *env.Type
}

@atsushi-ishibashi

* add in new line so it parses properly Also includes @atsushi-ishibashi fix from #2811 * remove the type, which can be added back later

@atsushi-ishibashi

* add in new line so it parses properly Also includes @atsushi-ishibashi fix from #2811 * remove the type, which can be added back later

atsushi-ishibashi · 2018-02-23T16:08:19Z

TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_basic -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (96.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.810s

nicwise · 2018-02-28T01:43:53Z

@bflad / @catsby - looks like @atsushi-ishibashi has added the environmentVariablesToMap thing - is this one good to go? ;-)

bflad · 2018-02-28T02:34:28Z

For the acceptance testing, we'd normally expect a _basic test to not include an optional attribute (duplicating the entire test and config is fine) and for the test including a new attribute to at least check the attribute value in the Terraform state via resource.TestCheckResourceAttr(resourceName, "attribute", "expectedValue").

If you don't have time to submit these fixes, please let us know and we can finish them up. 👍

larsjarek · 2018-03-27T08:33:08Z

Hey guys, is there a chance that this feature can go into the next release? I would really appreciate it as it is needed for my AWS CodeBuild configuration. If @atsushi-ishibashi does not have time I might fix these tests in another PR.

larsjarek · 2018-04-03T14:10:08Z

I made a PR with fix for tests. Currently this PR is marked as WIP because I have to resolve some conflicts.

kathgironpe · 2018-04-03T23:07:23Z

@larsjarek Hey thanks for this. Looking forward to that getting merged.

atsushi-ishibashi · 2018-04-04T06:36:47Z

Sorry for replying late. I have no time to update so I'm glad if anyone take this PR over:bow:

larsjarek · 2018-04-04T08:57:28Z

No problem @atsushi-ishibashi, thanks for your contribution up to this point. All conflicts in my PR (#4021) are now resolved, it can be reviewed now.

bnightstar · 2018-05-16T07:30:53Z

when this will be merged I need this for a project I'm working on ?

larsjarek · 2018-05-24T13:30:57Z

It does not seem that this feature will be merged soon.

bflad · 2018-05-24T14:26:38Z

The later #4021 (containing this PR) is actively being reviewed this week.

edit: #3929

bflad · 2018-05-24T18:30:27Z

After looking through the various duplicate pull requests, I'm going to try to get the commits merged in the following order here (resolving the merge conflicts and test changes along the way, which could be tedious): #2811 -> #4021 -> #3929. 🤞

In the end the following new arguments will be supported:

environment > environment_variable > type
source > git_clone_depth
source > insecure_ssl

bflad · 2018-05-24T21:17:39Z

After merging together the above pull requests and refactoring the test suite, we should be good to go:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (31.87s)
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (30.05s)
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (38.35s)
=== RUN   TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_Cache (59.77s)
=== RUN   TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Description (38.08s)
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (53.94s)
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (30.31s)
=== RUN   TestAccAWSCodeBuildProject_Source_Auth
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (20.33s)
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (38.51s)
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (37.43s)
=== RUN   TestAccAWSCodeBuildProject_Tags
--- PASS: TestAccAWSCodeBuildProject_Tags (28.91s)
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (57.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	465.209s

This will release with v1.21.0 of the AWS provider, likely middle of next week.

larsjarek · 2018-05-28T10:07:32Z

@bflad Thanks a lot for merging this.

bflad · 2018-05-31T04:05:09Z

This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-05T17:46:31Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Support type for environment_variable

b98ad62

radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 2, 2018

bflad added the service/codebuild Issues and PRs that pertain to the codebuild service. label Jan 28, 2018

nicwise reviewed Feb 8, 2018

View reviewed changes

radeksimko reviewed Feb 8, 2018

View reviewed changes

radeksimko added the waiting-response Maintainers are waiting on response from community or contributor. label Feb 8, 2018

update

fef5eff

ghost added the size/S Managed by automation to categorize the size of a PR. label Feb 10, 2018

nicwise added a commit to nicwise/terraform-provider-aws that referenced this pull request Feb 10, 2018

add in new line so it parses properly

b35b3c1

Also includes @atsushi-ishibashi fix from hashicorp#2811

nicwise mentioned this pull request Feb 10, 2018

Fix docs for codebuild, so the markdown parses properly #3323

Merged

catsby pushed a commit that referenced this pull request Feb 13, 2018

Fix docs for codebuild, so the markdown parses properly (#3323)

fa0c754

* add in new line so it parses properly Also includes @atsushi-ishibashi fix from #2811 * remove the type, which can be added back later

catsby pushed a commit that referenced this pull request Feb 13, 2018

Fix docs for codebuild, so the markdown parses properly (#3323)

5d154c8

* add in new line so it parses properly Also includes @atsushi-ishibashi fix from #2811 * remove the type, which can be added back later

Add acctest

7999b0c

ghost added the size/S Managed by automation to categorize the size of a PR. label Feb 23, 2018

larsjarek mentioned this pull request Apr 3, 2018

r/codebuild_project: Support type for environment_variable #4021

Merged

bflad mentioned this pull request May 24, 2018

Support additional CodeBuild settings, retry for IAM errors #3929

Merged

bflad added this to the v1.21.0 milestone May 24, 2018

bflad merged commit 7999b0c into hashicorp:master May 24, 2018

bflad added a commit that referenced this pull request May 24, 2018

Update CHANGELOG for #2811, #4021, and #3929

88c73a7

ghost locked and limited conversation to collaborators Apr 5, 2020

breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/codebuild_project: Support type for environment_variable #2811

r/codebuild_project: Support type for environment_variable #2811

atsushi-ishibashi commented Dec 31, 2017 •

edited

Loading

nicwise Feb 8, 2018

nicwise Feb 28, 2018

nicwise commented Feb 8, 2018 •

edited

Loading

radeksimko left a comment

radeksimko Feb 8, 2018

nicwise commented Feb 10, 2018

nicwise commented Feb 10, 2018

bflad commented Feb 12, 2018

atsushi-ishibashi commented Feb 23, 2018

nicwise commented Feb 28, 2018

bflad commented Feb 28, 2018

larsjarek commented Mar 27, 2018

larsjarek commented Apr 3, 2018

kathgironpe commented Apr 3, 2018

atsushi-ishibashi commented Apr 4, 2018

larsjarek commented Apr 4, 2018

bnightstar commented May 16, 2018

larsjarek commented May 24, 2018

bflad commented May 24, 2018 •

edited

Loading

bflad commented May 24, 2018

bflad commented May 24, 2018

larsjarek commented May 28, 2018 •

edited

Loading

bflad commented May 31, 2018

ghost commented Apr 5, 2020

		@@ -134,6 +134,7 @@ The following arguments are supported:
		`environment_variable` supports the following:

r/codebuild_project: Support type for environment_variable #2811

r/codebuild_project: Support type for environment_variable #2811

Conversation

atsushi-ishibashi commented Dec 31, 2017 • edited Loading

nicwise Feb 8, 2018

Choose a reason for hiding this comment

nicwise Feb 28, 2018

Choose a reason for hiding this comment

nicwise commented Feb 8, 2018 • edited Loading

radeksimko left a comment

Choose a reason for hiding this comment

radeksimko Feb 8, 2018

Choose a reason for hiding this comment

nicwise commented Feb 10, 2018

nicwise commented Feb 10, 2018

bflad commented Feb 12, 2018

atsushi-ishibashi commented Feb 23, 2018

nicwise commented Feb 28, 2018

bflad commented Feb 28, 2018

larsjarek commented Mar 27, 2018

larsjarek commented Apr 3, 2018

kathgironpe commented Apr 3, 2018

atsushi-ishibashi commented Apr 4, 2018

larsjarek commented Apr 4, 2018

bnightstar commented May 16, 2018

larsjarek commented May 24, 2018

bflad commented May 24, 2018 • edited Loading

bflad commented May 24, 2018

bflad commented May 24, 2018

larsjarek commented May 28, 2018 • edited Loading

bflad commented May 31, 2018

ghost commented Apr 5, 2020

atsushi-ishibashi commented Dec 31, 2017 •

edited

Loading

nicwise commented Feb 8, 2018 •

edited

Loading

bflad commented May 24, 2018 •

edited

Loading

larsjarek commented May 28, 2018 •

edited

Loading