Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "Data Source" header to data source resource (continuing #2422) #2713

Merged
merged 6 commits into from
Jan 3, 2018
Merged

Adding "Data Source" header to data source resource (continuing #2422) #2713

merged 6 commits into from
Jan 3, 2018

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Dec 19, 2017

I pulled #2422, merged master, and fixed the merge conflicts.

Allison Ravenhall and others added 3 commits November 24, 2017 11:36
Add "Data Source:" to main heading of data source resources (issue #18)
8efb8de
Updated gitignore.
84a1e38
@catsby
Merge branch 'master' into pr-2422
01ca386 
* master: (147 commits)
  Cleaned Data Sources
  Update CHANGELOG.md
  resource/cognito_user_pool: Update Cognito email message length to 20,000 (#2692)
  Update ecs_service.html.markdown (#2694)
  Documentation: r/ecs_task_definition note about quote escaping container_definition (#2162)
  Cleanup after v1.6.0 release
  v1.6.0
  Make depends_on consistent with note (#2526)
  removing duplicate
  Update CHANGELOG.md
  r/aws_ssm_parameter: Fix arn attribute for full path names and improve testing
  Update CHANGELOG.md
  Update CHANGELOG.md
  s3: Add validation for SSE Algorithm and correct spelling
  #2217: fixed when encryption is AES256
  #2217: documentation
  #2217: re-enable default encryption after disabling in via UI
  #2217: wrote additional acceptance test
  #2217: wrote typical acceptance test
  #2217: make fmt
  ...
@catsby catsby mentioned this pull request Dec 19, 2017
Closed
Ninir
Ninir approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @catsby

Just left a comment regarding antislashes that should be remove, otherwise, 🚀 !

website/docs/d/acm_certificate.html.markdown Outdated
@@ -6,7 +6,7 @@ description: |-
Get information on a Amazon Certificate Manager (ACM) Certificate
---

# aws_acm_certificate
# Data Source: aws\_acm\_certificate
Copy link
Contributor

@Ninir Ninir Dec 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove all of the antislashes? An effort was made recently to clean them all so that we don't have to worry about them anymore! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psyduckmini

@catsby
Copy link
Contributor Author

catsby commented Dec 19, 2017

Going to leave this for the night and merge/deploy in the morning

@jen20
Copy link
Contributor

jen20 commented Dec 19, 2017

👍 Constant source of confusion when reading the docs!

@jen20 jen20 added the documentation Introduces or discusses updates to documentation. label Dec 19, 2017
@tombuildsstuff tombuildsstuff mentioned this pull request Dec 20, 2017
Merged
robinjoseph08
robinjoseph08 reviewed Jan 3, 2018
View reviewed changes
website/docs/d/db_instance.html.markdown Outdated
@@ -6,7 +6,7 @@ description: |-
Get information on an RDS Database Instance.
---

# aws_db_instance
# Data Source: aws_dbinstance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was intentional, but it looks like some underscores were removed from a lot of these headers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh that was not intentional

@catsby
Copy link
Contributor Author

catsby commented Jan 3, 2018

@robinjoseph08 thanks for catching those, I fixed them

@catsby catsby merged commit e3e5b37 into master Jan 3, 2018
@catsby catsby deleted the pr-2422 branch January 3, 2018 21:31
catsby added a commit that referenced this pull request Jan 3, 2018
@catsby
Adding "Data Source" header to data source resource (continuing #2422) (
8b50e29 
#2713)

* Add "Data Source:" to main heading of data source resources (issue #18)
@diroussel diroussel mentioned this pull request Aug 30, 2018
Closed
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robinjoseph08 robinjoseph08 robinjoseph08 left review comments

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catsby @jen20 @Ninir @robinjoseph08