Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kendra_thesaurus - New attribute thesaurus_id #25524

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #25199

thesaurus_id attribute is used with index_id in the aws_kendra_thesaurus data source. Tagging @anGie44 for visibility. Thanks Angie!

Commented out other tests locally to just run the basic test.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendra_serial/Thesaurus' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Thesaurus -timeout 180m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Thesaurus
=== RUN   TestAccKendra_serial/Thesaurus/basic
=== PAUSE TestAccKendra_serial/Thesaurus/basic
=== CONT  TestAccKendra_serial/Thesaurus/basic
--- PASS: TestAccKendra_serial (2479.43s)
    --- PASS: TestAccKendra_serial/Thesaurus (0.00s)
        --- PASS: TestAccKendra_serial/Thesaurus/basic (2479.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     2479.494s

...

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 22, 2022
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 22, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @GlennChia 🚀

@anGie44 anGie44 merged commit a823f3d into hashicorp:main Jun 22, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 22, 2022
@GlennChia GlennChia deleted the f-aws_kendra_thesaurus-thesaurus_id branch June 23, 2022 00:47
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/kendra Issues and PRs that pertain to the kendra service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants