Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] resiliencehub: Add service, skeleton files of app and resiliency_policy #25123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] resiliencehub: Add service, skeleton files of app and resiliency_policy #25123

wants to merge 2 commits into from
+404 −0

Conversation

YarivLevy81
Copy link

@YarivLevy81 YarivLevy81 commented Jun 1, 2022 •
edited by justinretzolk
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #35803

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jun 1, 2022
github-actions[bot]
github-actions bot reviewed Jun 1, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @YarivLevy81 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added generators Relates to code generators. tags Pertains to resource tagging. size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 6, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 23, 2022
@ewbankkit ewbankkit added the partner Contribution from a partner. label Jul 23, 2023
@FrancisRalph FrancisRalph mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
generators Relates to code generators. new-resource Introduces a new resource. new-service Introduces a new service. partner Contribution from a partner. service/resiliencehub Issues and PRs that pertain to the resiliencehub service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Service]: Resilience Hub
3 participants
@YarivLevy81 @ewbankkit @justinretzolk