Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/gamelift_alias: updates to pass semgrep rule prefer-aws-go-sdk-pointer-conversion-assignment #24516

Merged
merged 1 commit into from
May 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 3, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12992

Areas to fix:

semgrep
Scanning 2346 files with 30 go rules.
  100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|2346/2346 tasks

Findings:

  internal/service/gamelift/alias.go
     prefer-aws-go-sdk-pointer-conversion-assignment
        Prefer AWS Go SDK pointer conversion functions for dereferencing during assignment, e.g.
        aws.StringValue()

        210┆ m["fleet_id"] = *rs.FleetId
          ⋮┆----------------------------------------
        213┆ m["message"] = *rs.Message
          ⋮┆----------------------------------------
        215┆ m["type"] = *rs.Type

Output from acceptance testing:

N/A

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. service/gamelift Issues and PRs that pertain to the gamelift service. size/XS Managed by automation to categorize the size of a PR. labels May 3, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v4.13.0 milestone May 3, 2022
@anGie44 anGie44 force-pushed the gamelift-semgrep-exclusions branch from ad312de to a15e506 Compare May 3, 2022 14:13
@anGie44 anGie44 merged commit 414743e into main May 3, 2022
@anGie44 anGie44 deleted the gamelift-semgrep-exclusions branch May 3, 2022 14:14
@github-actions
Copy link

github-actions bot commented May 5, 2022

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. service/gamelift Issues and PRs that pertain to the gamelift service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants