Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_imagebuilder_container_recipe - new data source #23040

Merged

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Feb 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

It depends on #22965. It would be perfect to merge that PR first.

Relates #16839.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccImageBuilderContainerRecipeDataSource_arn" PKG_NAME=internal/service/imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderContainerRecipeDataSource_arn -timeout 180m
=== RUN   TestAccImageBuilderContainerRecipeDataSource_arn
=== PAUSE TestAccImageBuilderContainerRecipeDataSource_arn
=== CONT  TestAccImageBuilderContainerRecipeDataSource_arn
--- PASS: TestAccImageBuilderContainerRecipeDataSource_arn (42.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       44.127s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Feb 8, 2022
@kamilturek kamilturek marked this pull request as ready for review February 10, 2022 21:40
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccImageBuilderContainerRecipeDataSource_ PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderContainerRecipeDataSource_'  -timeout 180m
=== RUN   TestAccImageBuilderContainerRecipeDataSource_arn
=== PAUSE TestAccImageBuilderContainerRecipeDataSource_arn
=== CONT  TestAccImageBuilderContainerRecipeDataSource_arn
--- PASS: TestAccImageBuilderContainerRecipeDataSource_arn (33.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	40.282s
GovCloud
% make testacc TESTS=TestAccImageBuilderContainerRecipeDataSource_ PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run='TestAccImageBuilderContainerRecipeDataSource_'  -timeout 180m
=== RUN   TestAccImageBuilderContainerRecipeDataSource_arn
=== PAUSE TestAccImageBuilderContainerRecipeDataSource_arn
=== CONT  TestAccImageBuilderContainerRecipeDataSource_arn
--- PASS: TestAccImageBuilderContainerRecipeDataSource_arn (35.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	42.861s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d7da73b into hashicorp:main Feb 11, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 11, 2022
@kamilturek kamilturek deleted the f-data-aws-imagebuilder-container-recipe branch February 11, 2022 16:55
@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants