New resource for Detective Member and Invitation Accepter

[coderGo93]

Added a new resource, doc and tests for Detective Member called aws_detective_member and Detective Invitation Accepter called aws_detective_invitation_accepter

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11672

Output from acceptance testing:

Detective Member

$  make testacc TESTARGS='-run=TestAccDetective_serial' PKG_NAME=internal/service/detective
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/detective/... -v -count 1 -parallel 20 -run=TestAccDetective_serial -timeout 180m
=== RUN   TestAccDetective_serial
=== RUN   TestAccDetective_serial/InvitationAccepter
=== RUN   TestAccDetective_serial/InvitationAccepter/basic
=== RUN   TestAccDetective_serial/Member
=== RUN   TestAccDetective_serial/Member/invitationMessage
=== RUN   TestAccDetective_serial/Member/basic
=== RUN   TestAccDetective_serial/Member/disappear
=== RUN   TestAccDetective_serial/Graph
=== RUN   TestAccDetective_serial/Graph/tags
=== RUN   TestAccDetective_serial/Graph/basic
=== RUN   TestAccDetective_serial/Graph/disappears
--- PASS: TestAccDetective_serial (219.08s)
    --- PASS: TestAccDetective_serial/InvitationAccepter (33.86s)
        --- PASS: TestAccDetective_serial/InvitationAccepter/basic (33.86s)
    --- PASS: TestAccDetective_serial/Member (98.99s)
        --- PASS: TestAccDetective_serial/Member/invitationMessage (45.33s)
        --- PASS: TestAccDetective_serial/Member/basic (28.79s)
        --- PASS: TestAccDetective_serial/Member/disappear (24.87s)
    --- PASS: TestAccDetective_serial/Graph (86.23s)
        --- PASS: TestAccDetective_serial/Graph/tags (50.77s)
        --- PASS: TestAccDetective_serial/Graph/basic (20.61s)
        --- PASS: TestAccDetective_serial/Graph/disappears (14.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  221.339s

[zhelding]

Thanks for this next set of Detective resources @coderGo93! I've gone ahead and made a number of comments + suggestions -- mostly small in scope.

However, we do require one larger change: namely, the acceptance tests here need to be converted to run serially and not concurrently -- due to the AWS restriction of one graph per account per region. You've gotten around that restriction so far by running one test at a time, but for robustness we really want that restriction built in to the tests.

Luckily, converting tests to be run serially is pretty straightforward: just follow this short guide on acceptance test concurrency to rearrange your test functions.

Related: this means we only need one set of environmental variables instead of two!

Looking forward to your further contributions and getting this merged!

[zhelding]

Hi @coderGo93! I've just pushed a number of small final changes and confirmed that we're clearing acceptance tests (see below).

It's rather late here -- so I'm going to call it a night for now; will look at with fresh eyes in the morning and hopefully merge then!

Thanks so much for your patience.

❯ make testacc PKG=detective
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/detective/... -v -count 1 -parallel 20  -timeout 180m
=== RUN   TestAccDetective_serial
=== RUN   TestAccDetective_serial/Graph
=== RUN   TestAccDetective_serial/Graph/basic
=== RUN   TestAccDetective_serial/Graph/disappears
=== RUN   TestAccDetective_serial/Graph/tags
=== RUN   TestAccDetective_serial/InvitationAccepter
=== RUN   TestAccDetective_serial/InvitationAccepter/basic
=== RUN   TestAccDetective_serial/Member
=== RUN   TestAccDetective_serial/Member/basic
=== RUN   TestAccDetective_serial/Member/disappear
=== RUN   TestAccDetective_serial/Member/message
--- PASS: TestAccDetective_serial (139.71s)
    --- PASS: TestAccDetective_serial/Graph (57.22s)
        --- PASS: TestAccDetective_serial/Graph/basic (14.37s)
        --- PASS: TestAccDetective_serial/Graph/disappears (9.66s)
        --- PASS: TestAccDetective_serial/Graph/tags (33.20s)
    --- PASS: TestAccDetective_serial/InvitationAccepter (20.29s)
        --- PASS: TestAccDetective_serial/InvitationAccepter/basic (20.29s)
    --- PASS: TestAccDetective_serial/Member (62.20s)
        --- PASS: TestAccDetective_serial/Member/basic (17.94s)
        --- PASS: TestAccDetective_serial/Member/disappear (15.64s)
        --- PASS: TestAccDetective_serial/Member/message (28.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  139.754s

[github-actions]

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.