Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/emr_studio_session_mapping - new resource #22140

Merged
merged 10 commits into from
Dec 9, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccEMRStudioSessionMapping_ PKG=emr
--- PASS: TestAccEMRStudioSessionMapping_disappears (95.15s)
--- PASS: TestAccEMRStudioSessionMapping_basic (163.24s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 9, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Dec 9, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review December 9, 2021 19:54
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Dec 9, 2021
@DrFaust92 DrFaust92 force-pushed the r/emr_studio_session_mapping branch from 70f9e0f to aa11a11 Compare December 9, 2021 20:12
@github-actions github-actions bot removed the sweeper Pertains to changes to or issues with the sweeper. label Dec 9, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_IDENTITY_STORE_USER_ID=... make testacc TESTS=TestAccEMRStudioSessionMapping_ PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRStudioSessionMapping_' -timeout 180m
=== RUN   TestAccEMRStudioSessionMapping_basic
=== PAUSE TestAccEMRStudioSessionMapping_basic
=== RUN   TestAccEMRStudioSessionMapping_disappears
=== PAUSE TestAccEMRStudioSessionMapping_disappears
=== CONT  TestAccEMRStudioSessionMapping_basic
=== CONT  TestAccEMRStudioSessionMapping_disappears
--- PASS: TestAccEMRStudioSessionMapping_disappears (49.77s)
--- PASS: TestAccEMRStudioSessionMapping_basic (81.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	87.007s

@ewbankkit ewbankkit merged commit 9b6edeb into hashicorp:main Dec 9, 2021
@github-actions github-actions bot added this to the v3.69.0 milestone Dec 9, 2021
@DrFaust92 DrFaust92 deleted the r/emr_studio_session_mapping branch December 9, 2021 20:50
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants