Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kms: Preserve order in JSON/policies #21990

Merged
merged 7 commits into from
Dec 1, 2021
Merged

kms: Preserve order in JSON/policies #21990

merged 7 commits into from
Dec 1, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 1, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Related #21968
Related #11801

Output from acceptance testing (us-west-2):

--- PASS: TestAccKMSKey_disappears (22.36s)
--- PASS: TestAccKMSKey_asymmetricKey (25.84s)
--- PASS: TestAccKMSKeyDataSource_basic (26.49s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfiguration (26.50s)
--- PASS: TestAccKMSKey_multiRegion (29.92s)
--- PASS: TestAccKMSKey_basic (30.33s)
--- PASS: TestAccKMSKeyDataSource_grantToken (38.75s)
--- PASS: TestAccKMSKey_Policy_iamRole (47.49s)
--- PASS: TestAccKMSKey_Policy_bypassUpdate (49.04s)
--- PASS: TestAccKMSKey_Policy_basic (50.93s)
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (57.05s)
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (70.88s)
--- PASS: TestAccKMSKey_tags (83.79s)
--- PASS: TestAccKMSKey_Policy_bypass (154.77s)
--- PASS: TestAccKMSKey_isEnabled (186.60s)

--- PASS: TestAccKMSReplicaExternalKey_basic (34.44s)
--- PASS: TestAccKMSReplicaExternalKey_descriptionAndEnabled (337.51s)
--- PASS: TestAccKMSReplicaExternalKey_policy (89.17s)
--- PASS: TestAccKMSReplicaExternalKey_tags (125.77s)

--- PASS: TestAccKMSReplicaKey_basic (27.41s)
--- PASS: TestAccKMSReplicaKey_descriptionAndEnabled (298.29s)
--- PASS: TestAccKMSReplicaKey_disappears (22.22s)
--- PASS: TestAccKMSReplicaKey_policy (60.66s)
--- PASS: TestAccKMSReplicaKey_policy (66.72s)
--- PASS: TestAccKMSReplicaKey_twoReplicas (27.48s)
--- PASS: TestAccKMSReplicaKey_tags (80.34s)
        
--- PASS: TestAccKMSExternalKey_tags (66.33s)
--- PASS: TestAccKMSExternalKey_basic (20.11s)
--- PASS: TestAccKMSExternalKey_deletionWindowInDays (30.81s)
--- PASS: TestAccKMSExternalKey_description (40.99s)
--- PASS: TestAccKMSExternalKey_disappears (14.24s)
--- PASS: TestAccKMSExternalKey_enabled (326.92s)
--- PASS: TestAccKMSExternalKey_keyMaterialBase64 (159.17s)
--- PASS: TestAccKMSExternalKey_multiRegion (20.11s)
--- PASS: TestAccKMSExternalKey_policy (67.50s)
--- PASS: TestAccKMSExternalKey_policyBypass (25.35s)
--- PASS: TestAccKMSExternalKey_validTo (278.04s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccKMSKey_asymmetricKey (23.02s)
--- PASS: TestAccKMSKey_basic (26.67s)
--- PASS: TestAccKMSKey_disappears (18.84s)
--- PASS: TestAccKMSKey_isEnabled (241.36s)
--- PASS: TestAccKMSKey_multiRegion (26.68s)
--- PASS: TestAccKMSKey_Policy_basic (44.11s)
--- PASS: TestAccKMSKey_Policy_bypass (157.17s)
--- PASS: TestAccKMSKey_Policy_bypassUpdate (54.67s)
--- PASS: TestAccKMSKey_Policy_iamRole (43.45s)
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (75.29s)
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (51.41s)
--- PASS: TestAccKMSKey_tags (166.89s)
--- PASS: TestAccKMSKeyDataSource_basic (23.31s)
--- PASS: TestAccKMSKeyDataSource_grantToken (30.28s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfiguration (23.32s)

--- PASS: TestAccKMSExternalKey_basic (30.26s)
--- PASS: TestAccKMSExternalKey_deletionWindowInDays (45.43s)
--- PASS: TestAccKMSExternalKey_description (143.56s)
--- PASS: TestAccKMSExternalKey_disappears (22.44s)
--- PASS: TestAccKMSExternalKey_enabled (397.31s)
--- PASS: TestAccKMSExternalKey_keyMaterialBase64 (264.83s)
--- PASS: TestAccKMSExternalKey_multiRegion (30.26s)
--- PASS: TestAccKMSExternalKey_policy (151.64s)
--- PASS: TestAccKMSExternalKey_policyBypass (37.74s)
--- PASS: TestAccKMSExternalKey_tags (179.36s)
--- PASS: TestAccKMSExternalKey_validTo (535.28s)

--- PASS: TestAccKMSReplicaExternalKey_policy (148.40s)
--- PASS: TestAccKMSReplicaExternalKey_tags (203.67s)
--- PASS: TestAccKMSReplicaExternalKey_basic (45.19s)
--- PASS: TestAccKMSReplicaExternalKey_descriptionAndEnabled (456.70s)

--- PASS: TestAccKMSReplicaKey_descriptionAndEnabled (515.06s)
--- PASS: TestAccKMSReplicaKey_tags (204.07s)
--- PASS: TestAccKMSReplicaKey_basic (37.78s)
--- PASS: TestAccKMSReplicaKey_disappears (65.48s)
--- PASS: TestAccKMSReplicaKey_policy (142.36s)
--- SKIP: TestAccKMSReplicaKey_twoReplicas (1.42s)

@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kms Issues and PRs that pertain to the kms service. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Dec 1, 2021
@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Dec 1, 2021
@YakDriver YakDriver merged commit 5d7b117 into main Dec 1, 2021
@YakDriver YakDriver deleted the b-preserve-order-kms branch December 1, 2021 19:36
@github-actions github-actions bot added this to the v3.68.0 milestone Dec 1, 2021
github-actions bot pushed a commit that referenced this pull request Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kms Issues and PRs that pertain to the kms service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant