Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting: Restores Semgrep checks #21440

Merged
merged 2 commits into from
Nov 9, 2021
Merged

linting: Restores Semgrep checks #21440

merged 2 commits into from
Nov 9, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 22, 2021

With the code reorganization for Service Packages, Semgrep checks were no longer able to run. This PR restores them.

Relates #20000

Acceptance test results

$ $ make testacc TESTARGS='-run=TestAccEC2NetworkInterface\|TestAccGlueMlTransform\|TestAccElasticSearchDomainSamlOptions\|TestAccIAMOpenidConnectProvider\|TestAccPrometheusWorkspace\|TestAccELBLoadBalancer\|TestAccEC2NetworkInterfaceSgAttachment\|TestAccBackupVaultNotification\|TestAccCognitoIDPUserPoolUICustomization\|TestAccWorkLinkWebsiteCertificateAuthorityAssociation'

--- PASS: TestAccBackupVaultNotification_disappears (18.83s)
--- PASS: TestAccBackupVaultNotification_basic (21.32s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_Client_disappears (44.29s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_disappears (47.44s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_UpdateAllToClient_cSS (83.34s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_UpdateClientToAll_cSS (83.53s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_CSS (84.17s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_Client_image (85.03s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_imageFile (87.26s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_Client_CSS (87.29s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_ClientAndAll_cSS (90.93s)
--- PASS: TestAccCognitoIDPUserPoolUICustomization_AllClients_CSSAndImageFile (98.33s)
--- SKIP: TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation (0.94s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_filters (50.69s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_basic (63.42s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_publicIPAssociation (64.63s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_disappears (72.22s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_basic (77.04s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_multiple (81.92s)
--- PASS: TestAccEC2NetworkInterface_disappears (100.90s)
--- PASS: TestAccEC2NetworkInterface_ENIInterfaceType_efa (118.41s)
--- PASS: TestAccEC2NetworkInterface_basic (119.29s)
--- PASS: TestAccEC2NetworkInterfaceSgAttachment_instance (139.42s)
--- PASS: TestAccEC2NetworkInterfacesDataSource_filter (70.55s)
--- PASS: TestAccEC2NetworkInterfacesDataSource_tags (69.81s)
--- PASS: TestAccEC2NetworkInterface_description (148.25s)
--- PASS: TestAccEC2NetworkInterface_tags (188.17s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv4Prefix (188.65s)
--- PASS: TestAccEC2NetworkInterface_ipv6 (191.59s)
--- PASS: TestAccEC2NetworkInterface_sourceDestCheck (193.47s)
--- PASS: TestAccEC2NetworkInterface_ipv6Count (208.02s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv6Prefix (147.26s)
--- PASS: TestAccEC2NetworkInterface_privateIPsCount (219.52s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv4PrefixCount (170.85s)
--- PASS: TestAccEC2NetworkInterface_ENI_ipv6PrefixCount (160.43s)
--- PASS: TestAccEC2NetworkInterfaceAttachment_basic (343.44s)
--- PASS: TestAccEC2NetworkInterface_attachment (363.96s)
--- PASS: TestAccEC2NetworkInterface_ignoreExternalAttachment (374.54s)
--- PASS: TestAccELBLoadBalancer_fullCharacterRange (45.14s)
--- PASS: TestAccELBLoadBalancer_timeout (106.01s)
--- PASS: TestAccELBLoadBalancer_generatedName (111.12s)
--- PASS: TestAccELBLoadBalancer_generatesNameForZeroValue (125.10s)
--- PASS: TestAccELBLoadBalancer_connectionDraining (133.26s)
--- PASS: TestAccELBLoadBalancer_namePrefix (134.51s)
--- PASS: TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate (153.75s)
--- PASS: TestAccELBLoadBalancer_availabilityZones (157.22s)
--- PASS: TestAccELBLoadBalancer_Swap_subnets (174.70s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (189.60s)
--- PASS: TestAccELBLoadBalancer_instanceAttaching (192.48s)
--- PASS: TestAccELBLoadBalancer_listener (217.54s)
--- PASS: TestAccELBLoadBalancer_disappears (242.52s)
--- PASS: TestAccELBLoadBalancerDataSource_basic (246.41s)
--- PASS: TestAccELBLoadBalancer_healthCheck (256.21s)
--- PASS: TestAccELBLoadBalancer_basic (259.32s)
--- PASS: TestAccELBLoadBalancer_tags (300.51s)
--- PASS: TestAccGlueMlTransform_disappears (65.67s)
--- PASS: TestAccELBLoadBalancer_securityGroups (316.97s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (326.06s)
--- PASS: TestAccGlueMlTransform_basic (81.27s)
--- PASS: TestAccGlueMlTransform_workerType (125.59s)
--- PASS: TestAccGlueMlTransform_description (131.89s)
--- PASS: TestAccGlueMlTransform_maxCapacity (134.53s)
--- PASS: TestAccGlueMlTransform_glueVersion (136.09s)
--- PASS: TestAccGlueMlTransform_maxRetries (141.85s)
--- PASS: TestAccGlueMlTransform_timeout (142.16s)
--- PASS: TestAccGlueMlTransform_typeFindMatchesFull (174.43s)
--- PASS: TestAccGlueMlTransform_tags (182.77s)
--- PASS: TestAccIAMOpenidConnectProvider_disappears (19.08s)
--- PASS: TestAccIAMOpenidConnectProvider_basic (36.84s)
--- PASS: TestAccIAMOpenidConnectProvider_tags (49.85s)
--- PASS: TestAccPrometheusWorkspace_disappears (16.42s)
--- PASS: TestAccPrometheusWorkspace_basic (43.65s)
--- PASS: TestAccElasticSearchDomainSamlOptions_disappears (1180.06s)
--- PASS: TestAccElasticSearchDomainSamlOptions_basic (1212.03s)
--- PASS: TestAccElasticSearchDomainSamlOptions_disabled (1257.03s)
--- PASS: TestAccElasticSearchDomainSamlOptions_update (1448.94s)
--- PASS: TestAccElasticSearchDomainSamlOptions_disappears_domain (1500.37s)
--- PASS: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_disappears (91.05s)
--- PASS: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_basic (96.35s)
--- PASS: TestAccWorkLinkWebsiteCertificateAuthorityAssociation_displayName (110.93s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/cognitoidentityprovider service/datapipeline Issues and PRs that pertain to the datapipeline service. service/dax Issues and PRs that pertain to the dax service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/dlm Issues and PRs that pertain to the dlm service. service/docdb Issues and PRs that pertain to the docdb service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. labels Oct 22, 2021
@github-actions github-actions bot added generators Relates to code generators. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/efs Issues and PRs that pertain to the efs service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/s3 Issues and PRs that pertain to the s3 service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/transfer Issues and PRs that pertain to the transfer service. size/L Managed by automation to categorize the size of a PR. and removed service/rds Issues and PRs that pertain to the rds service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/ssm Issues and PRs that pertain to the ssm service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/s3 Issues and PRs that pertain to the s3 service. service/opsworks Issues and PRs that pertain to the opsworks service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/s3control Issues and PRs that pertain to the s3control service. service/mq Issues and PRs that pertain to the mq service. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. labels Nov 5, 2021
@ewbankkit ewbankkit self-requested a review November 8, 2021 18:22
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% semgrep --config .semgrep.yml 
METRICS: Using configs from the Registry (like --config=p/ci) reports pseudonymous rule metrics to semgrep.dev.
To disable Registry rule metrics, use "--metrics=off".
Using configs only from local files (like --config=xyz.yml) does not enable metrics.

More information: https://semgrep.dev/docs/metrics

Running 28 rules...
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|28/28
ran 28 rules on 3763 files: 0 findings

@gdavison gdavison merged commit 3d883ab into main Nov 9, 2021
@gdavison gdavison deleted the svgpkg-semgrep branch November 9, 2021 00:01
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 9, 2021
github-actions bot pushed a commit that referenced this pull request Nov 9, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. linter Pertains to changes to or issues with the various linters. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/transfer Issues and PRs that pertain to the transfer service. service/worklink Issues and PRs that pertain to the worklink service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants