-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize AppSync acceptance tests #21400
Conversation
Given that running time is dominated by the 2 Elasticsearch tests, let's leave them as independent, parallel tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As-is LGTM 👍
To leave the elasticsearch-related tests as parallel, do you mean by moving them out of the new serial test's DataSource
testCases?
--- PASS: TestAccAppSync_serial (3751.74s)
--- PASS: TestAccAppSync_serial/Resolver (860.48s)
--- PASS: TestAccAppSync_serial/Resolver/disappears (269.68s)
--- PASS: TestAccAppSync_serial/Resolver/dataSource (312.17s)
--- PASS: TestAccAppSync_serial/Resolver/pipeline (62.27s)
--- PASS: TestAccAppSync_serial/Resolver/caching (18.25s)
--- PASS: TestAccAppSync_serial/Resolver/basic (18.40s)
--- PASS: TestAccAppSync_serial/Resolver/DataSource_lambda (40.77s)
--- PASS: TestAccAppSync_serial/Resolver/requestTemplate (28.97s)
--- PASS: TestAccAppSync_serial/Resolver/responseTemplate (51.52s)
--- PASS: TestAccAppSync_serial/Resolver/multipleResolvers (58.45s)
--- PASS: TestAccAppSync_serial/APIKey (59.87s)
--- PASS: TestAccAppSync_serial/APIKey/basic (14.98s)
--- PASS: TestAccAppSync_serial/APIKey/description (22.49s)
--- PASS: TestAccAppSync_serial/APIKey/expires (22.40s)
--- PASS: TestAccAppSync_serial/DataSource (2208.23s)
--- PASS: TestAccAppSync_serial/DataSource/Type_dynamoDB (23.10s)
--- PASS: TestAccAppSync_serial/DataSource/Type_elasticSearch (1010.54s)
--- PASS: TestAccAppSync_serial/DataSource/Type_lambda (32.11s)
--- PASS: TestAccAppSync_serial/DataSource/Type_none (14.52s)
--- PASS: TestAccAppSync_serial/DataSource/basic (14.46s)
--- PASS: TestAccAppSync_serial/DataSource/DynamoDB_region (42.45s)
--- PASS: TestAccAppSync_serial/DataSource/DynamoDB_useCallerCredentials (38.83s)
--- PASS: TestAccAppSync_serial/DataSource/ElasticSearch_region (949.32s)
--- PASS: TestAccAppSync_serial/DataSource/HTTP_endpoint (24.99s)
--- PASS: TestAccAppSync_serial/DataSource/type (21.09s)
--- PASS: TestAccAppSync_serial/DataSource/Type_http (14.25s)
--- PASS: TestAccAppSync_serial/DataSource/description (22.56s)
--- PASS: TestAccAppSync_serial/GraphQLAPI (497.95s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM (12.74s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/basic (12.44s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/disappears (9.51s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey (12.62s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent (38.12s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect (12.98s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/schema (26.70s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM (12.24s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer (23.19s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools (17.96s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/tags (22.18s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey (14.54s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple (17.70s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/xrayEnabled (19.60s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/authenticationType (22.55s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/log (16.98s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL (21.34s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/name (21.78s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL (22.04s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion (25.43s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction (28.44s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools (15.42s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect (16.98s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel (33.25s)
--- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID (21.24s)
--- PASS: TestAccAppSync_serial/Function (125.20s)
--- PASS: TestAccAppSync_serial/Function/description (38.52s)
--- PASS: TestAccAppSync_serial/Function/responseMappingTemplate (23.84s)
--- PASS: TestAccAppSync_serial/Function/basic (40.22s)
--- PASS: TestAccAppSync_serial/Function/disappears (22.62s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appsync 3757.046s
Yes, forgot to push that commit 😄. |
This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
…ment (#20857) * tests/resource/aws_appsync_graphql_api: Update deprecated Providers to ProviderFactories * resource/aws_appsync_graphql_api: Add `lambda_authorizer_config` argument (#20644) Issue: #20644 API docs: https://docs.aws.amazon.com/appsync/latest/APIReference/API_LambdaAuthorizerConfig.html Output from acceptance testing: ``` make testacc TESTARGS='-run=TestAccAWSAppsyncGraphqlApi_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppsyncGraphqlApi_ -timeout 180m --- PASS: TestAccAWSAppsyncGraphqlApi_basic (147.72s) --- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AWSIAM (148.24s) --- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_APIKey (149.20s) --- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_OpenIDConnect (149.32s) --- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (153.51s) --- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_CognitoUserPools (173.33s) --- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AwsLambda (196.04s) --- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_Multiple (204.38s) --- PASS: TestAccAWSAppsyncGraphqlApi_XrayEnabled (214.18s) --- PASS: TestAccAWSAppsyncGraphqlApi_Name (215.34s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AwsLambda (221.80s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (235.05s) --- PASS: TestAccAWSAppsyncGraphqlApi_Tags (236.82s) --- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (242.45s) --- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_ExcludeVerboseContent (250.77s) --- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (250.94s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (116.05s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (115.22s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (125.39s) --- PASS: TestAccAWSAppsyncGraphqlApi_disappears (65.90s) --- PASS: TestAccAWSAppsyncGraphqlApi_LambdaAuthorizerConfig_IdentityValidationExpression (281.96s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (88.56s) --- PASS: TestAccAWSAppsyncGraphqlApi_LambdaAuthorizerConfig_AuthorizerUri (294.85s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (158.58s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (154.12s) --- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (312.61s) --- PASS: TestAccAWSAppsyncGraphqlApi_Schema (143.80s) --- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (126.84s) --- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (113.13s) --- PASS: TestAccAWSAppsyncGraphqlApi_LambdaAuthorizerConfig_AuthorizerResultTtlInSeconds (356.98s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 359.589s ``` * resource/aws_appsync_graphql_api: Add changelog entry 20857.txt * resource/aws_appsync_graphql_api: Terraform fmt in test config * Revert "tests/resource/aws_appsync_graphql_api: Update deprecated Providers to ProviderFactories" This reverts commit 1f981fc. * tests/resource/aws_appsync_graphql_api: Changes from #20000 and #21400 * graphql_api: Re-order map alphabetically (review comment)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21399
Output from acceptance testing:
Commercial
GovCloud