-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/glue_connection - add tagging support + use finder #21226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_ -timeout 180m
=== RUN TestAccDataSourceAwsGlueConnection_basic
=== PAUSE TestAccDataSourceAwsGlueConnection_basic
=== RUN TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN TestAccAWSGlueConnection_tags
=== PAUSE TestAccAWSGlueConnection_tags
=== RUN TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== RUN TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT TestAccDataSourceAwsGlueConnection_basic
=== CONT TestAccAWSGlueConnection_Description
=== CONT TestAccAWSGlueConnection_disappears
=== CONT TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT TestAccAWSGlueConnection_Kafka
=== CONT TestAccAWSGlueConnection_tags
=== CONT TestAccAWSGlueConnection_MongoDB
=== CONT TestAccAWSGlueConnection_Network
=== CONT TestAccAWSGlueConnection_basic
=== CONT TestAccAWSGlueConnection_MatchCriteria
--- PASS: TestAccAWSGlueConnection_disappears (17.97s)
--- PASS: TestAccDataSourceAwsGlueConnection_basic (23.88s)
--- PASS: TestAccAWSGlueConnection_basic (24.38s)
--- PASS: TestAccAWSGlueConnection_Kafka (24.47s)
--- PASS: TestAccAWSGlueConnection_MongoDB (26.99s)
--- PASS: TestAccAWSGlueConnection_Description (37.49s)
--- PASS: TestAccAWSGlueConnection_Network (40.38s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (49.95s)
--- PASS: TestAccAWSGlueConnection_tags (53.38s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (675.29s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 678.505s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_\|TestAccDataSourceAwsGlueConnection_ -timeout 180m
=== RUN TestAccDataSourceAwsGlueConnection_basic
=== PAUSE TestAccDataSourceAwsGlueConnection_basic
=== RUN TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN TestAccAWSGlueConnection_tags
=== PAUSE TestAccAWSGlueConnection_tags
=== RUN TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== RUN TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT TestAccDataSourceAwsGlueConnection_basic
=== CONT TestAccAWSGlueConnection_Description
=== CONT TestAccAWSGlueConnection_MongoDB
=== CONT TestAccAWSGlueConnection_disappears
=== CONT TestAccAWSGlueConnection_Network
=== CONT TestAccAWSGlueConnection_MatchCriteria
=== CONT TestAccAWSGlueConnection_tags
=== CONT TestAccAWSGlueConnection_Kafka
=== CONT TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT TestAccAWSGlueConnection_basic
--- PASS: TestAccAWSGlueConnection_disappears (21.57s)
--- PASS: TestAccDataSourceAwsGlueConnection_basic (25.59s)
--- PASS: TestAccAWSGlueConnection_MongoDB (25.80s)
--- PASS: TestAccAWSGlueConnection_basic (28.23s)
--- PASS: TestAccAWSGlueConnection_Kafka (28.43s)
--- PASS: TestAccAWSGlueConnection_Network (40.38s)
--- PASS: TestAccAWSGlueConnection_Description (42.15s)
--- PASS: TestAccAWSGlueConnection_tags (56.82s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (57.24s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (658.50s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 664.022s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: