fix: compare version with integers, handle first page logic

[thornleyk]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21045

Output from acceptance testing:

Existing report of ACC test execution fails with the same or worse behaviour before the change

Before

$ make testacc TESTARGS='-run=TestAccAwsLexBot_version_serial/LexBot'                                 21:36:41 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsLexBot_version_serial/LexBot -timeout 180m
=== RUN   TestAccAwsLexBot_version_serial
=== RUN   TestAccAwsLexBot_version_serial/LexBot_createVersion
    resource_aws_lex_bot_test.go:145: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) (len=2) {
         (string) (len=14) "create_version": (string) (len=5) "false",
         (string) (len=16) "process_behavior": (string) (len=4) "SAVE"
        }


        (map[string]string) (len=2) {
         (string) (len=14) "create_version": (string) (len=4) "true",
         (string) (len=16) "process_behavior": (string) (len=5) "BUILD"
        }
=== RUN   TestAccAwsLexBot_version_serial/LexBotAlias_botVersion
    resource_aws_lex_bot_alias_test.go:144: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) (len=1) {
         (string) (len=12) "created_date": (string) (len=20) "2021-09-26T08:38:54Z"
        }


        (map[string]string) (len=1) {
         (string) (len=12) "created_date": (string) (len=20) "2021-09-26T08:39:39Z"
        }
=== RUN   TestAccAwsLexBot_version_serial/DataSourceLexBot_withVersion
=== RUN   TestAccAwsLexBot_version_serial/DataSourceLexBotAlias_basic
--- FAIL: TestAccAwsLexBot_version_serial (265.95s)
    --- FAIL: TestAccAwsLexBot_version_serial/LexBot_createVersion (81.76s)
    --- FAIL: TestAccAwsLexBot_version_serial/LexBotAlias_botVersion (94.93s)
    --- PASS: TestAccAwsLexBot_version_serial/DataSourceLexBot_withVersion (41.07s)
    --- PASS: TestAccAwsLexBot_version_serial/DataSourceLexBotAlias_basic (48.20s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	268.390s
FAIL
make: *** [testacc] Error 1

After change

$ make testacc TESTARGS='-run=TestAccAwsLexBot_version_serial/LexBot'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsLexBot_version_serial/LexBot -timeout 180m
=== RUN   TestAccAwsLexBot_version_serial
=== RUN   TestAccAwsLexBot_version_serial/DataSourceLexBot_withVersion
=== RUN   TestAccAwsLexBot_version_serial/DataSourceLexBotAlias_basic
=== RUN   TestAccAwsLexBot_version_serial/LexBot_createVersion
    resource_aws_lex_bot_test.go:145: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) (len=2) {
         (string) (len=14) "create_version": (string) (len=5) "false",
         (string) (len=16) "process_behavior": (string) (len=4) "SAVE"
        }


        (map[string]string) (len=2) {
         (string) (len=14) "create_version": (string) (len=4) "true",
         (string) (len=16) "process_behavior": (string) (len=5) "BUILD"
        }
=== RUN   TestAccAwsLexBot_version_serial/LexBotAlias_botVersion
--- FAIL: TestAccAwsLexBot_version_serial (268.25s)
    --- PASS: TestAccAwsLexBot_version_serial/DataSourceLexBot_withVersion (47.36s)
    --- PASS: TestAccAwsLexBot_version_serial/DataSourceLexBotAlias_basic (44.47s)
    --- FAIL: TestAccAwsLexBot_version_serial/LexBot_createVersion (77.88s)
    --- PASS: TestAccAwsLexBot_version_serial/LexBotAlias_botVersion (98.55s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	270.733s
FAIL
make: *** [testacc] Error 1

[AdamTylerLynch]

Underlying AccTest issues fixed in #21122

[ewbankkit]

@thornleyk Thanks for the contribution 🎉 👏.
The same fix has been made in #20383 which I am working on merging now. I am going to close this PR.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.