Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_synthetics_canary: Correctly report creation errors #20463

Merged
merged 3 commits into from
Aug 6, 2021

Commits on Aug 6, 2021

  1. r/aws_synthetics_canary: Check error on creation. Addresses:

    Error: error reading Synthetics Canary: InvalidParameter: 1 validation error(s) found.
    - minimum field size of 1, GetCanaryInput.Name.
    
    Acceptance test output:
    
    % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSyntheticsCanary_basic'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSyntheticsCanary_basic -timeout 180m
    === RUN   TestAccAWSSyntheticsCanary_basic
    === PAUSE TestAccAWSSyntheticsCanary_basic
    === CONT  TestAccAWSSyntheticsCanary_basic
        resource_aws_synthetics_canary_test.go:83: Step 1/3 error: Error running apply: exit status 1
    
            Error: error creating Synthetics Canary (tf-acc-test-lhi0ieu0): ValidationException: Deprecated runtime version specified.
    
              with aws_synthetics_canary.test,
              on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
              92: resource "aws_synthetics_canary" "test" {
    
    --- FAIL: TestAccAWSSyntheticsCanary_basic (16.35s)
    FAIL
    FAIL	github.com/terraform-providers/terraform-provider-aws/aws	19.448s
    FAIL
    make: *** [testacc] Error 1
    ewbankkit committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    9f5e12d View commit details
    Browse the repository at this point in the history
  2. r/aws_synthetics_canary: Update acceptance test runtime version.

    Acceptance test output:
    
    % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSyntheticsCanary_basic'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSyntheticsCanary_basic -timeout 180m
    === RUN   TestAccAWSSyntheticsCanary_basic
    === PAUSE TestAccAWSSyntheticsCanary_basic
    === CONT  TestAccAWSSyntheticsCanary_basic
    --- PASS: TestAccAWSSyntheticsCanary_basic (87.73s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	91.049s
    ewbankkit committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    ba70ed6 View commit details
    Browse the repository at this point in the history
  3. Add CHANGELOG entry.

    ewbankkit committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    378c849 View commit details
    Browse the repository at this point in the history