Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional kinesis_settings to dms_endpoint #20084

Merged
merged 11 commits into from
Oct 18, 2021
Merged

Add support for additional kinesis_settings to dms_endpoint #20084

merged 11 commits into from
Oct 18, 2021

Commits on Oct 17, 2021

  1. include additional kinesis-settings 

    added the following settings:
IncludeTransactionDetails
IncludePartitionValue
PartitionIncludeSchemaTable
IncludeTableAlterOperations
IncludeControlDetails
IncludeNullAndEmpty
    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    a5ee635 View commit details
    Browse the repository at this point in the history

  2. formatting

    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    aa341e1 View commit details
    Browse the repository at this point in the history

  3. added schema.Resource 

    added the new elements to the schema of the Kinesis settings
    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    2679b6c View commit details
    Browse the repository at this point in the history

  4. fix typo 

    removed a "}," that should not have been removed :-)
    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    833abac View commit details
    Browse the repository at this point in the history

  5. added TestCheckResourceAttr for Kinesis endpoints

    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    22371b2 View commit details
    Browse the repository at this point in the history

  6. update fales to "false"

    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    3bb5c26 View commit details
    Browse the repository at this point in the history

  7. update documentation

    @kduvekot-wehkamp-nl @ewbankkit
    kduvekot-wehkamp-nl authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    e6fbc35 View commit details
    Browse the repository at this point in the history

  8. add changelog

    @ksagle77 @ewbankkit
    ksagle77 authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    ec3c6af View commit details
    Browse the repository at this point in the history

  9. generalize change log

    @ksagle77 @ewbankkit
    ksagle77 authored and ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    ff0eed4 View commit details
    Browse the repository at this point in the history

  10. r/aws_dms_endpoint: Additional Kinesis settings. 

    Acceptance test output:

$ make testacc TESTARGS='-run=TestAccDMSEndpoint_kinesis' PKG_NAME=internal/service/dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms -v -count 1 -parallel 20 -run=TestAccDMSEndpoint_kinesis -timeout 180m
=== RUN   TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== CONT  TestAccDMSEndpoint_kinesis
--- PASS: TestAccDMSEndpoint_kinesis (182.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	182.255s
    @ewbankkit
    ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    9f0ced1 View commit details
    Browse the repository at this point in the history

  11. Update CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    e9dfe40 View commit details
    Browse the repository at this point in the history