Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cognito_identity_provider - fix updating idp_identifiers crash #19819

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 15, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19792

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoIdentityProvider_'
--- PASS: TestAccAWSCognitoIdentityProvider_disappears_userPool (32.44s)
--- PASS: TestAccAWSCognitoIdentityProvider_disappears (37.57s)
--- PASS: TestAccAWSCognitoIdentityProvider_basic (71.52s)
--- PASS: TestAccAWSCognitoIdentityProvider_idpIdentifiers (71.68s)

@github-actions github-actions bot added service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jun 15, 2021
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jun 15, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoIdentityProvider_'            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoIdentityProvider_ -timeout 180m
=== RUN   TestAccAWSCognitoIdentityProvider_basic
=== PAUSE TestAccAWSCognitoIdentityProvider_basic
=== RUN   TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== PAUSE TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== RUN   TestAccAWSCognitoIdentityProvider_disappears
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears
=== RUN   TestAccAWSCognitoIdentityProvider_disappears_userPool
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT  TestAccAWSCognitoIdentityProvider_basic
=== CONT  TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT  TestAccAWSCognitoIdentityProvider_disappears
=== CONT  TestAccAWSCognitoIdentityProvider_idpIdentifiers
--- PASS: TestAccAWSCognitoIdentityProvider_disappears_userPool (21.96s)
--- PASS: TestAccAWSCognitoIdentityProvider_disappears (24.54s)
--- PASS: TestAccAWSCognitoIdentityProvider_idpIdentifiers (36.80s)
--- PASS: TestAccAWSCognitoIdentityProvider_basic (37.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.015s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoIdentityProvider_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoIdentityProvider_ -timeout 180m
=== RUN   TestAccAWSCognitoIdentityProvider_basic
=== PAUSE TestAccAWSCognitoIdentityProvider_basic
=== RUN   TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== PAUSE TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== RUN   TestAccAWSCognitoIdentityProvider_disappears
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears
=== RUN   TestAccAWSCognitoIdentityProvider_disappears_userPool
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT  TestAccAWSCognitoIdentityProvider_basic
=== CONT  TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT  TestAccAWSCognitoIdentityProvider_disappears
=== CONT  TestAccAWSCognitoIdentityProvider_idpIdentifiers
--- PASS: TestAccAWSCognitoIdentityProvider_disappears_userPool (17.22s)
--- PASS: TestAccAWSCognitoIdentityProvider_disappears (19.94s)
--- PASS: TestAccAWSCognitoIdentityProvider_idpIdentifiers (36.92s)
--- PASS: TestAccAWSCognitoIdentityProvider_basic (36.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.355s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 244e325 into hashicorp:main Jun 16, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 16, 2021
@DrFaust92 DrFaust92 deleted the r/cognito_identity_provider branch June 16, 2021 14:45
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash - aws_cognito_identity_provider when updating idp_identifiers
2 participants