Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty string as valid setting for launch_type in CloudWatchEventTarget #19555

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Allow empty string as valid setting for launch_type in CloudWatchEventTarget #19555

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e88347
Allow empty string as valid setting for launch_type. Fixes #16078
ianneub May 27, 2021
f24b8f1
Added changelog entry
ianneub May 27, 2021
77d9014
Apply suggestions from code review
ianneub Jun 10, 2021
6540143
Fix error message from gofmt
ianneub Jun 10, 2021
4424349
Add acceptance tests for CloudWatchEventTargetEcs with LaunchType bla…
ianneub Jun 10, 2021
2e43dec
Move LaunchType tests into a single test run
ianneub Jun 10, 2021
c8b84ab
update documentation to reflect support for empty string
anGie44 Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/19555.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_cloudwatch_event_target: Fix ecs_target.launch_type not allowing empty string values.
ianneub marked this conversation as resolved.
Show resolved Hide resolved
```
2 changes: 1 addition & 1 deletion aws/resource_aws_cloudwatch_event_target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func resourceAwsCloudWatchEventTarget() *schema.Resource {
Type: schema.TypeString,
Optional: true,
Default: events.LaunchTypeEc2,
ValidateFunc: validation.StringInSlice(events.LaunchType_Values(), false),
ValidateFunc: validation.StringInSlice(append(events.LaunchType_Values(), []string{""}...), false),
ianneub marked this conversation as resolved.
Show resolved Hide resolved
},
"network_configuration": {
Type: schema.TypeList,
Expand Down