Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify resource name #18540

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Clarify resource name #18540

merged 1 commit into from
Apr 21, 2021

Conversation

atz
Copy link
Contributor

@atz atz commented Apr 1, 2021

aws_cloudfront_origin_access_identity.origin_access_identity.iam_arn seems like a copy-paste error. The Using With CloudFront section already uses a resource named example. This updates the other lines to match.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@atz
Clarify resource name
6e4db59 
`aws_cloudfront_origin_access_identity.origin_access_identity.iam_arn` seems like a copy-paste error.  The `Using With CloudFront` section already uses a resource named `example`.  This updates the other lines to match.
@atz atz requested a review from a team as a code owner April 1, 2021 23:55
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Apr 1, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 1, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 21, 2021
ewbankkit
ewbankkit approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@atz Thanks for the contribution 👏.

@ewbankkit ewbankkit merged commit ac06ced into hashicorp:main Apr 21, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 21, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@atz atz deleted the patch-1 branch May 28, 2021 00:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@atz @ewbankkit