Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_globalaccelerator_accelerator: Correctly update flow log attributes when enabled #17739

Commits on Feb 11, 2021

  1. r/aws_globalaccelerator_accelerator: Don't pass empty strings in attr…

    …ibutes.
    
    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_update
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_update
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (74.71s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (98.44s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (111.19s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (111.53s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	111.631s
    ewbankkit committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    9e7ccab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b43ba3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd18053 View commit details
    Browse the repository at this point in the history
  4. r/aws_globalaccelerator_accelerator: Use internal finder package. Add…

    … '_disappears' test (hashicorp#13826, hashicorp#13527).
    
    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_disappears
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_update
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_update
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_disappears
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (68.53s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (77.55s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (101.99s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (103.04s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (112.32s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	112.414s
    ewbankkit committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    46e939b View commit details
    Browse the repository at this point in the history
  5. r/aws_globalaccelerator_accelerator: Use internal waiter package.

    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_disappears
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_update
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_update
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_disappears
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (66.21s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (70.15s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (101.99s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (105.02s)
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (114.42s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	114.558s
    ewbankkit committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    e960545 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. r/aws_globalaccelerator_accelerator: To change flow logs bucket and p…

    …refix attributes while flows are enabled, first disable flow logs.
    
    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_attributes'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_attributes -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
    --- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (270.49s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	270.583s
    
    Without the fix the test failed:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorAccelerator_attributes'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorAccelerator_attributes -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
    === PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
    === CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
        resource_aws_globalaccelerator_accelerator_test.go:285: Step 4/5 error: Error running apply: exit status 1
            2021/02/21 16:43:59 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.13.0
    
            Error: error updating Global Accelerator Accelerator (arn:aws:globalaccelerator::346386234494:accelerator/6319d8d8-c21d-4f2d-b685-cd66271d3171) attributes: InvalidArgumentException: Subscription already exists: BucketName[tf-acc-test-6489429174030632786] Prefix[flow-logs/]. Please delete and recreate the subscription if you want to change the config of your subscription.
    
    --- FAIL: TestAccAwsGlobalAcceleratorAccelerator_attributes (166.85s)
    FAIL
    FAIL	github.com/terraform-providers/terraform-provider-aws/aws	166.947s
    FAIL
    GNUmakefile:27: recipe for target 'testacc' failed
    make: *** [testacc] Error 1
    ewbankkit committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    c1aa951 View commit details
    Browse the repository at this point in the history
  2. r/aws_globalaccelerator_endpoint_group: Use internal finder and waite…

    …r packages.
    
    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_basic'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_basic -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
    === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
    === CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
    --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (177.37s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	177.444s
    ewbankkit committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    7ecb101 View commit details
    Browse the repository at this point in the history
  3. r/aws_globalaccelerator_listener: Use internal finder and waiter pack…

    …ages. Add '_disappears' test (hashicorp#13826, hashicorp#13527).
    
    Acceptance test output:
    
    $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorListener_disappears'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorListener_disappears -timeout 120m
    === RUN   TestAccAwsGlobalAcceleratorListener_disappears
    === PAUSE TestAccAwsGlobalAcceleratorListener_disappears
    === CONT  TestAccAwsGlobalAcceleratorListener_disappears
    --- PASS: TestAccAwsGlobalAcceleratorListener_disappears (120.32s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	120.416s
    ewbankkit committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    954c245 View commit details
    Browse the repository at this point in the history
  4. Add CHANGELOG entry.

    ewbankkit committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    a982857 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Configuration menu
    Copy the full SHA
    8b2ae0d View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    87de131 View commit details
    Browse the repository at this point in the history