Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/aws storagegateway gateway #17715

Closed
wants to merge 4 commits into from
Closed

F/aws storagegateway gateway #17715

wants to merge 4 commits into from

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16701

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewayGateway_SMBFileShareVisibility'
=== RUN   TestAccAWSStorageGatewayGateway_SMBFileShareVisibility
=== PAUSE TestAccAWSStorageGatewayGateway_SMBFileShareVisibility
=== CONT  TestAccAWSStorageGatewayGateway_SMBFileShareVisibility
--- PASS: TestAccAWSStorageGatewayGateway_SMBFileShareVisibility (391.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	398.518s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner February 19, 2021 18:50
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 19, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2021
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2021
@DrFaust92
Copy link
Collaborator

Closes #18058

@DrFaust92
Copy link
Collaborator

Closing in favor #18076 thats already been merged. sorry for missing this!

@DrFaust92 DrFaust92 closed this Mar 17, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_storagegateway_gateway SMB file_share_visibility support
2 participants
@nikhil-goenka @DrFaust92