New Resource: aws_wafregional_rule

[knehring]

This PR is a port of the originally opened by @yusukegoto at hashicorp/terraform#13710, with some minor tweaks based off of conversations in other PRs for wafregional

[radeksimko]

Hi @knehring
this PR was already re-raised in #1045 and there are other WAF regional PRs pending some work based on feedback I provided in #1013 or #1014

Do you have any plans to implement the feedback?

If not, that's 👌 - just FYI given that this PR was re-opened couple of times and always went stale I will go ahead and implement the changes on top of @yusukegoto's PRs (because he we the first one raising PRs for this).

[giuliocalzolari]

Hi do you plan to merge it?

[knehring]

All of the changes that you linked in the above PR's have been implemented in this PR, its been awhile since I looked at this, but from looking at the feedback on those PR some of them do not apply in this case.

1. No plural tuple/tuples (not used in this)
2. This is not missing any fields afaik
3. The Update code uses existing code in the global waf rule for diffing the updates and should be good here
4. the tests reflect what is currently there for the global WAF Rule, if I am missing any tests here please let me know

I don't think there need to be any more changes to this bit of code. The only other thing I think would be beneficial is to have the other resources implemented as well. That shouldn't stop this PR from being implemented because this would allow the use of the byte match set and ipsets that are already implemented. @radeksimko

[radeksimko]

#3756 which added this resource was just merged. Thanks to everyone involved 🎉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!