Add configuration set support for Cognito user pools

[johngallagher]

Adds configuration set support for Cognito user pools.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_cognito_user_pool: Add `configuration_set`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPool_withEmailConfiguration'                                                                                                  

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPool_withEmailConfiguration -timeout 120m
=== RUN   TestAccAWSCognitoUserPool_withEmailConfiguration
=== PAUSE TestAccAWSCognitoUserPool_withEmailConfiguration
=== CONT  TestAccAWSCognitoUserPool_withEmailConfiguration
--- PASS: TestAccAWSCognitoUserPool_withEmailConfiguration (49.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       52.910s

[github-actions]

Welcome @johngallagher 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

@johngallagher @simplybusiness Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider!

[johngallagher]

@YakDriver Thanks! Sorry for the delay - I've been off work for a few weeks. I followed the instructions on Github to do this but the tickbox doesn't appear for me where it says it should on this PR page.

Let me know if I've done something wrong or if there's something else you need from me. Thanks.

[YakDriver]

@johngallagher Thanks for getting back to me. The problem is that @simplybusiness owns the repository that owns the fork that you requested to be pulled. SB will need to check that box. Another option is for me to create a separate branch and cherry pick your commits from this fork. You'll get credit as though it was your PR. Are you in contact with SB?

[johngallagher]

@johngallagher Thanks for getting back to me. The problem is that @simplybusiness owns the repository that owns the fork that you requested to be pulled. SB will need to check that box. Another option is for me to create a separate branch and cherry pick your commits from this fork. You'll get credit as though it was your PR. Are you in contact with SB?

Yup, I still work there. So I'll ask for an admin to enable this... thanks for your patience!

[johngallagher]

@johngallagher Thanks for getting back to me. The problem is that @simplybusiness owns the repository that owns the fork that you requested to be pulled. SB will need to check that box. Another option is for me to create a separate branch and cherry pick your commits from this fork. You'll get credit as though it was your PR. Are you in contact with SB?

@YakDriver - I've asked an admin to look at this and they can't see the tickbox either. Sorry!

So yeah, if you could create a separate branch and cherry pick commits, that'd be great. Sorry for the hassle!

[YakDriver]

@johngallagher It's the second time I've run into this recently with contributors that do not own their forks. Perhap it's a GitHub limitation or it is influenced by a @simplybusiness organization-level setting.

[johngallagher]

@johngallagher It's the second time I've run into this recently with contributors that do not own their forks. Perhap it's a GitHub limitation or it is influenced by a @simplybusiness organization-level setting.

My bet is that SB have disabled something at a high level even for admins. Cherry pick away and sorry again for the hassle.

[YakDriver]

@johngallagher You can see your contribution as part of #14935! Thanks again. 🎉

[ghost]

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!