Detect error_action in IoT rule

[partheinstein]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16115

Release note for CHANGELOG:

Fixes a bug where changes to IoT rule to add an error action are not applied

Output from acceptance testing:

--- PASS: TestAccAWSIoTTopicRule_updateKinesisErrorAction (129.33s)

[github-actions]

Welcome @partheinstein 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[partheinstein]

I can't seem to run the acceptance tests:

make testacc TESTARGS='-run=TestAccAWSIoTTopicRule_errorAction'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTTopicRule_errorAction -timeout 120m
=== RUN   TestAccAWSIoTTopicRule_errorAction
=== PAUSE TestAccAWSIoTTopicRule_errorAction
=== CONT  TestAccAWSIoTTopicRule_errorAction
    resource_aws_iot_topic_rule_test.go:549: Error running init: There are some problems with the configuration, described below.
        
        The Terraform configuration must be valid before initialization so that
        Terraform can determine which modules and providers need to be installed.
        
        Error: Failed to read module directory
        
        Module directory
        ../../../../../../../../var/folders/r7/q01cwd856_z5zsqmm7t9ry4r0000gn/T/plugintest413571117/work493259688/config341933799
        does not exist or cannot be read.
        
--- FAIL: TestAccAWSIoTTopicRule_errorAction (2.25s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	4.006s
FAIL
make: *** [testacc] Error 1

I could use some help diagnosing this.

[kurtmc]

Hey @partheinstein I checked out your branch and ran the tests against my AWS account and it looks all good:

$ make testacc TESTARGS='-run=TestAccAWSIoTTopicRule_errorAction'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTTopicRule_errorAction -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.35.34
go: downloading github.com/hashicorp/terraform-plugin-sdk/v2 v2.3.0
go: downloading github.com/hashicorp/go-hclog v0.10.0
=== RUN   TestAccAWSIoTTopicRule_errorAction
=== PAUSE TestAccAWSIoTTopicRule_errorAction
=== CONT  TestAccAWSIoTTopicRule_errorAction
--- PASS: TestAccAWSIoTTopicRule_errorAction (33.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       33.054s

@ewbankkit Could this get a review?

[anGie44]

Thank you for this PR @partheinstein !

[github-actions]

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.