r/aws_elasticsearchdomain: add support for saml_options

[philof]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #16259

Release note for CHANGELOG:

* resource/aws_elasticsearch_domain: Support `saml_options` advanced_security_option ([#16259](https://github.com/hashicorp/terraform-provider-aws/issues/16259))

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticSearchDomain_AdvancedSecurityOptions_SAML'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticSearchDomain_AdvancedSecurityOptions_SAML -timeout 120m
=== RUN   TestAccAWSElasticSearchDomain_AdvancedSecurityOptions_SAML
=== PAUSE TestAccAWSElasticSearchDomain_AdvancedSecurityOptions_SAML
=== CONT  TestAccAWSElasticSearchDomain_AdvancedSecurityOptions_SAML
--- PASS: TestAccAWSElasticSearchDomain_AdvancedSecurityOptions_SAML (985.80s)
PASS
ok           github.com/terraform-providers/terraform-provider-aws/aws     987.358s
...

The overall structure is ready, but I still have an issue with You cannot specify SAML options during domain creation. The second apply in the create test results in a non-empty plan. I couldn't find another resource in the repo which restricts parameters on creation. I would greatly appreciate any guidance for this two-step creation process.

[github-actions]

Welcome @philof 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jbvmio]

When will this be merged?

[thameezb]

bump

[JeffAshton]

Did you consider making the SAML options be there own resource so that it could be combined with the Okta terraform provider

https://registry.terraform.io/providers/oktadeveloper/okta/latest/docs/resources/app_saml

Elasticsearch -> Okta -> Elasticsearch SAML

This would also solve the issue that the SAML config cannot be specified until after the domain is created.

[philof]

I have a new custom resource for aws_elasticsearch_domain_saml_options. Would you like a new pull request or to edit this one?

[JeffAshton]

aws_elasticsearch_domain_saml_options

I would probably create a new pull request. The separate resource should be perfect.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.