Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MemberStatus values to the currently available through the AWS… #16404

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

reactiveinactive
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16403

Release note for CHANGELOG:

resource/aws_securityhub_member: Update MemberStatus values 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@reactiveinactive reactiveinactive requested a review from a team as a code owner November 24, 2020 11:26
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/securityhub Issues and PRs that pertain to the securityhub service. labels Nov 24, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 24, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @reactiveinactive 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@bflad bflad self-assigned this Nov 24, 2020
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2020
@bflad
Copy link
Contributor

bflad commented Nov 24, 2020

Please note that I'm holding off on merging this as-is, since the service team may opt to rollback the change since it breaks all previous Terraform AWS Provider versions. We could temporarily support both the previous and new value if we wanted to get this in immediately without risk of the API changing again.

@bflad bflad added this to the v3.18.0 milestone Nov 24, 2020
@bflad
Copy link
Contributor

bflad commented Nov 24, 2020

(In the meantime, for anyone 👍 reacting here, you may also want to 👍 react to the issue itself: #16403 so there's accurate tracking of those affected)

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for raising this, @reactiveinactive

Since AWS China (and potentially other AWS partitions) do not support the new Organizations integration that caused this breaking API change:

We will need to support both old and new values for now. Once this is in, we should be able to merge this and release it in the next day or two.

aws/resource_aws_securityhub_member.go Outdated Show resolved Hide resolved
aws/resource_aws_securityhub_member.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 24, 2020
@reactiveinactive
Copy link
Contributor Author

@bflad looks ok to me, do I need to do anything else? First time doing a pull request so not entirely sure on how this all works.

@ghost ghost removed waiting-response Maintainers are waiting on response from community or contributor. labels Nov 24, 2020
@ghost ghost removed waiting-response Maintainers are waiting on response from community or contributor. labels Nov 24, 2020
reactiveinactive and others added 2 commits November 24, 2020 21:26
Co-authored-by: Brian Flad <bflad417@gmail.com>
Co-authored-by: Brian Flad <bflad417@gmail.com>
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this fix, @reactiveinactive 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSecurityHub_serial (29.45s)
    --- PASS: TestAccAWSSecurityHub_serial/Member (29.45s)
        --- PASS: TestAccAWSSecurityHub_serial/Member/basic (15.06s)
        --- PASS: TestAccAWSSecurityHub_serial/Member/invite (14.39s)

@bflad bflad merged commit 1b44741 into hashicorp:master Nov 24, 2020
bflad added a commit that referenced this pull request Nov 24, 2020
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/securityhub Issues and PRs that pertain to the securityhub service. size/XS Managed by automation to categorize the size of a PR. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Securityhub recent MemberStatus changes
2 participants