Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_datasync_agent: Add support for VPC Endpoints #16207

Merged
merged 3 commits into from
May 13, 2021

Conversation

gazoakley
Copy link
Contributor

@gazoakley gazoakley commented Nov 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9755

Release note for CHANGELOG:

* resource/aws_datasync_agent: Add support for VPC Endpoints ([#16207](https://github.com/hashicorp/terraform-provider-aws/issues/16207))

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSDataSyncAgent_'             
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncAgent_ -timeout 120m
=== RUN   TestAccAWSDataSyncAgent_basic
=== PAUSE TestAccAWSDataSyncAgent_basic
=== RUN   TestAccAWSDataSyncAgent_disappears
=== PAUSE TestAccAWSDataSyncAgent_disappears
=== RUN   TestAccAWSDataSyncAgent_AgentName
=== PAUSE TestAccAWSDataSyncAgent_AgentName
=== RUN   TestAccAWSDataSyncAgent_Tags
=== PAUSE TestAccAWSDataSyncAgent_Tags
=== RUN   TestAccAWSDataSyncAgent_VpcEndpointId
=== PAUSE TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT  TestAccAWSDataSyncAgent_basic
=== CONT  TestAccAWSDataSyncAgent_Tags
=== CONT  TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT  TestAccAWSDataSyncAgent_AgentName
=== CONT  TestAccAWSDataSyncAgent_disappears
--- PASS: TestAccAWSDataSyncAgent_basic (208.76s)
--- PASS: TestAccAWSDataSyncAgent_disappears (209.61s)
--- PASS: TestAccAWSDataSyncAgent_VpcEndpointId (265.29s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (293.86s)
--- PASS: TestAccAWSDataSyncAgent_Tags (359.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	360.819s

@gazoakley gazoakley requested a review from a team as a code owner November 15, 2020 19:43
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 15, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2020
@gazoakley gazoakley force-pushed the f-datasync-vpc-endpoint branch 3 times, most recently from d31a060 to 60ef8d4 Compare November 16, 2020 22:19
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 16, 2020
@gazoakley gazoakley changed the title [WIP] resource/aws_datasync_agent: Add support for VPC Endpoints resource/aws_datasync_agent: Add support for VPC Endpoints Nov 16, 2020
Base automatically changed from master to main January 23, 2021 00:59
@ghost ghost added the documentation Introduces or discusses updates to documentation. label May 13, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 13, 2021
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 13, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncAgent_'                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncAgent_ -timeout 180m
=== RUN   TestAccAWSDataSyncAgent_basic
=== PAUSE TestAccAWSDataSyncAgent_basic
=== RUN   TestAccAWSDataSyncAgent_disappears
=== PAUSE TestAccAWSDataSyncAgent_disappears
=== RUN   TestAccAWSDataSyncAgent_AgentName
=== PAUSE TestAccAWSDataSyncAgent_AgentName
=== RUN   TestAccAWSDataSyncAgent_Tags
=== PAUSE TestAccAWSDataSyncAgent_Tags
=== RUN   TestAccAWSDataSyncAgent_VpcEndpointId
=== PAUSE TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT  TestAccAWSDataSyncAgent_basic
=== CONT  TestAccAWSDataSyncAgent_Tags
=== CONT  TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT  TestAccAWSDataSyncAgent_AgentName
=== CONT  TestAccAWSDataSyncAgent_disappears
--- PASS: TestAccAWSDataSyncAgent_disappears (133.55s)
--- PASS: TestAccAWSDataSyncAgent_basic (161.01s)
--- PASS: TestAccAWSDataSyncAgent_Tags (188.41s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (224.94s)
--- PASS: TestAccAWSDataSyncAgent_VpcEndpointId (328.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	331.019s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncAgent_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncAgent_ -timeout 180m
=== RUN   TestAccAWSDataSyncAgent_basic
=== PAUSE TestAccAWSDataSyncAgent_basic
=== RUN   TestAccAWSDataSyncAgent_disappears
=== PAUSE TestAccAWSDataSyncAgent_disappears
=== RUN   TestAccAWSDataSyncAgent_AgentName
=== PAUSE TestAccAWSDataSyncAgent_AgentName
=== RUN   TestAccAWSDataSyncAgent_Tags
=== PAUSE TestAccAWSDataSyncAgent_Tags
=== RUN   TestAccAWSDataSyncAgent_VpcEndpointId
=== PAUSE TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT  TestAccAWSDataSyncAgent_basic
=== CONT  TestAccAWSDataSyncAgent_Tags
=== CONT  TestAccAWSDataSyncAgent_AgentName
=== CONT  TestAccAWSDataSyncAgent_VpcEndpointId
=== CONT  TestAccAWSDataSyncAgent_disappears
--- PASS: TestAccAWSDataSyncAgent_disappears (138.23s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (156.87s)
--- PASS: TestAccAWSDataSyncAgent_basic (184.51s)
--- PASS: TestAccAWSDataSyncAgent_VpcEndpointId (204.57s)
--- PASS: TestAccAWSDataSyncAgent_Tags (207.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	210.851s

@ewbankkit ewbankkit merged commit 761d6be into hashicorp:main May 13, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/datasync Issues and PRs that pertain to the datasync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS DataSync supports VPC Endpoints
2 participants