r/aws_appmesh_virtual_node: Add connection pool and outlier detection #16167

ewbankkit · 2020-11-12T21:56:29Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes: #16097.

Release note for CHANGELOG:

resource/aws_appmesh_virtual_node: Add `listener.connection_pool` attribute
resource/aws_appmesh_virtual_node: Add `listener.outlier_detection` attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm        
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
--- PASS: TestAccAWSAppmesh_serial (468.07s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (468.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (28.23s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (71.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (27.86s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (40.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (12.83s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (28.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (100.22s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (28.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (28.09s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (52.11s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (28.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	468.135s

DrFaust92

LGTM

--- PASS: TestAccAWSAppmesh_serial (1265.32s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (1265.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (84.35s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (113.52s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (45.67s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (38.22s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (80.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (81.50s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (195.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (75.12s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (131.11s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (82.05s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (87.50s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (168.28s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (81.96s)

…ener.tls.certificate'.

…ener.timeout'.

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/listenerConnectionPool' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/listenerConnectionPool -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool --- PASS: TestAccAWSAppmesh_serial (28.73s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (28.73s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (28.73s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 28.802s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/disappears -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/disappears --- PASS: TestAccAWSAppmesh_serial (13.06s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (13.06s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (13.06s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 13.121s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/listenerOutlierDetection' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/listenerOutlierDetection -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection --- PASS: TestAccAWSAppmesh_serial (29.16s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (29.16s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (29.16s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 29.218s

…listener.outlier_detection' attributes.

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualNode === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTls === RUN TestAccAWSAppmesh_serial/VirtualNode/logging === RUN TestAccAWSAppmesh_serial/VirtualNode/tags === RUN TestAccAWSAppmesh_serial/VirtualNode/disappears === RUN TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile === RUN TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout === RUN TestAccAWSAppmesh_serial/VirtualNode/basic === RUN TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm === RUN TestAccAWSAppmesh_serial/VirtualNode/backendDefaults === RUN TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks --- PASS: TestAccAWSAppmesh_serial (468.07s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (468.07s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (28.23s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (71.32s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (27.86s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (40.02s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (12.83s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (28.32s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (100.22s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (28.26s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (28.09s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.17s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (52.11s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.17s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (28.25s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 468.135s

ewbankkit · 2020-12-01T19:59:02Z

Rebase and resolved merge conflicts.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
--- PASS: TestAccAWSAppmesh_serial (496.00s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (496.00s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (30.24s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (27.98s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (15.94s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (12.45s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (100.78s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (28.51s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (28.35s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (28.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (72.93s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (28.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (52.41s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (41.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	496.083s

awsiv · 2020-12-02T09:28:28Z

Thanks! Have been waiting for this. Any idea on when this will be merged or what is missing from this PR (LGTM btw 🚀 )?

ewbankkit · 2020-12-02T13:23:40Z

@awsiv Should be merged soon...

breathingdust · 2020-12-04T23:19:30Z

LGTM 🚀 Thanks @ewbankkit

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
--- PASS: TestAccAWSAppmesh_serial (461.96s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (461.96s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (25.56s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (13.16s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (12.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (50.82s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (25.55s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (23.72s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (113.72s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (24.85s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (23.87s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (62.29s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (24.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (25.95s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (36.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	463.631s

ghost · 2020-12-11T17:11:52Z

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-01-04T17:10:00Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team as a code owner November 12, 2020 21:56

ghost added size/XXL Managed by automation to categorize the size of a PR. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 12, 2020

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 14, 2020

DrFaust92 approved these changes Nov 14, 2020

View reviewed changes

ewbankkit added 8 commits December 1, 2020 14:39

r/aws_appmesh_virtual_node: Add ExactlyOneOf constraint on 'spec.list…

da1ee9d

…ener.tls.certificate'.

r/aws_appmesh_virtual_node: Add ExactlyOneOf constraint on 'spec.list…

8512150

…ener.timeout'.

Add 'expandAppmeshDuration' and 'flattenAppmeshDuration'.

2451a85

r/aws_appmesh_virtual_node: Document 'listener.connection_pool' and '…

bad22fb

…listener.outlier_detection' attributes.

ewbankkit force-pushed the f-aws_appmesh_virtual_node-connection_pool-outlier_detection branch from 71585ef to e3a381b Compare December 1, 2020 19:49

breathingdust added this to the v3.21.0 milestone Dec 4, 2020

breathingdust merged commit 1745978 into hashicorp:master Dec 4, 2020

breathingdust added a commit that referenced this pull request Dec 4, 2020

Update CHANGELOG.md for #16167

7cbb1e8

ewbankkit deleted the f-aws_appmesh_virtual_node-connection_pool-outlier_detection branch December 5, 2020 12:32

ghost locked as resolved and limited conversation to collaborators Jan 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_appmesh_virtual_node: Add connection pool and outlier detection #16167

r/aws_appmesh_virtual_node: Add connection pool and outlier detection #16167

ewbankkit commented Nov 12, 2020 •

edited

Loading

DrFaust92 left a comment

ewbankkit commented Dec 1, 2020

awsiv commented Dec 2, 2020

ewbankkit commented Dec 2, 2020

breathingdust commented Dec 4, 2020

ghost commented Dec 11, 2020

ghost commented Jan 4, 2021

r/aws_appmesh_virtual_node: Add connection pool and outlier detection #16167

r/aws_appmesh_virtual_node: Add connection pool and outlier detection #16167

Conversation

ewbankkit commented Nov 12, 2020 • edited Loading

Community Note

DrFaust92 left a comment

Choose a reason for hiding this comment

ewbankkit commented Dec 1, 2020

awsiv commented Dec 2, 2020

ewbankkit commented Dec 2, 2020

breathingdust commented Dec 4, 2020

ghost commented Dec 11, 2020

ghost commented Jan 4, 2021

ewbankkit commented Nov 12, 2020 •

edited

Loading