Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_instance: Ignore DBInstanceNotFound error during deletion #15942

Merged
merged 1 commit into from
Nov 11, 2020
Merged

resource/aws_db_instance: Ignore DBInstanceNotFound error during deletion #15942

merged 1 commit into from
Nov 11, 2020

Commits on Oct 30, 2020

  1. resource/aws_db_instance: Ignore DBInstanceNotFound error during dele… 

    …tion

Reference: #12900

Unfortunately testing this scenario is complicated in the Terraform Plugin SDK acceptance testing framework as refresh before deletion is standard behavior and the error gets caught in the Read function (e.g. disappears testing). In the future, we may propose to write a standard way for converting AWS Go SDK errors with specific error codes and messages to the Terraform Plugin SDK resource.NotFoundError, which we could then use static analysis against in the Read/Delete/CheckDestroy functions to ensure its always handled. For now though, this is a targeted fix for a community reported situation.
    @bflad
    bflad committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    27df261 View commit details
    Browse the repository at this point in the history