Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ds key pair #15829

Merged
merged 8 commits into from
Nov 10, 2021
Merged

Feature/ds key pair #15829

merged 8 commits into from
Nov 10, 2021

Conversation

pkruk
Copy link
Contributor

@pkruk pkruk commented Oct 24, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15590

Release note for CHANGELOG:

NONE

Output from acceptance testing:

☁  terraform-provider-aws [feature/ds_key_pair] ⚡  AWS_PROFILE=default make testacc TESTARGS='-run=TestAccDataSourceAwsKeyPair_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsKeyPair_basic -timeout 120m

=== RUN   TestAccDataSourceAwsKeyPair_basic
=== PAUSE TestAccDataSourceAwsKeyPair_basic
=== CONT  TestAccDataSourceAwsKeyPair_basic
--- PASS: TestAccDataSourceAwsKeyPair_basic (35.10s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       37.831s
...

This is my first PR here, I will be very happy for feedback and if you spot anything missing in PR :)

@pkruk pkruk requested a review from a team October 24, 2020 22:19
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 24, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 24, 2020
@pkruk pkruk changed the title Feature/ds key pair #15590 Feature/ds key pair Oct 24, 2020
@andrzej-jedrzejewski
Copy link

When this will be merged and released?

@andrzej-jedrzejewski
Copy link

merge and release, please :)

@evandam
Copy link

evandam commented Jan 13, 2021

Hey folks, anything holding this PR back? Seems like it's ready to go and would be helpful!

Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@bneigher
Copy link

bneigher commented Feb 9, 2021

looking forward to this!

@fabriciomariani
Copy link

Is there anything blockthing this from getting released? Seems like everything is ready to go

@pkruk
Copy link
Contributor Author

pkruk commented May 18, 2021

Hi,
Any chance to get it merged :)? There is anything I can do ?

@mboogerd
Copy link

Code makes sense, documentation and tests are provided. All automated lights are green. Could we get this small but useful feature merged, or an ETA on when it'll be looked into? Thanks in advance :)

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@alexbricepalo
Copy link

Whats the holdup here?

@mbainter
Copy link
Contributor

mbainter commented Sep 21, 2021

See the contributions file, specifically:

Edit: Snipped out the quote regarding a moratorium on PRs, as that apparently doesn't apply to providers but only terraform core. See @justinretzolk's comment below.

@justinretzolk
Copy link
Member

Hi all 👋 Thank you all for your patience here. We use the "👍" reactions on a given issue/pull request in order to aid in prioritizing community contributions (thank you to everyone who has reacted to this one so far!). While I can't promise any sort of timeline for review/merge, the team is aware of this pull request, and will work on it as soon as time permits. Please keep adding "👍" if this pull request would help you; the more votes it receives, the more likely it is that it will be included in an upcoming release.

I'd be remiss if I didn't mention the quote that @mbainter provided. That update applies only to Terraform Core, not the separate provider repositories. We are still reviewing and accepting community contributions to the individual providers, including the AWS provider.

@pkruk
Copy link
Contributor Author

pkruk commented Sep 30, 2021

I just resolved the merge conflict, so we will have a clean state for merging ;)

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit ewbankkit self-assigned this Nov 10, 2021
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Nov 10, 2021
pkruk and others added 4 commits November 10, 2021 13:10
Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2KeyPairDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2KeyPairDataSource_basic -timeout 180m
=== RUN   TestAccEC2KeyPairDataSource_basic
=== PAUSE TestAccEC2KeyPairDataSource_basic
=== CONT  TestAccEC2KeyPairDataSource_basic
--- PASS: TestAccEC2KeyPairDataSource_basic (14.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	17.678s
Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2KeyPair_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2KeyPair_ -timeout 180m
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== RUN   TestAccEC2KeyPair_tags
=== PAUSE TestAccEC2KeyPair_tags
=== RUN   TestAccEC2KeyPair_nameGenerated
=== PAUSE TestAccEC2KeyPair_nameGenerated
=== RUN   TestAccEC2KeyPair_namePrefix
=== PAUSE TestAccEC2KeyPair_namePrefix
=== RUN   TestAccEC2KeyPair_disappears
=== PAUSE TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPair_basic
=== CONT  TestAccEC2KeyPair_namePrefix
=== CONT  TestAccEC2KeyPair_nameGenerated
=== CONT  TestAccEC2KeyPair_tags
=== CONT  TestAccEC2KeyPair_disappears
--- PASS: TestAccEC2KeyPair_disappears (12.31s)
--- PASS: TestAccEC2KeyPair_namePrefix (15.84s)
--- PASS: TestAccEC2KeyPair_basic (16.10s)
--- PASS: TestAccEC2KeyPair_nameGenerated (16.95s)
--- PASS: TestAccEC2KeyPair_tags (35.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	41.854s
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 10, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_ -timeout 180m
=== RUN   TestAccEC2KeyPairDataSource_basic
=== PAUSE TestAccEC2KeyPairDataSource_basic
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== RUN   TestAccEC2KeyPair_tags
=== PAUSE TestAccEC2KeyPair_tags
=== RUN   TestAccEC2KeyPair_nameGenerated
=== PAUSE TestAccEC2KeyPair_nameGenerated
=== RUN   TestAccEC2KeyPair_namePrefix
=== PAUSE TestAccEC2KeyPair_namePrefix
=== RUN   TestAccEC2KeyPair_disappears
=== PAUSE TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPairDataSource_basic
=== CONT  TestAccEC2KeyPair_nameGenerated
=== CONT  TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPair_namePrefix
=== CONT  TestAccEC2KeyPair_tags
=== CONT  TestAccEC2KeyPair_basic
--- PASS: TestAccEC2KeyPair_disappears (13.90s)
--- PASS: TestAccEC2KeyPairDataSource_basic (16.08s)
--- PASS: TestAccEC2KeyPair_basic (16.57s)
--- PASS: TestAccEC2KeyPair_namePrefix (18.78s)
--- PASS: TestAccEC2KeyPair_nameGenerated (18.93s)
--- PASS: TestAccEC2KeyPair_tags (39.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	43.226s
GovCloud
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2KeyPair_\|TestAccEC2KeyPairDataSource_ -timeout 180m
=== RUN   TestAccEC2KeyPairDataSource_basic
=== PAUSE TestAccEC2KeyPairDataSource_basic
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== RUN   TestAccEC2KeyPair_tags
=== PAUSE TestAccEC2KeyPair_tags
=== RUN   TestAccEC2KeyPair_nameGenerated
=== PAUSE TestAccEC2KeyPair_nameGenerated
=== RUN   TestAccEC2KeyPair_namePrefix
=== PAUSE TestAccEC2KeyPair_namePrefix
=== RUN   TestAccEC2KeyPair_disappears
=== PAUSE TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPairDataSource_basic
=== CONT  TestAccEC2KeyPair_namePrefix
=== CONT  TestAccEC2KeyPair_tags
=== CONT  TestAccEC2KeyPair_basic
=== CONT  TestAccEC2KeyPair_disappears
=== CONT  TestAccEC2KeyPair_nameGenerated
--- PASS: TestAccEC2KeyPair_disappears (18.06s)
--- PASS: TestAccEC2KeyPairDataSource_basic (20.76s)
--- PASS: TestAccEC2KeyPair_nameGenerated (23.55s)
--- PASS: TestAccEC2KeyPair_basic (23.58s)
--- PASS: TestAccEC2KeyPair_namePrefix (23.63s)
--- PASS: TestAccEC2KeyPair_tags (49.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	53.100s

@ewbankkit
Copy link
Contributor

@pkruk Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit removed their assignment Nov 10, 2021
@ewbankkit ewbankkit merged commit ecf630a into hashicorp:main Nov 10, 2021
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 10, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a data source for aws_key_pair