Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Fix hardcoded ARN (Transfer User) #15748

Merged
merged 1 commit into from
Oct 22, 2020
Merged

tests/provider: Fix hardcoded ARN (Transfer User) #15748

merged 1 commit into from
Oct 22, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 20, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15662

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud) (no regressions):

--- FAIL: TestAccAWSTransferUser_homeDirectoryMappings (9.40s)
--- FAIL: TestAccAWSTransferUser_modifyWithOptions (10.00s)
--- FAIL: TestAccAWSTransferUser_basic (10.17s)
--- FAIL: TestAccAWSTransferUser_disappears (10.21s)
--- PASS: TestAccAWSTransferUser_UserName_Validation (13.24s)

***Failures preexisting & unrelated and tracked in #15761.

Output from acceptance testing (commercial):

--- PASS: TestAccAWSTransferUser_UserName_Validation (14.61s)
--- PASS: TestAccAWSTransferUser_basic (196.52s)
--- PASS: TestAccAWSTransferUser_disappears (203.21s)
--- PASS: TestAccAWSTransferUser_homeDirectoryMappings (220.40s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (225.30s)

@YakDriver YakDriver requested a review from a team October 20, 2020 17:47
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/transfer Issues and PRs that pertain to the transfer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 20, 2020
@YakDriver YakDriver mentioned this pull request Oct 20, 2020
Closed
69 tasks
gdavison
gdavison reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Waiting on acceptance test results

@YakDriver YakDriver mentioned this pull request Oct 21, 2020
Closed
@YakDriver
Copy link
Member Author

@gdavison Acceptance tests done. Little disappointing on GovCloud but gets us to the next stage of errors.

@YakDriver YakDriver requested a review from gdavison October 21, 2020 21:45
gdavison
gdavison approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Commercial Partition

--- PASS: TestAccAWSTransferUser_UserName_Validation (14.53s)
--- PASS: TestAccAWSTransferUser_basic (163.72s)
--- PASS: TestAccAWSTransferUser_disappears (202.61s)
--- PASS: TestAccAWSTransferUser_homeDirectoryMappings (221.09s)
--- PASS: TestAccAWSTransferUser_modifyWithOptions (223.92s)

GovCloud Partition

--- FAIL: TestAccAWSTransferUser_modifyWithOptions (9.69s)
--- FAIL: TestAccAWSTransferUser_disappears (9.89s)
--- FAIL: TestAccAWSTransferUser_homeDirectoryMappings (10.03s)
--- FAIL: TestAccAWSTransferUser_basic (10.22s)
--- PASS: TestAccAWSTransferUser_UserName_Validation (13.42s)

GovCloud acceptance test failures are pre-existing

@YakDriver YakDriver added this to the v3.12.0 milestone Oct 22, 2020
@YakDriver YakDriver merged commit 589ba7a into master Oct 22, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-transfer branch October 22, 2020 20:23
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/transfer Issues and PRs that pertain to the transfer service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @gdavison