Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Fix hardcoded (EMR Cluster) #15586

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15584
Relates #15662

Release note for CHANGELOG:

NONE

The output from acceptance testing (GovCloud):

--- PASS: TestAccAWSEMRCluster_additionalInfo (408.11s)
--- PASS: TestAccAWSEMRCluster_basic (413.79s)
--- PASS: TestAccAWSEMRCluster_disappears (429.36s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (453.63s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (520.64s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (562.69s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (603.51s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (741.37s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (794.80s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (808.58s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (369.06s)
--- PASS: TestAccAWSEMRCluster_security_config (435.07s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (434.11s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (850.33s)
--- FAIL: TestAccAWSEMRCluster_bootstrap_ordering (332.96s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (875.24s)
--- FAIL: TestAccAWSEMRCluster_instance_fleet (26.28s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (883.38s)
--- FAIL: TestAccAWSEMRCluster_instance_fleet_master_only (25.54s)
--- PASS: TestAccAWSEMRCluster_keepJob (317.48s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (381.75s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (946.47s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (777.51s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (407.40s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1263.04s)
--- PASS: TestAccAWSEMRCluster_ebs_config (439.52s)
--- PASS: TestAccAWSEMRCluster_s3Logging (496.25s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (457.87s)
--- PASS: TestAccAWSEMRCluster_tags (662.37s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (733.62s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (691.90s)

*Failures are unrelated and tracked in separate issues: #15608, #15607

The output from acceptance testing (commercial):

--- PASS: TestAccAWSEMRCluster_disappears (406.56s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (427.83s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (455.99s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (488.49s)
--- PASS: TestAccAWSEMRCluster_security_config (495.99s)
--- PASS: TestAccAWSEMRCluster_basic (517.58s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (556.26s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (675.79s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (762.57s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (925.43s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (925.55s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (971.56s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (974.08s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (978.40s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (590.60s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (1001.95s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (1003.73s)
--- PASS: TestAccAWSEMRCluster_s3Logging (538.72s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1029.92s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (1043.24s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (492.57s)
--- FAIL: TestAccAWSEMRCluster_keepJob (667.89s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (1106.16s)
--- PASS: TestAccAWSEMRCluster_ebs_config (456.74s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (461.75s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (809.42s)
--- PASS: TestAccAWSEMRCluster_instance_fleet_master_only (432.43s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1413.88s)
--- PASS: TestAccAWSEMRCluster_tags (957.77s)
--- PASS: TestAccAWSEMRCluster_instance_fleet (529.69s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (1033.31s)

*failure is flaky

@YakDriver YakDriver requested a review from a team October 9, 2020 22:15
@YakDriver YakDriver added partition/aws-us-gov Pertains to the aws-us-gov partition. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. labels Oct 9, 2020
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 9, 2020
@YakDriver YakDriver force-pushed the t-gov-partition-emr-cluster branch from a2b5c0c to 6b80a7a Compare October 9, 2020 23:17
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 9, 2020
@YakDriver
Copy link
Member Author

YakDriver commented Oct 9, 2020

The acceptance tests for this resource are a cautionary tale for composed configs. Adding the current partition data source config everywhere it was needed but not twice, proved interesting:

Consumers of data.aws_partition.current

Config Use Times Config Used
testAccAWSEmrClusterConfigCoreInstanceGroupAutoscalingPolicy direct 2 use(s)
testAccAWSEmrClusterConfigCoreInstanceGroupAutoscalingPolicyRemoved direct 1 use(s)
testAccAWSEmrClusterConfigS3Logging direct 1 use(s)
testAccAWSEmrClusterConfigIAMServiceRoleBase composition 14 use(s)
testAccAWSEmrClusterConfigIAMServiceRoleCustomAmiID composition 1 use(s)
testAccAWSEmrClusterConfigIAMInstanceProfileBase composition 15 use(s)
testAccAWSEmrClusterConfigIAMAutoscalingRole composition 9 use(s)

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in both partitions! Remaining failures on AWS GovCloud (US) are accounted for in other issues. 🚀

@YakDriver YakDriver added this to the v3.12.0 milestone Oct 15, 2020
@YakDriver YakDriver merged commit a1c8574 into master Oct 15, 2020
@YakDriver YakDriver deleted the t-gov-partition-emr-cluster branch October 15, 2020 21:12
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/emr Issues and PRs that pertain to the emr service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/provider: Provider produced inconsistent result after apply (r/emr_cluster)
2 participants