-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/neptune_engine_version: New data source #15259
Conversation
b065a45
to
e3b1c6a
Compare
Should we note an AWS bug in the docs? This seems to uncover a bug in the AWS API. If % aws neptune describe-db-engine-versions --engine neptune \
--query "DBEngineVersions[] [Engine, EngineVersion, DBParameterGroupFamily]" \
--output text | sort -u
neptune 1.0.1.0 neptune1
neptune 1.0.1.1 neptune1
neptune 1.0.1.2 neptune1
neptune 1.0.2.1 neptune1
neptune 1.0.2.2 neptune1
neptune 1.0.3.0 neptune1
% aws neptune describe-db-engine-versions --db-parameter-group-family neptune1
{
"DBEngineVersions": []
}
% aws docdb describe-db-engine-versions --db-parameter-group-family neptune1 --engine neptune
{
"DBEngineVersions": []
}
% aws docdb describe-db-engine-versions --db-parameter-group-family neptune1 --engine neptune --engine-version 1.0.2.2
{
"DBEngineVersions": []
}
% aws docdb describe-db-engine-versions --engine neptune --engine-version 1.0.2.2
{
"DBEngineVersions": [
{
"Engine": "neptune",
"EngineVersion": "1.0.2.2",
"DBParameterGroupFamily": "neptune1",
"DBEngineDescription": "neptune",
"DBEngineVersionDescription": "Neptune 1.0.2.2.R4",
"ValidUpgradeTarget": [
{
"Engine": "neptune",
"EngineVersion": "1.0.3.0",
"Description": "Neptune 1.0.3.0.R1",
"AutoUpgrade": false,
"IsMajorVersionUpgrade": false
}
],
"ExportableLogTypes": [
"audit"
],
"SupportsLogExportsToCloudwatchLogs": true
}
]
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Similar comments as #15228 🚀
Output from acceptance testing:
--- PASS: TestAccAWSNeptuneEngineVersionDataSource_defaultOnly (13.67s)
--- PASS: TestAccAWSNeptuneEngineVersionDataSource_basic (13.92s)
--- PASS: TestAccAWSNeptuneEngineVersionDataSource_preferred (14.09s)
e3b1c6a
to
0730420
Compare
This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #15257
Relates #15228, #15253
Release note for CHANGELOG:
The output from acceptance testing (GovCloud):
The output from acceptance testing (commercial):