Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_rds_orderable_db_instance: New data source #14853

Merged
merged 1 commit into from
Aug 31, 2020
Merged

data-source/aws_rds_orderable_db_instance: New data source #14853

merged 1 commit into from
Aug 31, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 26, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14834

Release note for CHANGELOG:

* data-source/aws_rds_orderable_db_instance: New data source to find valid RDS DB instance parameter
combinations

Output from acceptance testing:

Testing on GovCloud:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (17.07s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferred (17.53s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_versionPrefix (17.54s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersionPrefix (37.74s)

Testing on commercial/standard partition:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (13.75s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_versionPrefix (15.11s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferred (15.60s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersionPrefix (178.14s)

@YakDriver YakDriver requested a review from a team August 26, 2020 16:52
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 26, 2020
@YakDriver YakDriver force-pushed the f-rds-orderable-db branch 2 times, most recently from e20eaea to a56c674 Compare August 26, 2020 17:47
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Aug 26, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
bflad
bflad suggested changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking on the right track -- just a few things and we'll get this in!

aws/data_source_aws_rds_orderable_db_instance.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_orderable_db_instance.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_orderable_db_instance.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_orderable_db_instance_test.go Outdated Show resolved Hide resolved
website/docs/d/rds_orderable_db_instance.markdown Outdated Show resolved Hide resolved
@YakDriver
Copy link
Member Author

YakDriver commented Aug 31, 2020 •
edited
Loading

Post changes:

Gov cloud:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (16.33s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferred (15.86s)

Commercial:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (13.53s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferred (14.79s)

@YakDriver YakDriver requested a review from bflad August 31, 2020 17:08
@YakDriver YakDriver mentioned this pull request Aug 31, 2020
Closed
@bflad bflad added the new-data-source Introduces a new data source. label Aug 31, 2020
bflad
bflad approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, two little potential cleanups and :shipit:

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (13.68s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferred (14.30s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferred (8.68s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (8.80s)

aws/data_source_aws_rds_orderable_db_instance.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_orderable_db_instance.go Outdated Show resolved Hide resolved
@YakDriver YakDriver force-pushed the f-rds-orderable-db branch 2 times, most recently from 5e7eba1 to 2b2b337 Compare August 31, 2020 20:12
@YakDriver YakDriver added this to the v3.5.0 milestone Aug 31, 2020
@YakDriver YakDriver merged commit 3886e9b into master Aug 31, 2020
@YakDriver YakDriver deleted the f-rds-orderable-db branch August 31, 2020 20:23
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

data-source/aws_rds_orderable_db_instance: New data source
2 participants
@YakDriver @bflad